You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Quatters (via GitHub)" <gi...@apache.org> on 2025/06/07 09:14:24 UTC
[PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Quatters opened a new pull request, #33716:
URL: https://github.com/apache/superset/pull/33716
### SUMMARY
This PR introduces a new "Timeline Chart" visualization plugin to Apache Superset, built using Apache ECharts. This chart addresses the current lack of timeline-based visualizations, enabling users to effectively analyze event sequences and durations across a horizontal time axis.
Key features include:
* Representation of event durations as horizontal bars on a continuous time axis.
* Support for category-based vertical grouping with nested subcategories, facilitating detailed analysis within larger contexts.
* Functionality for fixed left/right time boundaries to compare intervals.
* Native ECharts zoom and scroll support for interactive data exploration.
The expected input data format includes `start_time` and `end_time`, a main category for the Y-axis, and an optional dimension for subcategories. Additional fields are supported for tooltips, enhancing data context upon interaction.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Import demo: [Chart Export Jun 07 2025.zip](https://github.com/user-attachments/files/20637889/Chart.Export.Jun.07.2025.zip)
It uses dataset of *examples* database. [data.csv](https://github.com/user-attachments/files/20637898/data.csv)
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Closes #33349
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3184737247
I advise against running a deployment based on a specific master commit, it may make it hard to migrate later and as you note master branch can be unstable.
@iliakasianov the timelines for Superset releases are hard to pin down. My understanding is that folks are working on stabilizing master branch right now for the 6.0.0 release. My best guess would be a 6.0.0 release candidate being cut in the next few weeks for testing. Then depending on how the testing and voting goes, maybe another month or so for the official release (that part is highly variable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "Quatters (via GitHub)" <gi...@apache.org>.
Quatters commented on code in PR #33716:
URL: https://github.com/apache/superset/pull/33716#discussion_r2133752097
##########
superset-frontend/src/components/TimePicker/index.tsx:
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import {
+ TimePicker as AntdTimePicker,
+ TimePickerProps,
+ TimeRangePickerProps,
+} from 'antd-v5';
+
+export const TimePicker = (props: TimePickerProps) => (
+ <AntdTimePicker css={{ width: '100%' }} {...props} />
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-2956443411
Thanks for the PR @Quatters. Could you add a video, demonstrating the new plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3020024404
@mistercrunch Ephemeral environment spinning up at http://35.91.161.145:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "iliakasianov (via GitHub)" <gi...@apache.org>.
iliakasianov commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3155068427
In what release can we start using this chart?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-2967399710
So cool, thank you! Spinning up an ephemeral env so we can all play with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "Quatters (via GitHub)" <gi...@apache.org>.
Quatters commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-2965112419
> Thanks for the PR @Quatters. Could you add a video, demonstrating the new plugin?
Sure! I've replaced gif with demo video.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3032809840
@mistercrunch Ephemeral environment spinning up at http://18.236.253.130:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3185110540
Also longer term we'd love to get `master` to be more releasable and/or increase release velocity in general. Both these goals are highly related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "Quatters (via GitHub)" <gi...@apache.org>.
Quatters commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3032495744
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3032777916
@mistercrunch Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/16055048096). Action: **up**. More information on [how to use or configure ephemeral environments](https://superset.apache.org/docs/contributing/howtos/#github-ephemeral-environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #33716:
URL: https://github.com/apache/superset/pull/33716#discussion_r2150581959
##########
superset-frontend/packages/superset-ui-chart-controls/src/sections/chartTitle.tsx:
##########
@@ -47,21 +76,7 @@ export const titleControls: ControlPanelSectionConfig = {
},
},
],
- [
- {
- name: 'x_axis_title_margin',
- config: {
- type: 'SelectControl',
- freeForm: true,
- clearable: true,
- label: t('X Axis Title Margin'),
- renderTrigger: true,
- default: TITLE_MARGIN_OPTIONS[0],
- choices: formatSelectOptions(TITLE_MARGIN_OPTIONS),
- description: t('Changing this control takes effect instantly'),
- },
- },
- ],
+ [xAxisTitleMarginControl],
Review Comment:
for consistency with other charts, should you just bring the entire `titleControls` section here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-2967399518
@rusackas Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/15615422976). Action: **up**. More information on [how to use or configure ephemeral environments](https://superset.apache.org/docs/contributing/howtos/#github-ephemeral-environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3185115876
> Hello @sadpandajoe, do you know the approximate release date of 6.0.0? Because I tried many different master images, and unfortunately, they have different bugs, and very often, some of the functionality does not work. And since we really need this chart, I would like to understand the release dates. Thank you very much in advance for your answer.
The other method you can do is to create a branch you are using and cherry-pick the commit in. It could be pretty brutal though. But to get 6.0 out the door faster, it might be good for you to create issues you might have already seen, that way if they are blockers they'll get addressed and hopefully will get 6.0 stabilized quicker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #33716:
URL: https://github.com/apache/superset/pull/33716#discussion_r2133686104
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeline/constants.ts:
##########
@@ -0,0 +1,8 @@
+export const ELEMENT_HEIGHT_SCALE = 0.85 as const;
Review Comment:
### Unexplained Magic Number <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The magic number 0.85 lacks context about its purpose in scaling element height.
###### Why this matters
Without understanding why 0.85 was chosen, future developers may hesitate to modify this value when needed or may misuse it in other contexts.
###### Suggested change ∙ *Feature Preview*
```typescript
// Define why 0.85 was chosen for height scaling
export const ELEMENT_HEIGHT_SCALE = 0.85 as const; // Provides adequate spacing between timeline elements while maintaining density
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818a1711-7725-4bd3-be0c-800acc02dd84/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818a1711-7725-4bd3-be0c-800acc02dd84?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818a1711-7725-4bd3-be0c-800acc02dd84?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818a1711-7725-4bd3-be0c-800acc02dd84?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818a1711-7725-4bd3-be0c-800acc02dd84)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:465cd69e-baf3-4e5e-8811-1b95ec931fed -->
[](465cd69e-baf3-4e5e-8811-1b95ec931fed)
##########
superset-frontend/src/components/TimePicker/index.tsx:
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import {
+ TimePicker as AntdTimePicker,
+ TimePickerProps,
+ TimeRangePickerProps,
+} from 'antd-v5';
+
+export const TimePicker = (props: TimePickerProps) => (
+ <AntdTimePicker css={{ width: '100%' }} {...props} />
+);
Review Comment:
### TimePicker width not configurable <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The hardcoded width: '100%' CSS property may override any width specified in the props, potentially breaking custom width configurations needed for the Timeline Chart visualization.
###### Why this matters
Users of the TimePicker component won't be able to customize the width through props, which could lead to layout issues in different contexts of the Timeline Chart.
###### Suggested change ∙ *Feature Preview*
Make the width configurable by merging CSS props:
```typescript
export const TimePicker = ({ style, ...props }: TimePickerProps) => (
<AntdTimePicker
css={{ width: '100%', ...style }}
{...props}
/>
);
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91804b20-3c58-48ee-9837-2d564ddb4ed8/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91804b20-3c58-48ee-9837-2d564ddb4ed8?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91804b20-3c58-48ee-9837-2d564ddb4ed8?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91804b20-3c58-48ee-9837-2d564ddb4ed8?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91804b20-3c58-48ee-9837-2d564ddb4ed8)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:5046e43c-1fc8-4ea4-ac26-0de2ec092340 -->
[](5046e43c-1fc8-4ea4-ac26-0de2ec092340)
##########
superset-frontend/src/components/TimePicker/index.tsx:
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import {
+ TimePicker as AntdTimePicker,
+ TimePickerProps,
+ TimeRangePickerProps,
+} from 'antd-v5';
+
+export const TimePicker = (props: TimePickerProps) => (
+ <AntdTimePicker css={{ width: '100%' }} {...props} />
Review Comment:
### Inline CSS Should Be In Styled Components Or Theme <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
Hardcoded CSS values directly in components reduces readability and maintainability.
###### Why this matters
Inline styles make it harder to maintain consistent styling across components and require developers to search through component code rather than a centralized styling file.
###### Suggested change ∙ *Feature Preview*
Extract the common styling to a styled component or theme constant:
```typescript
const commonPickerStyles = { width: '100%' };
export const TimePicker = (props: TimePickerProps) => (
<AntdTimePicker css={commonPickerStyles} {...props} />
);
export const TimeRangePicker = (props: TimeRangePickerProps) => (
<AntdTimePicker.RangePicker css={commonPickerStyles} {...props} />
);
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/44695817-7937-431b-a1c3-c0b9e8c494d7/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/44695817-7937-431b-a1c3-c0b9e8c494d7?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/44695817-7937-431b-a1c3-c0b9e8c494d7?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/44695817-7937-431b-a1c3-c0b9e8c494d7?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/44695817-7937-431b-a1c3-c0b9e8c494d7)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:8ea7cf55-e69a-4a5a-9aa7-0bcdf97ca9d6 -->
[](8ea7cf55-e69a-4a5a-9aa7-0bcdf97ca9d6)
##########
superset-frontend/src/explore/components/controls/TimeRangeControl/index.tsx:
##########
@@ -0,0 +1,47 @@
+import { useMemo } from 'react';
+import dayjs from 'dayjs';
+import { TimeRangePicker } from 'src/components/TimePicker';
+import ControlHeader, { ControlHeaderProps } from '../../ControlHeader';
+
+type TimeRangeValueType = [string, string];
+
+export interface TimeRangeControlProps extends ControlHeaderProps {
+ value?: TimeRangeValueType;
+ onChange?: (value: TimeRangeValueType, errors: any) => void;
+ allowClear?: boolean;
+ showNow?: boolean;
+ allowEmpty?: [boolean, boolean];
+}
+
+export default function TimeRangeControl({
+ value: stringValue,
+ onChange,
+ allowClear,
+ showNow,
+ allowEmpty,
+ ...rest
+}: TimeRangeControlProps) {
+ const dayjsValue = useMemo(() => {
+ const ret: [dayjs.Dayjs | null, dayjs.Dayjs | null] = [null, null];
+ if (stringValue?.[0]) {
+ ret[0] = dayjs.utc(stringValue[0], 'HH:mm:ss');
Review Comment:
### Missing error handling for date parsing <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The dayjs.utc() parsing operation could fail with invalid time strings, but there's no error handling for this case.
###### Why this matters
If the input string is not in the expected 'HH:mm:ss' format, the application might silently fail or produce incorrect dates without any indication of the parsing error.
###### Suggested change ∙ *Feature Preview*
Add try-catch block around the date parsing operations and propagate errors through the onChange callback:
```typescript
const dayjsValue = useMemo(() => {
const ret: [dayjs.Dayjs | null, dayjs.Dayjs | null] = [null, null];
let error = null;
try {
if (stringValue?.[0]) {
ret[0] = dayjs.utc(stringValue[0], 'HH:mm:ss');
if (!ret[0].isValid()) throw new Error('Invalid start time format');
}
if (stringValue?.[1]) {
ret[1] = dayjs.utc(stringValue[1], 'HH:mm:ss');
if (!ret[1].isValid()) throw new Error('Invalid end time format');
}
} catch (e) {
error = e instanceof Error ? e.message : 'Invalid time format';
}
return { value: ret, error };
}, [stringValue]);
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ebe569a8-5882-4f5b-a540-76b3ebf891eb/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ebe569a8-5882-4f5b-a540-76b3ebf891eb?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ebe569a8-5882-4f5b-a540-76b3ebf891eb?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ebe569a8-5882-4f5b-a540-76b3ebf891eb?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ebe569a8-5882-4f5b-a540-76b3ebf891eb)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:00f166b0-bece-4a03-8698-04cc7c81e5e8 -->
[](00f166b0-bece-4a03-8698-04cc7c81e5e8)
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeline/index.ts:
##########
@@ -0,0 +1,36 @@
+import { Behavior, t } from '@superset-ui/core';
+import transformProps from './transformProps';
+import controlPanel from './controlPanel';
+import buildQuery from './buildQuery';
+import { EchartsChartPlugin } from '../types';
+import thumbnail from './images/thumbnail.png';
+import example1 from './images/example1.png';
+import example2 from './images/example2.png';
+
+export default class EchartsTimelineChartPlugin extends EchartsChartPlugin {
+ constructor() {
+ super({
+ buildQuery,
+ controlPanel,
+ loadChart: () => import('./EchartsTimeline'),
Review Comment:
### Unhandled Dynamic Import <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
Dynamic import without error handling or loading state management could lead to uncaught promise rejections and poor user experience during chart loading failures.
###### Why this matters
If the dynamic import fails, it could cause the entire chart to fail silently or provide no feedback to the user, impacting the application's reliability and user experience.
###### Suggested change ∙ *Feature Preview*
Implement error handling and loading state management for the dynamic import. Example:
```typescript
loadChart: () => import('./EchartsTimeline').catch(error => {
console.error('Failed to load Timeline chart:', error);
throw error;
})
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c508f9f7-6c61-49e4-b757-fb64eb937719/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c508f9f7-6c61-49e4-b757-fb64eb937719?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c508f9f7-6c61-49e4-b757-fb64eb937719?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c508f9f7-6c61-49e4-b757-fb64eb937719?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c508f9f7-6c61-49e4-b757-fb64eb937719)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:fb7ab3b5-118d-4f09-98a9-810e483b2e9a -->
[](fb7ab3b5-118d-4f09-98a9-810e483b2e9a)
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeline/constants.ts:
##########
@@ -0,0 +1,8 @@
+export const ELEMENT_HEIGHT_SCALE = 0.85 as const;
+
+export enum Dimension {
+ StartTime = 'start_time',
+ EndTime = 'end_time',
+ Index = 'index',
+ SeriesCount = 'series_count',
+}
Review Comment:
### Inconsistent Enum Naming Convention <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The enum naming is inconsistent, mixing camelCase for enum members with snake_case for string values.
###### Why this matters
Inconsistent naming patterns increase cognitive load and can lead to confusion when using the enum throughout the codebase.
###### Suggested change ∙ *Feature Preview*
```typescript
export enum Dimension {
StartTime = 'startTime',
EndTime = 'endTime',
Index = 'index',
SeriesCount = 'seriesCount',
}
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4a26bb6f-acc9-4ec1-aef6-200874953369/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4a26bb6f-acc9-4ec1-aef6-200874953369?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4a26bb6f-acc9-4ec1-aef6-200874953369?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4a26bb6f-acc9-4ec1-aef6-200874953369?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4a26bb6f-acc9-4ec1-aef6-200874953369)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:a9fd45b5-0dff-4bb2-9393-bf4529215ac9 -->
[](a9fd45b5-0dff-4bb2-9393-bf4529215ac9)
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeline/index.ts:
##########
@@ -0,0 +1,36 @@
+import { Behavior, t } from '@superset-ui/core';
+import transformProps from './transformProps';
+import controlPanel from './controlPanel';
+import buildQuery from './buildQuery';
+import { EchartsChartPlugin } from '../types';
+import thumbnail from './images/thumbnail.png';
+import example1 from './images/example1.png';
+import example2 from './images/example2.png';
+
+export default class EchartsTimelineChartPlugin extends EchartsChartPlugin {
+ constructor() {
+ super({
+ buildQuery,
+ controlPanel,
+ loadChart: () => import('./EchartsTimeline'),
+ metadata: {
+ behaviors: [
+ Behavior.InteractiveChart,
+ Behavior.DrillToDetail,
+ Behavior.DrillBy,
+ ],
+ credits: ['https://echarts.apache.org'],
+ name: t('Timeline'),
+ description: t(
+ 'Timeline chart visualizes important events over a time span. ' +
+ 'Every data point displayed as a separate event along a ' +
+ 'horizontal line.',
+ ),
Review Comment:
### Use template literals for multi-line strings <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
String concatenation using + operator for a multi-line description makes the text harder to read and maintain.
###### Why this matters
String concatenation with + operator creates visual noise and makes text modifications more error-prone. Template literals provide better readability for multi-line strings.
###### Suggested change ∙ *Feature Preview*
```typescript
description: t(`
Timeline chart visualizes important events over a time span.
Every data point displayed as a separate event along a horizontal line.
`),
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4ff1a3c3-f129-4ec5-99e5-6c3a5787ef3a/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4ff1a3c3-f129-4ec5-99e5-6c3a5787ef3a?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4ff1a3c3-f129-4ec5-99e5-6c3a5787ef3a?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4ff1a3c3-f129-4ec5-99e5-6c3a5787ef3a?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4ff1a3c3-f129-4ec5-99e5-6c3a5787ef3a)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:40c0321a-9fd9-4f0d-a00c-559330476bf7 -->
[](40c0321a-9fd9-4f0d-a00c-559330476bf7)
##########
superset-frontend/src/explore/components/controls/TimeRangeControl/index.tsx:
##########
@@ -0,0 +1,47 @@
+import { useMemo } from 'react';
+import dayjs from 'dayjs';
+import { TimeRangePicker } from 'src/components/TimePicker';
+import ControlHeader, { ControlHeaderProps } from '../../ControlHeader';
+
+type TimeRangeValueType = [string, string];
+
+export interface TimeRangeControlProps extends ControlHeaderProps {
+ value?: TimeRangeValueType;
+ onChange?: (value: TimeRangeValueType, errors: any) => void;
+ allowClear?: boolean;
+ showNow?: boolean;
+ allowEmpty?: [boolean, boolean];
+}
Review Comment:
### Missing interface prop descriptions <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The interface props lack descriptions explaining their purpose and expected values, particularly for non-obvious props like allowEmpty which uses a tuple type.
###### Why this matters
Without clear prop descriptions, other developers will need to investigate the implementation or experiment to understand the expected behavior of each prop.
###### Suggested change ∙ *Feature Preview*
/**
* Props for the TimeRangeControl component
*/
export interface TimeRangeControlProps extends ControlHeaderProps {
/** The current time range value in HH:mm:ss format */
value?: TimeRangeValueType;
/** Callback when time range changes. Errors are currently unused */
onChange?: (value: TimeRangeValueType, errors: any) => void;
/** Whether to show the clear button */
allowClear?: boolean;
/** Whether to show the 'Now' shortcut */
showNow?: boolean;
/** Controls whether start and end times can be empty [startEmpty, endEmpty] */
allowEmpty?: [boolean, boolean];
}
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9c112b53-eb04-40fb-949f-e4d65d395b87/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9c112b53-eb04-40fb-949f-e4d65d395b87?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9c112b53-eb04-40fb-949f-e4d65d395b87?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9c112b53-eb04-40fb-949f-e4d65d395b87?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9c112b53-eb04-40fb-949f-e4d65d395b87)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:ed7a079f-a7f6-45af-b608-0ac73b02eaf7 -->
[](ed7a079f-a7f6-45af-b608-0ac73b02eaf7)
##########
superset-frontend/src/explore/components/controls/TimeRangeControl/index.tsx:
##########
@@ -0,0 +1,47 @@
+import { useMemo } from 'react';
+import dayjs from 'dayjs';
+import { TimeRangePicker } from 'src/components/TimePicker';
+import ControlHeader, { ControlHeaderProps } from '../../ControlHeader';
+
+type TimeRangeValueType = [string, string];
+
+export interface TimeRangeControlProps extends ControlHeaderProps {
+ value?: TimeRangeValueType;
+ onChange?: (value: TimeRangeValueType, errors: any) => void;
+ allowClear?: boolean;
+ showNow?: boolean;
+ allowEmpty?: [boolean, boolean];
+}
+
+export default function TimeRangeControl({
+ value: stringValue,
+ onChange,
+ allowClear,
+ showNow,
+ allowEmpty,
+ ...rest
+}: TimeRangeControlProps) {
+ const dayjsValue = useMemo(() => {
+ const ret: [dayjs.Dayjs | null, dayjs.Dayjs | null] = [null, null];
+ if (stringValue?.[0]) {
+ ret[0] = dayjs.utc(stringValue[0], 'HH:mm:ss');
+ }
+ if (stringValue?.[1]) {
+ ret[1] = dayjs.utc(stringValue[1], 'HH:mm:ss');
+ }
+ return ret;
+ }, [stringValue]);
Review Comment:
### Unnecessary Memoization <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The useMemo hook is used for a relatively simple time parsing operation that doesn't justify the overhead of memoization.
###### Why this matters
Memoization adds memory overhead and complexity to maintain the cache. For simple operations like parsing two time strings, the performance benefit is negligible and the overhead of memoization might actually be more costly.
###### Suggested change ∙ *Feature Preview*
Remove the useMemo hook and perform the time parsing directly:
```typescript
const dayjsValue: [dayjs.Dayjs | null, dayjs.Dayjs | null] = [
stringValue?.[0] ? dayjs.utc(stringValue[0], 'HH:mm:ss') : null,
stringValue?.[1] ? dayjs.utc(stringValue[1], 'HH:mm:ss') : null
];
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/97d6e987-9939-44ad-81ed-8313ffcb2534/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/97d6e987-9939-44ad-81ed-8313ffcb2534?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/97d6e987-9939-44ad-81ed-8313ffcb2534?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/97d6e987-9939-44ad-81ed-8313ffcb2534?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/97d6e987-9939-44ad-81ed-8313ffcb2534)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:8766a5bf-5b39-41c8-baa2-bc156b4c208a -->
[](8766a5bf-5b39-41c8-baa2-bc156b4c208a)
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/SmoothLine/controlPanel.tsx:
##########
@@ -99,18 +98,7 @@ const config: ControlPanelConfig = {
},
},
],
- [
- {
- name: 'zoomable',
- config: {
- type: 'CheckboxControl',
- label: t('Data Zoom'),
- default: zoomable,
- renderTrigger: true,
- description: t('Enable data zooming controls'),
- },
- },
- ],
+ ['zoomable'],
Review Comment:
### Potentially Missing Zoom Control Definition <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The zoomable control is simplified to a string reference but there's no indication that this control exists elsewhere in the codebase. This could lead to a missing or non-functional zoom control in the UI.
###### Why this matters
If the zoomable control is not properly defined elsewhere, users won't be able to enable/disable data zooming functionality in the chart, which is a critical feature for time series visualizations.
###### Suggested change ∙ *Feature Preview*
Either define the zoomable control in a shared controls file or restore the original implementation:
```typescript
[
{
name: 'zoomable',
config: {
type: 'CheckboxControl',
label: t('Data Zoom'),
default: zoomable,
renderTrigger: true,
description: t('Enable data zooming controls'),
},
},
]
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a60cfd32-b303-4bac-aa96-f139bf757105/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a60cfd32-b303-4bac-aa96-f139bf757105?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a60cfd32-b303-4bac-aa96-f139bf757105?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a60cfd32-b303-4bac-aa96-f139bf757105?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a60cfd32-b303-4bac-aa96-f139bf757105)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:997a7253-51a3-4122-9952-78d7a7dd708a -->
[](997a7253-51a3-4122-9952-78d7a7dd708a)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "koolanit (via GitHub)" <gi...@apache.org>.
koolanit commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3218202415
Hello - I tested 6.0.0rc1 and don't see any customization for the y-axis which appears to be hardcoded to 8 characters with center alignment of text. I need to have the ability to show at least 30 characters with left alignment and wrapping. Also, is there a way to have a custom SQL to display a hyperlink?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "iliakasianov (via GitHub)" <gi...@apache.org>.
iliakasianov commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3178833580
Hello @sadpandajoe, do you know the approximate release date of 6.0.0? Because I tried many different master images, and unfortunately, they have different bugs, and very often, some of the functionality does not work. And since we really need this chart, I would like to understand the release dates. Thank you very much in advance for your answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-2968356989
> My only immediate suggestion is that I feel like "Gantt chart" is a more common name for this than "Timeline chart."
I was going to comment that typically Gantt charts include a graph of dependencies and arrows to visualize them, but GPT seems to think it's not a strict requirement -> https://chatgpt.com/share/684b5885-26c0-8010-b92e-74248625313c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "Quatters (via GitHub)" <gi...@apache.org>.
Quatters commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-2972273137
Ok, I don't see any issues with renaming chart to Gantt. A quick search shows that Gantt chart much more often used with this type then Timeline (which is more generic to me). I also thought dependencies visualisation is mandatory for Gantt, but it's not.
Good suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "Quatters (via GitHub)" <gi...@apache.org>.
Quatters commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3032529623
> Getting this in the "Featured Charts" dashboard -> <img alt="Screenshot 2025-07-02 at 9 17 38 AM" width="627" src="https://private-user-images.githubusercontent.com/487433/461618864-68fa0615-51e2-45c8-a84e-ed6e7028509b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTE1NTM0MDEsIm5iZiI6MTc1MTU1MzEwMSwicGF0aCI6Ii80ODc0MzMvNDYxNjE4ODY0LTY4ZmEwNjE1LTUxZTItNDVjOC1hODRlLWVkNmU3MDI4NTA5Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDcwM1QxNDMxNDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMjgxYWUyNGEzMDI0ZDBiN2QxNjI1ZDcyNGI5YzUzMDcwOTYxZDc1MmJmOGJmMzljYzA1MzI4ZTQzZjA5OWE3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.CO_z1wk5IKvDP-NxbRzFdePiOvV3Qf-6-f00-z_RahY">
Seems that sqlite does not support `... as data(col1, col2, ...)` column naming. I rewrote SQL query so it should work now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3033688375
Works!
<img width="557" alt="Screenshot 2025-07-03 at 2 22 19 PM" src="https://github.com/user-attachments/assets/4f4d3485-ec23-48a1-b5fb-3b2753d3bdff" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-2967429021
@rusackas Ephemeral environment spinning up at http://35.88.138.93:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #33716:
URL: https://github.com/apache/superset/pull/33716#discussion_r2133752372
##########
superset-frontend/src/components/TimePicker/index.tsx:
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import {
+ TimePicker as AntdTimePicker,
+ TimePickerProps,
+ TimeRangePickerProps,
+} from 'antd-v5';
+
+export const TimePicker = (props: TimePickerProps) => (
+ <AntdTimePicker css={{ width: '100%' }} {...props} />
Review Comment:
Thanks for implementing the change! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "iliakasianov (via GitHub)" <gi...@apache.org>.
iliakasianov commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3158296547
> Probably in 6.0
Thanks for the answer. Is there any way to use this chart now, maybe as an external plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3156683519
> In what release can we start using this chart?
Probably in 6.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Timeline Chart visualization [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-2966382133
Thank your for the video (and the contribution!), I think this looks great. My only immediate suggestion is that I feel like "Gantt chart" is a more common name for this than "Timeline chart."
There are more comments in our repo for "Gantt chart" including this feature request with many upvotes - your feature will make them happy 😁 https://github.com/apache/superset/discussions/23503 so I think that's what our users will search for. And Wikipedia calls it a Gantt chart, it has no entry for timeline chart.
What do you think about renaming this chart to be "Gantt chart"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3160772964
> > Probably in 6.0
>
> Thanks for the answer. Is there any way to use this chart now, maybe as an external plugin?
If it's on master, you can just pull master now and deploy that somewhere and start using it. There just isn't pypi support for it now, but I believe even docker gets created with master branch too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3185099388
> do you know the approximate release date of 6.0.0
We'll be cutting the branch this week I'm hoping, and from there we'll need all the help we can get to stabilize the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3028471858
Getting this in the "Featured Charts" dashboard ->
<img width="627" alt="Screenshot 2025-07-02 at 9 17 38 AM" src="https://github.com/user-attachments/assets/68fa0615-51e2-45c8-a84e-ed6e7028509b" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33716:
URL: https://github.com/apache/superset/pull/33716#issuecomment-3019965941
@mistercrunch Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/15978830183). Action: **up**. More information on [how to use or configure ephemeral environments](https://superset.apache.org/docs/contributing/howtos/#github-ephemeral-environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(plugin-chart-echarts): add Gantt Chart plugin [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #33716:
URL: https://github.com/apache/superset/pull/33716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org