You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/26 23:51:00 UTC
[jira] [Commented] (SAMZA-1732) Reduce the coordination timeouts in
TestZkLocalApplicationRunner tests.
[ https://issues.apache.org/jira/browse/SAMZA-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491851#comment-16491851 ]
ASF GitHub Bot commented on SAMZA-1732:
---------------------------------------
GitHub user shanthoosh opened a pull request:
https://github.com/apache/samza/pull/537
SAMZA-1732: Reduce the coordination timeouts in TestZkLocalApplicationRunner tests.
Currently all the tests in TestZkLocalApplicationRunner takes around 5 minutes to finish. Reducing the coordination timeout to reduce the test time.
Changes in TestZkLocalApplicationRunner test timeout values:
* Change debounce timeout from 20 seconds to 2 seconds.
* Change task.shutdown timeout from 30 seconds to 5 seconds.
* Change barrier timeout from 40 seconds to 2 seconds.
**Verification:**
```bash
[svenkata@svenkata-ld2 ~]$ cat ~/runTests-1.sh
i=0
while [ $i -lt 151 ]; do
i=`expr $i + 1`
echo "Run " +$i
./gradlew clean :samza-test:test -Dtest.single="TestZkLocalApplicationRunner" --debug --stacktrace >> ~/test-logs-runTests-1_23
done;
```
**Result:**
```bash
[svenkata@svenkata-ld2 ~]$ grep 'BUILD FAIL' test-logs-runTests-1_23 |wc -l
0
[svenkata@svenkata-ld2 ~]$ grep 'BUILD SUCCESS' test-logs-runTests-1_23 |wc -l
151
```
After this change, execution time of TestZkLocalApplicationRunner tests has reduced from `310` seconds to `55` seconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shanthoosh/samza reduce_zk_localAppRunnerTestTime
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #537
----
commit db1db2a00fa72b7afd8c80e74ccd116411197764
Author: Shanthoosh Venkataraman <sv...@...>
Date: 2018-05-26T11:26:39Z
Reduce the coordination timeouts in TestZkLocalApplicationRunner tests.
Changes in TestZkLocalApplicationRunner test timeout values:
1. Change debounce timeout from 20 seconds to 2 seconds.
2. Change task.shutdown timeout from 30 seconds to 5 seconds.
3. Change barrier timeout from 40 seconds to 2 seonds.
----
> Reduce the coordination timeouts in TestZkLocalApplicationRunner tests.
> -----------------------------------------------------------------------
>
> Key: SAMZA-1732
> URL: https://issues.apache.org/jira/browse/SAMZA-1732
> Project: Samza
> Issue Type: Bug
> Reporter: Shanthoosh Venkataraman
> Assignee: Shanthoosh Venkataraman
> Priority: Major
>
> *Problem:*
> Currently all the tests in TestZkLocalApplicationRunner takes around 5 minutes to finish. This unnecessarily increases the build time of :samza-test module and the overall samza codebase build.
> *Fix:*
> Reducing the zookeeper coordination timeout in all the TestZkLocalApplicationRunner tests to reduce the test time.
>
> * Change debounce timeout from 20 seconds to 2 seconds.
> * Change task.shutdown timeout from 30 seconds to 5 seconds.
> * Change barrier timeout from 40 seconds to 2 seconds.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)