[GitHub] azai91 commented on a change in pull request #11026: Test/mkl dnn act

[GitBox <gi...@apache.org>]

azai91 commented on a change in pull request #11026: Test/mkl dnn act
URL: https://github.com/apache/incubator-mxnet/pull/11026#discussion_r191116270
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_sum.cc
 ##########
 @@ -62,12 +62,9 @@ void MKLDNNSumForward(const nnvm::NodeAttrs& attrs, const OpContext &ctx,
   std::vector<NDArray> in_bufs(inputs.size());
   for (size_t i = 0; i < inputs.size(); i++) {
     const mkldnn::memory *in_mem;
-    if (inputs[i].IsMKLDNNData() && inputs[i].IsView()) {
+    if (inputs[i].IsMKLDNNData() && inputs[i].IsView())
       in_bufs[i] = inputs[i].Reorder2Default();
-      in_mem = in_bufs[i].GetMKLDNNData();
-    } else {
-      in_mem = inputs[i].GetMKLDNNData();
-    }
+    in_mem = inputs[i].GetMKLDNNData();
 
 Review comment:
   woops realized it was not the same. reverted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services