[GitHub] [accumulo] ctubbsii commented on a change in pull request #2109: Apply replaceAll to all parts of JSON strings

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2109:
URL: https://github.com/apache/accumulo/pull/2109#discussion_r632027010



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -442,7 +442,7 @@
       "The maximum number of files a compaction will open"),
   TSERV_COMPACTION_SERVICE_ROOT_EXECUTORS(
       "tserver.compaction.major.service.root.planner.opts.executors",
-      "[{'name':'small','maxSize':'32M','numThreads':1},"
+      "[{'name':'small','maxSize':'32M','numThreads':1},".replaceAll("'", "\"")
           + "{'name':'huge','numThreads':1}]".replaceAll("'", "\""),

Review comment:
       Could do this instead:
   
   ```suggestion
         ("[{'name':'small','maxSize':'32M','numThreads':1},"
             + "{'name':'huge','numThreads':1}]").replaceAll("'", "\""),
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org