You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "moleske (GitHub)" <gi...@apache.org> on 2018/11/18 23:09:01 UTC

[GitHub] [geode] moleske opened pull request #2873: GEODE-6073: All files have lf endings

- Spotless no longer uses line endings check as it is not recommened
- https://github.com/diffplug/spotless/tree/master/plugin-gradle#line-endings-and-encodings-invisible-stuff

Conversation [here ](https://markmail.org/message/2jippxjsl6a6r6ae )for those who want to follow along

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

~~- [ ] Have you written or updated unit tests to verify your changes?~~

~~- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~~

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2873 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #2873: GEODE-6073: All files have lf endings

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
This has broken basic cloning of the repo. See https://issues.apache.org/jira/browse/GEODE-6090

[ Full content available at: https://github.com/apache/geode/pull/2873 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #2873: GEODE-6073: All files have lf endings

Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
[ pull request closed by mcmellawatt ]

[ Full content available at: https://github.com/apache/geode/pull/2873 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on issue #2873: GEODE-6073: All files have lf endings

Posted by "moleske (GitHub)" <gi...@apache.org>.
Aww sad, I only tested cloning fresh, didn't test checking out old release branches :(

Ah well

[ Full content available at: https://github.com/apache/geode/pull/2873 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org