[GitHub] [lucene-solr] chatman commented on a change in pull request #675: SOLR-13350: Multi-threaded search through an index

[GitBox <gi...@apache.org>]

chatman commented on a change in pull request #675: SOLR-13350: Multi-threaded search through an index
URL: https://github.com/apache/lucene-solr/pull/675#discussion_r288442020
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java
 ##########
 @@ -115,6 +116,11 @@ public ScoreMode scoreMode() {
     return scoreMode;
   }
 
+  // nocommit: need to raise a LUCENE jira for this?
+  public List<Collector> getCollectors() {
+    return Collections.unmodifiableList(Arrays.asList(collectors));
+  }
 
 Review comment:
   It seems a bit tricky. I'm creating these wrapped MultiCollectors in the newCollector() method of a CollectorManager; in the reduce() method, I get these MultiCollectors back but I'm not sure how I can associate them to some storage (for List<Collector>) for each MultiCollector that I created in newCollector. Maybe, I can extend MultiCollector to associate additional data with each at the time of creation, but seemed ugly.
   
   This is used here: https://github.com/apache/lucene-solr/blob/e3b082a7f80f1682f650b531627b1af90eebc375/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L1700-L1716

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org