You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/11/15 09:21:47 UTC

Review Request 69342: Added an agent flag `--volume_gid_range`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Repository: mesos


Description
-------

When this flag is specified, if a task running as non-root user uses a
shared persistent volume or a SANDBOX volume of PARENT type, the volume
will be owned by a gid allocated from this range, and the task process
will be launched with the gid as its supplementary group.


Diffs
-----

  docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3 
  src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 
  src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 


Diff: https://reviews.apache.org/r/69342/diff/1/


Testing
-------


Thanks,

Qian Zhang


Re: Review Request 69342: Added an agent flag `--volume_gid_range`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 10:41 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8810
    https://issues.apache.org/jira/browse/MESOS-8810


Repository: mesos


Description
-------

When this flag is specified, if a task running as non-root user uses a
shared persistent volume or a SANDBOX_PATH volume of PARENT type, the
volume will be owned by a gid allocated from this range and have the
`setgit` bit set, and the task process will be launched with the gid
as its supplementary group.


Diffs
-----

  docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3 
  src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 
  src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 


Diff: https://reviews.apache.org/r/69342/diff/2/


Testing
-------


Thanks,

Qian Zhang


Re: Review Request 69342: Added an agent flag `--volume_gid_range`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/
-----------------------------------------------------------

(Updated Nov. 20, 2018, 10:10 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Repository: mesos


Description (updated)
-------

When this flag is specified, if a task running as non-root user uses a
shared persistent volume or a SANDBOX_PATH volume of PARENT type, the
volume will be owned by a gid allocated from this range and have the
`setgit` bit set, and the task process will be launched with the gid
as its supplementary group.


Diffs (updated)
-----

  docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3 
  src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 
  src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 


Diff: https://reviews.apache.org/r/69342/diff/2/

Changes: https://reviews.apache.org/r/69342/diff/1-2/


Testing
-------


Thanks,

Qian Zhang