You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2023/01/12 02:53:27 UTC

[GitHub] [inlong] gosonzhang opened a new pull request, #7224: [INLONG-7220][Manager] Optimize OpenStreamSinkController implementation

gosonzhang opened a new pull request, #7224:
URL: https://github.com/apache/inlong/pull/7224

   
   - Fixes #7220
   
   
   Modifications:
   1. Most of them add error codes to the exceptions thrown, adjust the logs, including removing the printed logs with clear exceptions, and adjust the log level to debug for the path logs;
   2. Adjust the field requirements of the SinkRequest request, and limit the mandatory fields for id-based and key-based updates respectively;
   3. Modify 2 Bugs:
     a. For the operation modified by id, the groupId and streamId are not allowed to be modified in the open api:
         ![image](https://user-images.githubusercontent.com/14038849/211964660-df4f60b7-4f2f-4303-acaa-397ee9b00eca.png)
   
     b. Correct the judgment on line 93 of HudiSinkOperator.java
         ![image](https://user-images.githubusercontent.com/14038849/211964501-940a811a-c95d-4394-9ecb-2b1a17ab1e45.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] fuweng11 commented on a diff in pull request #7224: [INLONG-7220][Manager] Optimize OpenStreamSinkController implementation

Posted by GitBox <gi...@apache.org>.
fuweng11 commented on code in PR #7224:
URL: https://github.com/apache/inlong/pull/7224#discussion_r1067664579


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/doris/DorisSinkOperator.java:
##########
@@ -81,7 +82,10 @@ public StreamSink getFromEntity(@NotNull StreamSinkEntity entity) {
         }
 
         DorisSinkDTO dto = DorisSinkDTO.getFromJson(entity.getExtParams());
-        Preconditions.checkNotEmpty(dto.getFeNodes(), "doris fe nodes is empty");
+        if (dto.getFeNodes() == null) {

Review Comment:
   Suggest to use` StringUtils.isNotBlank`.



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -414,37 +415,61 @@ public Boolean update(SinkRequest request, String operator) {
     @Transactional(rollbackFor = Throwable.class)
     public Boolean update(SinkRequest request, UserInfo opInfo) {
         // check request parameter
-        checkSinkRequestParams(request);
+        // checkSinkRequestParams(request);

Review Comment:
   Why not delete？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gosonzhang merged pull request #7224: [INLONG-7220][Manager] Optimize OpenStreamSinkController implementation

Posted by GitBox <gi...@apache.org>.
gosonzhang merged PR #7224:
URL: https://github.com/apache/inlong/pull/7224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gosonzhang commented on a diff in pull request #7224: [INLONG-7220][Manager] Optimize OpenStreamSinkController implementation

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #7224:
URL: https://github.com/apache/inlong/pull/7224#discussion_r1067702726


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/doris/DorisSinkOperator.java:
##########
@@ -81,7 +82,10 @@ public StreamSink getFromEntity(@NotNull StreamSinkEntity entity) {
         }
 
         DorisSinkDTO dto = DorisSinkDTO.getFromJson(entity.getExtParams());
-        Preconditions.checkNotEmpty(dto.getFeNodes(), "doris fe nodes is empty");
+        if (dto.getFeNodes() == null) {

Review Comment:
   done



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -414,37 +415,61 @@ public Boolean update(SinkRequest request, String operator) {
     @Transactional(rollbackFor = Throwable.class)
     public Boolean update(SinkRequest request, UserInfo opInfo) {
         // check request parameter
-        checkSinkRequestParams(request);
+        // checkSinkRequestParams(request);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org