You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/03/15 14:39:25 UTC

[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #511: Minificpp 764: Add docker builds for different systems.

phrocker commented on a change in pull request #511: Minificpp 764: Add docker builds for different systems.
URL: https://github.com/apache/nifi-minifi-cpp/pull/511#discussion_r266009211
 
 

 ##########
 File path: cmake/DockerConfig.cmake
 ##########
 @@ -20,6 +20,35 @@ add_custom_target(
     docker
     COMMAND ${CMAKE_SOURCE_DIR}/docker/DockerBuild.sh 1000 1000 ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH} minificppsource ${CMAKE_SOURCE_DIR}
     WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/docker/)
+    
+
+add_custom_target(
 
 Review comment:
   That was a consideration, but then make all in the build process would not be able to make everything. We'd have to pull up a parent Make to launch cmake produced targets, which seems less than ideal. Further, even not withstanding these considerations, the users would have two places to call make as a result. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services