[jira] [Commented] (BOOKKEEPER-664) Compaction increases latency on journal writes

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755761#comment-13755761 ] 

Rakesh R commented on BOOKKEEPER-664:
-------------------------------------

@Ivan, the patch looks good. Just adding few points:

- 'compactionsMaxOutstandingRequests' - please remove 's' can we just say 'compactionMaxOutstandingRequests'.
Also, would be good to have long datatype for this configuration.

- CompactionScannerFactory#process() while entryLogger.addEntry(ledgerId, entry); doesn't handling the diskfull cases(its a suggestion, feel free to ignore) Considering normal addEntry flows, would act upon and do the transitions.
                
> Compaction increases latency on journal writes
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-664
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-664
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.2.1
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.2, 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ_branch4.2.patch, 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ-branch-4.2.patch, 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ.patch, 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ_trunk.patch
>
>
> Compaction writes to the journal to avoid data loss (see BOOKKEEPER-530). BOOKKEEPER-530 correctly identified that this may affect latency on the journal but we have observed this since in production. It is possible to avoid the journal completely, as twitter do in their github branch. Basically, we need to write to the entrylogger first, flush the entry log and then add to the index.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira