You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/07/17 07:48:30 UTC

[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #231: Fix broken generated java unidoc mappings

mdedetrich commented on code in PR #231:
URL: https://github.com/apache/incubator-pekko-http/pull/231#discussion_r1264991903


##########
.github/workflows/publish.yml:
##########
@@ -45,11 +45,11 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up JDK 8
+      - name: Set up JDK 11
         uses: actions/setup-java@v3
         with:
           distribution: temurin
-          java-version: 8
+          java-version: 11

Review Comment:
   It should be safe due to https://github.com/apache/incubator-pekko-http/pull/187 but lets do this in a separate PR because I want to validate on my machine that the bytecode is exactly the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org