You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/10 13:42:52 UTC

[GitHub] [nifi] ravowlga123 commented on a change in pull request #3971: NIFI-6997: consumeAMQP closing connection when queue not found

ravowlga123 commented on a change in pull request #3971: NIFI-6997: consumeAMQP closing connection when queue not found 
URL: https://github.com/apache/nifi/pull/3971#discussion_r365238434
 
 

 ##########
 File path: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java
 ##########
 @@ -194,6 +194,13 @@ protected synchronized AMQPConsumer createAMQPWorker(final ProcessContext contex
 
             return amqpConsumer;
         } catch (final IOException ioe) {
+            try {
+                connection.close();
+                getLogger().warn("Closed connection at port " + connection.getPort());
+            } catch (final IOException ioe_close) {
 
 Review comment:
   Instead of "ioe_close" "ioeClose" would be better?? Also not sure if log message should be at warn or info level. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services