You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/03 07:09:24 UTC

[GitHub] [spark] cloud-fan commented on pull request #31691: [SPARK-34575][SQL] Push down limit through window when partitionSpec is empty

cloud-fan commented on pull request #31691:
URL: https://github.com/apache/spark/pull/31691#issuecomment-789492093


   I'm trying to understand the before/after data flow.
   
   Before: input -> shuffle to one partition -> local sort and run rank function -> limit
   After: input -> global top k (shuffle to one partition) -> run rank function -> limit
   
   The optimization makes sense, but seems like we can remove the final limit?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org