You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2023/05/05 01:58:13 UTC
[GitHub] [druid] abhishekrb19 opened a new pull request, #14210: Remove the redundant ISO-8601 text in the readme.
abhishekrb19 opened a new pull request, #14210:
URL: https://github.com/apache/druid/pull/14210
Fixes the redundant "ISO-8601" text in the README.
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim merged pull request #14210: Remove the redundant ISO-8601 text in the readme.
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim merged PR #14210:
URL: https://github.com/apache/druid/pull/14210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #14210: Remove the redundant ISO-8601 text in the readme.
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #14210:
URL: https://github.com/apache/druid/pull/14210#discussion_r1186313935
##########
docs/operations/rule-configuration.md:
##########
@@ -178,7 +178,7 @@ Interval load rules have type `loadByInterval`. The following example places one
Set the following properties:
-- `interval`: the load interval specified as an ISO-8601 [ISO-8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
+- `interval`: the load interval specified as an [ISO-8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
Review Comment:
```suggestion
- `interval`: the load interval specified as an [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
```
##########
docs/operations/rule-configuration.md:
##########
@@ -313,7 +313,7 @@ Interval broadcast rules have type `broadcastByInterval` and the following JSON
Set the following property:
-- `interval`: the broadcast interval specified as an ISO-8601 [ISO-8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
+- `interval`: the broadcast interval specified as an [ISO-8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
Review Comment:
```suggestion
- `interval`: the broadcast interval specified as an [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
```
##########
docs/operations/rule-configuration.md:
##########
@@ -257,7 +257,7 @@ Interval drop rules have type `dropByInterval` and the following JSON structure:
Set the following property:
-- `interval`: the drop interval specified as an ISO-8601 [ISO-8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
+- `interval`: the drop interval specified as an [ISO-8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
Review Comment:
```suggestion
- `interval`: the drop interval specified as an [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) range encoded as a string.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org