[GitHub] [hadoop] goiri commented on a diff in pull request #5615: HDFS-16998. RBF: Add ops metrics for getSlowDatanodeReport in RouterClientActivity

["goiri (via GitHub)" <gi...@apache.org>]

goiri commented on code in PR #5615:
URL: https://github.com/apache/hadoop/pull/5615#discussion_r1184425533


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientMetrics.java:
##########
@@ -525,6 +527,9 @@ public void incInvokedMethod(Method method) {
     case "getHAServiceState":
       getHAServiceStateOps.incr();
       break;
+    case "getSlowDatanodeReport":

Review Comment:
   Can we add tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org