[jira] [Updated] (MESOS-4125) Use 'git rev-parse --git-dir' instead of assuming '.git' in top dir

["Kevin Klues (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Klues updated MESOS-4125:
-------------------------------
    Description: 
This issue relates files where we asume that to the 'bootstrap' file in the top level directory of the mesos tree.

When building from git, bootstrap will (among other things) install pre-commit and post-rewirte hooks into the .git/hooks directory of the mesos tree.  Moreover, support/pHowever the current implementation always assumes that .git exists in the same directory as the bootstrap file.  This may not always be true.

Most notably, it is not true if the mesos tree is included as a submodule inside another project. When included as a submodule, .git is no longer a directory, but rather a file whose text contains a pointer back to the actual location of the .git folder inside the containing project.  To get at this directory, we need to run 'git rev-parse --git-dir' instead of simply assuming that the local .git is the proper directory.

  was:
This issue relates to the 'bootstrap' file in the top level directory of the mesos tree.

When building from git, bootstrap will (among other things) install pre-commit and post-rewirte hooks into the .git/hooks directory of the mesos tree.  However the current implementation always assumes that .git exists in the same directory as the bootstrap file.  This may not always be true.

Most notably, it is not true if the mesos tree is included as a submodule inside another project. When included as a submodule, .git is no longer a directory, but rather a file whose text contains a pointer back to the actual location of the .git folder inside the containing project.  To get at this directory, we need to run 'git rev-parse --git-dir' instead of simply assuming that the local .git is the proper directory.


> Use 'git rev-parse --git-dir' instead of assuming '.git' in top dir
> -------------------------------------------------------------------
>
>                 Key: MESOS-4125
>                 URL: https://issues.apache.org/jira/browse/MESOS-4125
>             Project: Mesos
>          Issue Type: Improvement
>          Components: build
>         Environment: All systems
>            Reporter: Kevin Klues
>            Assignee: Kevin Klues
>            Priority: Minor
>              Labels: bootstrap, build, mesosphere
>
> This issue relates files where we asume that to the 'bootstrap' file in the top level directory of the mesos tree.
> When building from git, bootstrap will (among other things) install pre-commit and post-rewirte hooks into the .git/hooks directory of the mesos tree.  Moreover, support/pHowever the current implementation always assumes that .git exists in the same directory as the bootstrap file.  This may not always be true.
> Most notably, it is not true if the mesos tree is included as a submodule inside another project. When included as a submodule, .git is no longer a directory, but rather a file whose text contains a pointer back to the actual location of the .git folder inside the containing project.  To get at this directory, we need to run 'git rev-parse --git-dir' instead of simply assuming that the local .git is the proper directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)