You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/11 05:53:28 UTC
[GitHub] [apisix] idbeta opened a new issue #2215: Used TscanCode scan the lua code,it report two defects
idbeta opened a new issue #2215:
URL: https://github.com/apache/apisix/issues/2215
### Issue description
.../t/lib/test_admin.lua: Code line 223,undeclared Variable [core] is used.
../apisix/http/router/radixtree_sni.lua: Code line 187,[radixtree_router] is used after check at line 172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #2215: Used TscanCode scan the lua code,it report two code defects
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2215:
URL: https://github.com/apache/apisix/issues/2215#issuecomment-691781542
Which version of apisix the TscanCode works on? The lines don't match the master branch of apisix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] idbeta commented on issue #2215: Used TscanCode scan the lua code,it report two code defects
Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #2215:
URL: https://github.com/apache/apisix/issues/2215#issuecomment-691954151
@spacewander it's apisix 1.5 master branch
[.../apisix/http/router/radixtree_sni.lua:162]: (Critical) [radixtree_router] is used after check at line 147
[.../t/lib/test_admin.lua:223]: (Critical) Undeclared variable [core] is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis closed issue #2215: Used TscanCode scan the lua code,it report two code defects
Posted by GitBox <gi...@apache.org>.
membphis closed issue #2215:
URL: https://github.com/apache/apisix/issues/2215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #2215: Used TscanCode scan the lua code,it report two code defects
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2215:
URL: https://github.com/apache/apisix/issues/2215#issuecomment-693797594
> [radixtree_router] is used after check at line 147
Look like it is a false positive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2215: Used TscanCode scan the lua code,it report two code defects
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2215:
URL: https://github.com/apache/apisix/issues/2215#issuecomment-691855653
> .../t/lib/test_admin.lua: Code line 223,undeclared Variable [core] is used.
https://github.com/apache/apisix/blob/master/t/lib/test_admin.lua#L222-L225
it should be defects, we need to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org