You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Nitay Joffe <ni...@apache.org> on 2013/06/07 14:40:33 UTC

Review Request: GIRAPH-683: Jython for Computation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

Review request for giraph.


Description
-------

Jython for Computation


Diffs
-----

  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputation.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: Jython for Giraph

Posted by Nitay Joffe <ni...@apache.org>.

> On June 11, 2013, 5:13 p.m., Alessandro Presta wrote:
> > Pretty cool! It will be really useful once there is better support for types:
> > 1) some kind of type inference/casting/automatic serialization, so that one can write setValue(4) instead of setValue(IntWritable(4))
> > 2) possibility to implement all algorithm-related classes (vertex/edge/message values, aggregators, combiners, etc) directly in Python
> > If we could use some Python facility for serializing objects, this would become a really high-level API for writing graph algorithms in Python, without dealing with Java boilerplate, serialization, etc.

Yep those are good ideas. I'll look into these things in other patches.


> On June 11, 2013, 5:13 p.m., Alessandro Presta wrote:
> > giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java, line 63
> > <https://reviews.apache.org/r/11709/diff/2/?file=302654#file302654line63>
> >
> >     Isn't this a bit redundant? !isPresent seems convenient enough. Also, isSet could be a more standard name,

yep already removed as per Avery's comment.


- Nitay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21705
-----------------------------------------------------------


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Giraph

Posted by Alessandro Presta <al...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21705
-----------------------------------------------------------


Pretty cool! It will be really useful once there is better support for types:
1) some kind of type inference/casting/automatic serialization, so that one can write setValue(4) instead of setValue(IntWritable(4))
2) possibility to implement all algorithm-related classes (vertex/edge/message values, aggregators, combiners, etc) directly in Python
If we could use some Python facility for serializing objects, this would become a really high-level API for writing graph algorithms in Python, without dealing with Java boilerplate, serialization, etc.


giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java
<https://reviews.apache.org/r/11709/#comment44869>

    Isn't this a bit redundant? !isPresent seems convenient enough. Also, isSet could be a more standard name,



giraph-core/src/main/java/org/apache/giraph/jython/Jython.java
<https://reviews.apache.org/r/11709/#comment44870>

    This Javadoc is a bit misleading, because the class doesn't implement Computation. Also, the name Jython doesn't convey much. Maybe something like JythonUtils or JythonRunner...


- Alessandro Presta


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Giraph

Posted by Claudio Martella <cl...@gmail.com>.
probably this would make sense the hadoop-streaming way through the
distributed cache via command-line?


On Tue, Jun 11, 2013 at 7:52 AM, Nitay Joffe <ni...@apache.org> wrote:

>
>
> > On June 11, 2013, 5:51 a.m., Nitay Joffe wrote:
> > > Regarding your comment - yeah I'll add it to GiraphRunner. Right now
> you have to specify at the very least the types IVEMM, the python script
> path (as resource in jar) and the computation class name. Any thoughts how
> to make this simpler?
>
> Also I can make it support python files not shipped inside jar (assuming
> the user knows to make the same path available on all their nodes). I find
> it is easier management/deployment wise to ship the python scripts as
> resources and load them that way.
>
>
> - Nitay
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/#review21693
> -----------------------------------------------------------
>
>
> On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11709/
> > -----------------------------------------------------------
> >
> > (Updated June 10, 2013, 6:55 a.m.)
> >
> >
> > Review request for giraph.
> >
> >
> > Description
> > -------
> >
> > See JIRA
> >
> >
> > This addresses bug GIRAPH-683.
> >     https://issues.apache.org/jira/browse/GIRAPH-683
> >
> >
> > Diffs
> > -----
> >
> >   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6
> >
> giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java
> 23c614b1112dd455a97b6ee7d32188dc5a5fd574
> >
> giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
> bd2939ec4ce9d3fa373fda667e75df7e0da1cc82
> >
> giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java
> d00f7e908605d8753eb129d0173cf1980034dcc9
> >
> giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java
> c16ec8849641847d53aea8c90dcc0a3fcd646e45
> >   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java
> 41d120b18bdbbf13c8426ec49f8619d273684620
> >   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java
> 8f70d904660f14370c2e5c98cc59b6a48ea18135
> >   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java
> PRE-CREATION
> >   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java
> fa21a281525858208b1ee81be1eafa5ddcb22a0f
> >   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java
> 621bb14e4962ec9326c3d58b9de33ad83eb23621
> >
> giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
> 58a3f0179d17cd04f2e69789a6e3838cb22d75eb
> >   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
> 2d0f59cecfdf580609c9d6373c0878c90cede430
> >   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java
> PRE-CREATION
> >
> giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
> aa5249875de551a341a4baac894c68553cbd6e63
> >   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java
> de75e9dc4d1696b11251a8e8cac870f6bbf72230
> >   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java
> 0cbc164756de8a422a8f23f01809200b4d569cbf
> >   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java
> 83a583d98820ef946258d2e2a14fc279583b5c5c
> >   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java
> 84158df3ded55360af179e08194e14bc43949c77
> >
> giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java
> PRE-CREATION
> >
> giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java
> PRE-CREATION
> >
> giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java
> PRE-CREATION
> >
> giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java
> 99b28df74232504f2b2a16639473e367f53dd15f
> >
> giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java
> de17157dcbeb123fc43184742a59ed1116070dd6
> >   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java
> PRE-CREATION
> >
> giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
> PRE-CREATION
> >   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java
> PRE-CREATION
> >
> giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java
> a12ef58eec93aa4e801955efcd42f0e5c899275e
> >
> giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java
> d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415
> >   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java
> 442fc9f068c4478706e96a726c5caa2f8fda4563
> >
> giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
> b4920e1a015eda3ea5d5c381d5b0155f38f1891a
> >   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java
> 96352bbfc0901e44ffe25bbe2f280a216c797131
> >
> giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py
> PRE-CREATION
> >   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java
> PRE-CREATION
> >
> giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java
> PRE-CREATION
> >   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py
> PRE-CREATION
> >   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java
> 340b4618ce8fdd4ec2303866b2ded632535e40a4
> >   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b
> >
> > Diff: https://reviews.apache.org/r/11709/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Nitay Joffe
> >
> >
>
>


-- 
   Claudio Martella
   claudio.martella@gmail.com

Re: Review Request: Jython for Giraph

Posted by Nitay Joffe <ni...@apache.org>.

> On June 11, 2013, 5:51 a.m., Nitay Joffe wrote:
> > Regarding your comment - yeah I'll add it to GiraphRunner. Right now you have to specify at the very least the types IVEMM, the python script path (as resource in jar) and the computation class name. Any thoughts how to make this simpler?

Also I can make it support python files not shipped inside jar (assuming the user knows to make the same path available on all their nodes). I find it is easier management/deployment wise to ship the python scripts as resources and load them that way.


- Nitay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21693
-----------------------------------------------------------


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Giraph

Posted by Avery Ching <av...@gmail.com>.

> On June 11, 2013, 5:51 a.m., Nitay Joffe wrote:
> > Regarding your comment - yeah I'll add it to GiraphRunner. Right now you have to specify at the very least the types IVEMM, the python script path (as resource in jar) and the computation class name. Any thoughts how to make this simpler?
> 
> Nitay Joffe wrote:
>     Also I can make it support python files not shipped inside jar (assuming the user knows to make the same path available on all their nodes). I find it is easier management/deployment wise to ship the python scripts as resources and load them that way.

I agree with this.  Putting the python file into the jar is very cumbersome.


- Avery


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21693
-----------------------------------------------------------


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Giraph

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21693
-----------------------------------------------------------


Regarding your comment - yeah I'll add it to GiraphRunner. Right now you have to specify at the very least the types IVEMM, the python script path (as resource in jar) and the computation class name. Any thoughts how to make this simpler?

- Nitay Joffe


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: avery's comments

Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review22178
-----------------------------------------------------------

Ship it!


+1, great start to making scripting a reality for Giraph!


giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java
<https://reviews.apache.org/r/11709/#comment45569>

    Computation



giraph-core/src/main/java/org/apache/giraph/graph/Language.java
<https://reviews.apache.org/r/11709/#comment45570>

    jython?


- Avery Ching


On June 20, 2013, 3:56 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 3:56 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 50d411a9fc6a5ba98726ad1236f532cfe6cd1a29 
>   README c2a32eda14e0e1bc3110cb98a5ad8f4445fc23cc 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java dbd24523d256f7cddb3667980f8a0949d4491a5c 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/conf/TypesHolder.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/graph/Language.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullTextInputFormat.java 91725f83e2c1f18fb8a250ea49261d32ea518188 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/LongLongNullTextInputFormat.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/DeployType.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/DistributedCacheUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/BspCase.java 137cb6ea59ffd2d7b489cf4255b6b172c840bef0 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java 13e8edfed9f36bd20659bdcec40d4378947292df 
>   giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 6c8a0b39383dfd10c37ef63b0b56c1ecf7cc19bc 
>   giraph-examples/src/test/java/org/apache/giraph/TestComputationState.java 1092eac7e2c35e9cc76c6a32c48d74515bf01953 
>   giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java 4537eacc186d6f2b1d94ee543614a1533fbdd1b2 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: avery's comments

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 20, 2013, 3:56 a.m.)


Review request for giraph.


Changes
-------

Avery's comments.


Summary (updated)
-----------------

avery's comments


Description
-------

See JIRA


This addresses bug GIRAPH-683.
    https://issues.apache.org/jira/browse/GIRAPH-683


Diffs (updated)
-----

  CHANGELOG 50d411a9fc6a5ba98726ad1236f532cfe6cd1a29 
  README c2a32eda14e0e1bc3110cb98a5ad8f4445fc23cc 
  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java dbd24523d256f7cddb3667980f8a0949d4491a5c 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/conf/TypesHolder.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/graph/Language.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullTextInputFormat.java 91725f83e2c1f18fb8a250ea49261d32ea518188 
  giraph-core/src/main/java/org/apache/giraph/io/formats/LongLongNullTextInputFormat.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/DeployType.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/DistributedCacheUtils.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/BspCase.java 137cb6ea59ffd2d7b489cf4255b6b172c840bef0 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java 13e8edfed9f36bd20659bdcec40d4378947292df 
  giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 6c8a0b39383dfd10c37ef63b0b56c1ecf7cc19bc 
  giraph-examples/src/test/java/org/apache/giraph/TestComputationState.java 1092eac7e2c35e9cc76c6a32c48d74515bf01953 
  giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java 4537eacc186d6f2b1d94ee543614a1533fbdd1b2 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: Jython for Computation

Posted by Nitay Joffe <ni...@apache.org>.

> On June 19, 2013, 12:09 a.m., Avery Ching wrote:
> > These are mostly minor comments (mostly grammar and formatting).  
> > 
> > Can you please add a two sentence use guide to the website or to the README?
> > 
> > Once you submit a revision with the fixes, I'll do a quick pass and let's get this in!

Added brief info to README. At this point it is not trivial to use, but that is a known "feature" because it's only the first step in what will be a slew of scripting related diffs.


> On June 19, 2013, 12:09 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/graph/Computation.java, line 62
> > <https://reviews.apache.org/r/11709/diff/5/?file=304769#file304769line62>
> >
> >     giraph.computation.language should be a constant.

Moved to GiraphConstants


> On June 19, 2013, 12:09 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java, lines 180-181
> > <https://reviews.apache.org/r/11709/diff/5/?file=304772#file304772line180>
> >
> >     I am a little confused why we need to do this.

We always did it, I didn't add something new I just renamed it. I'm assuming we do it so that later we can just do stuff like conf.getVertexIdClass() and not have to infer again. I've updated the comment.


> On June 19, 2013, 12:09 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java, line 61
> > <https://reviews.apache.org/r/11709/diff/5/?file=304751#file304751line61>
> >
> >     Can we indicate if this is a local path or HDFS path?

I added a helper to copyToHdfsIfNecessary() to DistributedCacheUtils. Now it supports local python files (will get uploaded to HDFS) , hdfs python files, and resources. Leave it up to user to do whatever they want.


- Nitay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review22023
-----------------------------------------------------------


On June 13, 2013, 5:29 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 5:29 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 50d411a9fc6a5ba98726ad1236f532cfe6cd1a29 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java dbd24523d256f7cddb3667980f8a0949d4491a5c 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/conf/TypesHolder.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/graph/Language.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullTextInputFormat.java 91725f83e2c1f18fb8a250ea49261d32ea518188 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/LongLongNullTextInputFormat.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/DeployType.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/DistributedCacheUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/BspCase.java 137cb6ea59ffd2d7b489cf4255b6b172c840bef0 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java 13e8edfed9f36bd20659bdcec40d4378947292df 
>   giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 6c8a0b39383dfd10c37ef63b0b56c1ecf7cc19bc 
>   giraph-examples/src/test/java/org/apache/giraph/TestComputationState.java 1092eac7e2c35e9cc76c6a32c48d74515bf01953 
>   giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java 4537eacc186d6f2b1d94ee543614a1533fbdd1b2 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Computation

Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review22023
-----------------------------------------------------------


These are mostly minor comments (mostly grammar and formatting).  

Can you please add a two sentence use guide to the website or to the README?

Once you submit a revision with the fixes, I'll do a quick pass and let's get this in!


giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java
<https://reviews.apache.org/r/11709/#comment45457>

    Can we indicate if this is a local path or HDFS path?



giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
<https://reviews.apache.org/r/11709/#comment45458>

    to decide...what to return?



giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
<https://reviews.apache.org/r/11709/#comment45459>

    Name



giraph-core/src/main/java/org/apache/giraph/graph/Computation.java
<https://reviews.apache.org/r/11709/#comment45338>

    giraph.computation.language should be a constant.



giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45460>

    @Override should be on a separate line.



giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java
<https://reviews.apache.org/r/11709/#comment45461>

    I am a little confused why we need to do this.



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45462>

    initComputation: Jython...



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45463>

    getPythonScriptStream: Reading...
    Missing if wrapper.



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45465>

    Can you please add the method name to the exception message?



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45464>

    getPythonScriptStream: Reading...
    Missing if wrapper.



giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java
<https://reviews.apache.org/r/11709/#comment45467>

    This isn't thread-safe, but it's a global variable.  Let's at least make it volatile (if semantically it makes sense) if not thread-safe.



giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java
<https://reviews.apache.org/r/11709/#comment45469>

    Can we check for the Jython case specificaly?  conf should know?



giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java
<https://reviews.apache.org/r/11709/#comment45472>

    You probably didn't have to change this to array from list (You could have changed the return to an ArrayList), but it's okay.



giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java
<https://reviews.apache.org/r/11709/#comment45475>

    method prefix.



giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java
<https://reviews.apache.org/r/11709/#comment45476>

    missing line.


- Avery Ching


On June 13, 2013, 5:29 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 5:29 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 50d411a9fc6a5ba98726ad1236f532cfe6cd1a29 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java dbd24523d256f7cddb3667980f8a0949d4491a5c 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/conf/TypesHolder.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/graph/Language.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullTextInputFormat.java 91725f83e2c1f18fb8a250ea49261d32ea518188 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/LongLongNullTextInputFormat.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/DeployType.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/DistributedCacheUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/BspCase.java 137cb6ea59ffd2d7b489cf4255b6b172c840bef0 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java 13e8edfed9f36bd20659bdcec40d4378947292df 
>   giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 6c8a0b39383dfd10c37ef63b0b56c1ecf7cc19bc 
>   giraph-examples/src/test/java/org/apache/giraph/TestComputationState.java 1092eac7e2c35e9cc76c6a32c48d74515bf01953 
>   giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java 4537eacc186d6f2b1d94ee543614a1533fbdd1b2 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Computation

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 13, 2013, 5:29 p.m.)


Review request for giraph.


Changes
-------

Add Jython script options to GiraphRunner.


Description
-------

See JIRA


This addresses bug GIRAPH-683.
    https://issues.apache.org/jira/browse/GIRAPH-683


Diffs (updated)
-----

  CHANGELOG 50d411a9fc6a5ba98726ad1236f532cfe6cd1a29 
  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java dbd24523d256f7cddb3667980f8a0949d4491a5c 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/conf/TypesHolder.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/graph/Language.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullTextInputFormat.java 91725f83e2c1f18fb8a250ea49261d32ea518188 
  giraph-core/src/main/java/org/apache/giraph/io/formats/LongLongNullTextInputFormat.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/DeployType.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/DistributedCacheUtils.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/BspCase.java 137cb6ea59ffd2d7b489cf4255b6b172c840bef0 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java 13e8edfed9f36bd20659bdcec40d4378947292df 
  giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 6c8a0b39383dfd10c37ef63b0b56c1ecf7cc19bc 
  giraph-examples/src/test/java/org/apache/giraph/TestComputationState.java 1092eac7e2c35e9cc76c6a32c48d74515bf01953 
  giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java 4537eacc186d6f2b1d94ee543614a1533fbdd1b2 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: Jython for Computation

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 11, 2013, 7:31 p.m.)


Review request for giraph.


Summary (updated)
-----------------

Jython for Computation


Description
-------

See JIRA


This addresses bug GIRAPH-683.
    https://issues.apache.org/jira/browse/GIRAPH-683


Diffs
-----

  CHANGELOG fe0c8fdc6d73520318cd531755a6af25b0ba7b84 
  giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeInputFormat.java 108ae61d5e57ba293a414028e1cb8b8c685b150c 
  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/comm/SendMutationsCache.java 9348e61cd83985d920d3ed825d0fbdb3f3ab9fff 
  giraph-core/src/main/java/org/apache/giraph/comm/SendPartitionCache.java 68ce0955d8088ed87a6599fd5cd144cd7e470e6c 
  giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java 731d0eee0123ea9b5cecc47cff18d6be174f3e47 
  giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java 06965ca488aceb593a249a7c88bd49d660080c20 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 420bf9353871540594309ee9b4c129ae91ea7680 
  giraph-core/src/main/java/org/apache/giraph/edge/LongNullHashSetEdges.java 139fc7afb75aac92488e4aec7da3ff8bfbcd540c 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertex.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java 1241ae757b29cb7bec80fd3bb3d2bab1ac9c21bd 
  giraph-core/src/main/java/org/apache/giraph/graph/VertexMutations.java 6f54dc701a5f5dc4589140dfb4a6d0dc5f128dca 
  giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java 9695169b5ccf8325987e42de90e7cd3011c0b901 
  giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java 70e721ec8e4a120a094206e5b857b9bb75eb7acd 
  giraph-core/src/main/java/org/apache/giraph/io/formats/GraphvizOutputFormat.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java 112860c12d203b734093973c3b5d9dd6db39b14a 
  giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java 91a19e6484631e4334b6c3843ba7aedfec169276 
  giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java 1d31f4fb7a688ce314be5608f88726daa9152833 
  giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFormat.java debdcccaf96cf105b5c0b3a73515f82860913178 
  giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrapper.java ca35c517666910e613431a3641f48f8df223f8b4 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java dadce0f14fe4ecac1dd35c35adf593a63e9583d9 
  giraph-core/src/main/java/org/apache/giraph/partition/Partition.java aebd34344b10cb3752c74c27f62bf3cfa5d3d565 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java 6ca488cb42efec02b49f1ec9b4d22ec0b40bca42 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java 6e46a76b656543c97a6b0c5eaad848633bd48bb6 
  giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 8b5e39a021adc733ff6fc1ef62d6aea6abd61256 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/graph/TestVertexAndEdges.java d0a6c46114b5d2b42a5fcdba93e293d404e4257f 
  giraph-core/src/test/java/org/apache/giraph/io/TestAdjacencyListTextVertexOutputFormat.java fdfb5e91dc692283a67f7fcaf309e8387f75a36d 
  giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java c67a1c44eed7b35a3c872d2032bc4e5ae77e7ef7 
  giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java 80340528326d9b37a380d9a761115b28b879ce2d 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/partition/TestGiraphTransferRegulator.java 8a1e9edaea53476d50dd90d70afc80c76d7f090a 
  giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java 45542b9083f8821ee664487791a7b6a50c115c8e 
  giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java d210928374b21e42bac960c2d191386df42c119e 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleTextInputFormat.java f56b4f6a4c3f26e521829b5da4718ed8bc4e7b64 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullTextInputFormat.java bfb5f40bd2e7b8da321b5b818e377fea16fccecd 
  giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleTextInputFormat.java 5023a4e2ca80cf6fe0afe83598c11b00308fc630 
  giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankComputation.java d053bb3ceb0c77a3a6dbe46ffa330e9d5f8d035c 
  giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepComputation.java c3fd215b29a445b540a39b99f39cd7eaee195c91 
  giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 28edbba58a0513a2fe0b051e02e723dfd283de20 
  giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsComputationTestInMemory.java b94f8dcbd961d24f341cff252512c3a102b37ddb 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsComputationTest.java 93a3248f7fd5a94a84c8daf7c277ca954c859071 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingComputationTest.java 73516a473ffd500500aeba083889ca3e5b7c3f03 
  giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java 1af46d1d6f9e2add4eb25ecdf1e5b351b5bf9132 
  giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeOutputFormat.java a04d3864334158781b051e29fa8d02e3eba2b630 
  giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java 53c7eed811e326980f8adf4a34ba41a4152b5416 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: review updates

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 11, 2013, 5:29 p.m.)


Review request for giraph.


Changes
-------

Avery and Alessandro's comments


Description
-------

See JIRA


This addresses bug GIRAPH-683.
    https://issues.apache.org/jira/browse/GIRAPH-683


Diffs (updated)
-----

  CHANGELOG fe0c8fdc6d73520318cd531755a6af25b0ba7b84 
  giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeInputFormat.java 108ae61d5e57ba293a414028e1cb8b8c685b150c 
  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/comm/SendMutationsCache.java 9348e61cd83985d920d3ed825d0fbdb3f3ab9fff 
  giraph-core/src/main/java/org/apache/giraph/comm/SendPartitionCache.java 68ce0955d8088ed87a6599fd5cd144cd7e470e6c 
  giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java 731d0eee0123ea9b5cecc47cff18d6be174f3e47 
  giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java 06965ca488aceb593a249a7c88bd49d660080c20 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 420bf9353871540594309ee9b4c129ae91ea7680 
  giraph-core/src/main/java/org/apache/giraph/edge/LongNullHashSetEdges.java 139fc7afb75aac92488e4aec7da3ff8bfbcd540c 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertex.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java 1241ae757b29cb7bec80fd3bb3d2bab1ac9c21bd 
  giraph-core/src/main/java/org/apache/giraph/graph/VertexMutations.java 6f54dc701a5f5dc4589140dfb4a6d0dc5f128dca 
  giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java 9695169b5ccf8325987e42de90e7cd3011c0b901 
  giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java 70e721ec8e4a120a094206e5b857b9bb75eb7acd 
  giraph-core/src/main/java/org/apache/giraph/io/formats/GraphvizOutputFormat.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java 112860c12d203b734093973c3b5d9dd6db39b14a 
  giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java 91a19e6484631e4334b6c3843ba7aedfec169276 
  giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java 1d31f4fb7a688ce314be5608f88726daa9152833 
  giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFormat.java debdcccaf96cf105b5c0b3a73515f82860913178 
  giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrapper.java ca35c517666910e613431a3641f48f8df223f8b4 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java dadce0f14fe4ecac1dd35c35adf593a63e9583d9 
  giraph-core/src/main/java/org/apache/giraph/partition/Partition.java aebd34344b10cb3752c74c27f62bf3cfa5d3d565 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java 6ca488cb42efec02b49f1ec9b4d22ec0b40bca42 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java 6e46a76b656543c97a6b0c5eaad848633bd48bb6 
  giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 8b5e39a021adc733ff6fc1ef62d6aea6abd61256 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/graph/TestVertexAndEdges.java d0a6c46114b5d2b42a5fcdba93e293d404e4257f 
  giraph-core/src/test/java/org/apache/giraph/io/TestAdjacencyListTextVertexOutputFormat.java fdfb5e91dc692283a67f7fcaf309e8387f75a36d 
  giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java c67a1c44eed7b35a3c872d2032bc4e5ae77e7ef7 
  giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java 80340528326d9b37a380d9a761115b28b879ce2d 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/partition/TestGiraphTransferRegulator.java 8a1e9edaea53476d50dd90d70afc80c76d7f090a 
  giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java 45542b9083f8821ee664487791a7b6a50c115c8e 
  giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java d210928374b21e42bac960c2d191386df42c119e 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleTextInputFormat.java f56b4f6a4c3f26e521829b5da4718ed8bc4e7b64 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullTextInputFormat.java bfb5f40bd2e7b8da321b5b818e377fea16fccecd 
  giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleTextInputFormat.java 5023a4e2ca80cf6fe0afe83598c11b00308fc630 
  giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankComputation.java d053bb3ceb0c77a3a6dbe46ffa330e9d5f8d035c 
  giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepComputation.java c3fd215b29a445b540a39b99f39cd7eaee195c91 
  giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 28edbba58a0513a2fe0b051e02e723dfd283de20 
  giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsComputationTestInMemory.java b94f8dcbd961d24f341cff252512c3a102b37ddb 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsComputationTest.java 93a3248f7fd5a94a84c8daf7c277ca954c859071 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingComputationTest.java 73516a473ffd500500aeba083889ca3e5b7c3f03 
  giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java 1af46d1d6f9e2add4eb25ecdf1e5b351b5bf9132 
  giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeOutputFormat.java a04d3864334158781b051e29fa8d02e3eba2b630 
  giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java 53c7eed811e326980f8adf4a34ba41a4152b5416 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: review updates

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 11, 2013, 5:28 p.m.)


Review request for giraph.


Summary (updated)
-----------------

review updates


Description
-------

See JIRA


This addresses bug GIRAPH-683.
    https://issues.apache.org/jira/browse/GIRAPH-683


Diffs (updated)
-----

  CHANGELOG fe0c8fdc6d73520318cd531755a6af25b0ba7b84 
  giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeInputFormat.java 108ae61d5e57ba293a414028e1cb8b8c685b150c 
  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/comm/SendMutationsCache.java 9348e61cd83985d920d3ed825d0fbdb3f3ab9fff 
  giraph-core/src/main/java/org/apache/giraph/comm/SendPartitionCache.java 68ce0955d8088ed87a6599fd5cd144cd7e470e6c 
  giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java 731d0eee0123ea9b5cecc47cff18d6be174f3e47 
  giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java 06965ca488aceb593a249a7c88bd49d660080c20 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 420bf9353871540594309ee9b4c129ae91ea7680 
  giraph-core/src/main/java/org/apache/giraph/edge/LongNullHashSetEdges.java 139fc7afb75aac92488e4aec7da3ff8bfbcd540c 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertex.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java 1241ae757b29cb7bec80fd3bb3d2bab1ac9c21bd 
  giraph-core/src/main/java/org/apache/giraph/graph/VertexMutations.java 6f54dc701a5f5dc4589140dfb4a6d0dc5f128dca 
  giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java 9695169b5ccf8325987e42de90e7cd3011c0b901 
  giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java 70e721ec8e4a120a094206e5b857b9bb75eb7acd 
  giraph-core/src/main/java/org/apache/giraph/io/formats/GraphvizOutputFormat.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java 112860c12d203b734093973c3b5d9dd6db39b14a 
  giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java 91a19e6484631e4334b6c3843ba7aedfec169276 
  giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java 1d31f4fb7a688ce314be5608f88726daa9152833 
  giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFormat.java debdcccaf96cf105b5c0b3a73515f82860913178 
  giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrapper.java ca35c517666910e613431a3641f48f8df223f8b4 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java dadce0f14fe4ecac1dd35c35adf593a63e9583d9 
  giraph-core/src/main/java/org/apache/giraph/partition/Partition.java aebd34344b10cb3752c74c27f62bf3cfa5d3d565 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java 6ca488cb42efec02b49f1ec9b4d22ec0b40bca42 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java 6e46a76b656543c97a6b0c5eaad848633bd48bb6 
  giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 8b5e39a021adc733ff6fc1ef62d6aea6abd61256 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/graph/TestVertexAndEdges.java d0a6c46114b5d2b42a5fcdba93e293d404e4257f 
  giraph-core/src/test/java/org/apache/giraph/io/TestAdjacencyListTextVertexOutputFormat.java fdfb5e91dc692283a67f7fcaf309e8387f75a36d 
  giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java c67a1c44eed7b35a3c872d2032bc4e5ae77e7ef7 
  giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java 80340528326d9b37a380d9a761115b28b879ce2d 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/partition/TestGiraphTransferRegulator.java 8a1e9edaea53476d50dd90d70afc80c76d7f090a 
  giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java 45542b9083f8821ee664487791a7b6a50c115c8e 
  giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java d210928374b21e42bac960c2d191386df42c119e 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleTextInputFormat.java f56b4f6a4c3f26e521829b5da4718ed8bc4e7b64 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullTextInputFormat.java bfb5f40bd2e7b8da321b5b818e377fea16fccecd 
  giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleTextInputFormat.java 5023a4e2ca80cf6fe0afe83598c11b00308fc630 
  giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankComputation.java d053bb3ceb0c77a3a6dbe46ffa330e9d5f8d035c 
  giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepComputation.java c3fd215b29a445b540a39b99f39cd7eaee195c91 
  giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 28edbba58a0513a2fe0b051e02e723dfd283de20 
  giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsComputationTestInMemory.java b94f8dcbd961d24f341cff252512c3a102b37ddb 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsComputationTest.java 93a3248f7fd5a94a84c8daf7c277ca954c859071 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingComputationTest.java 73516a473ffd500500aeba083889ca3e5b7c3f03 
  giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java 1af46d1d6f9e2add4eb25ecdf1e5b351b5bf9132 
  giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeOutputFormat.java a04d3864334158781b051e29fa8d02e3eba2b630 
  giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java 53c7eed811e326980f8adf4a34ba41a4152b5416 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: Jython for Giraph

Posted by Nitay Joffe <ni...@apache.org>.

> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java, line 57
> > <https://reviews.apache.org/r/11709/diff/2/?file=302675#file302675line57>
> >
> >     Wrapped LOG.info please.
> 
> Nitay Joffe wrote:
>     Fixed. Btw how come we don't use slf4j? It would clean all this up _and_ be more performant: http://www.slf4j.org/faq.html#logging_performance
> 
> Avery Ching wrote:
>     I don't think there is any compelling reason to use or not use.  Is there a good comparison of slf4j vs log4j?

Well there's a distinction here. slf4j is not a logging facility in itself. It is a simple and efficient API for logging on top of which at runtime you plug in logging providers (such as log4j). The advantage is, as a library maintainer, you don't decide for the user which logging tool to use, they get to decide. See e.g. http://stackoverflow.com/questions/4516932/difference-between-slf4j-and-log4j. I could not find specific performance comparisons but everyone mentions it is faster, and intuitively it makes sense that using "... {} ..." string interpolation that happens _after_ deciding whether to print at all would be faster than using string concatenation "... " + foo, which will always evaluate.


- Nitay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21668
-----------------------------------------------------------


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Giraph

Posted by Nitay Joffe <ni...@apache.org>.

> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java, lines 49-66
> > <https://reviews.apache.org/r/11709/diff/2/?file=302654#file302654line49>
> >
> >     my personal preference here is for adding boolean exists(Configuration conf), rather than these two methods.  Matchs the Map interface

Where is exists, do you mean contains? Anyways I've changed it to exists let me know if you want something else.


> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java, line 49
> > <https://reviews.apache.org/r/11709/diff/2/?file=302655#file302655line49>
> >
> >     Should this be abstract in abstract conf option?

good call


> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java, lines 61-62
> > <https://reviews.apache.org/r/11709/diff/2/?file=302658#file302658line61>
> >
> >     Style-wise, we typically have a line between the comments and the parameters.  I don't know how to enforce this in checkstyle, but can we preserve it?  Btw, you do this everywhere...

I'll look through and fix where I see it.


> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java, lines 526-533
> > <https://reviews.apache.org/r/11709/diff/2/?file=302660#file302660line526>
> >
> >     Is this acceptable, should we expect a null argument?

It's for all the updateSuperstep() stuff. I haven't looked through that code deeply but from my understanding it sets the Computation class every superstep so that it can be configurable. However in the case of Jython the Computation class is null, so it keeps passing null. I will look at how to stop it upstream.

@maja you have any thoughts here I believe you added the superstep update stuff?


> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java, lines 183-185
> > <https://reviews.apache.org/r/11709/diff/2/?file=302672#file302672line183>
> >
> >     Why do we expect this to be set sometimes and not others?

I think you're right that shouldn't happen, but I'll double check. It's a bit tricky... The current logic inside GiraphClasses for setting the types is: https://gist.github.com/nitay/2413e54d639e2df80455. That is either the Computation class is set or you better set the types yourself. There should really be an else in there that throws but I recall when I tried that there was one or two cases where we create ICGC before the user/runner code has any chance to run and in that case they are not set.


> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java, line 57
> > <https://reviews.apache.org/r/11709/diff/2/?file=302675#file302675line57>
> >
> >     Wrapped LOG.info please.

Fixed. Btw how come we don't use slf4j? It would clean all this up _and_ be more performant: http://www.slf4j.org/faq.html#logging_performance


- Nitay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21668
-----------------------------------------------------------


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Giraph

Posted by Avery Ching <av...@gmail.com>.

> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java, lines 49-66
> > <https://reviews.apache.org/r/11709/diff/2/?file=302654#file302654line49>
> >
> >     my personal preference here is for adding boolean exists(Configuration conf), rather than these two methods.  Matchs the Map interface
> 
> Nitay Joffe wrote:
>     Where is exists, do you mean contains? Anyways I've changed it to exists let me know if you want something else.

contains sounds better as per your suggestion.


> On June 11, 2013, 12:07 a.m., Avery Ching wrote:
> > giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java, line 57
> > <https://reviews.apache.org/r/11709/diff/2/?file=302675#file302675line57>
> >
> >     Wrapped LOG.info please.
> 
> Nitay Joffe wrote:
>     Fixed. Btw how come we don't use slf4j? It would clean all this up _and_ be more performant: http://www.slf4j.org/faq.html#logging_performance

I don't think there is any compelling reason to use or not use.  Is there a good comparison of slf4j vs log4j?


- Avery


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21668
-----------------------------------------------------------


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Giraph

Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review21668
-----------------------------------------------------------


This is really neat functionality.  Looking forward to seeing the bar lowered for new uesrs.  One thing that is not clear to me is how to use this easily?  Can I launch a job with an option to use a *.py file?


giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java
<https://reviews.apache.org/r/11709/#comment44784>

    my personal preference here is for adding boolean exists(Configuration conf), rather than these two methods.  Matchs the Map interface



giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java
<https://reviews.apache.org/r/11709/#comment44789>

    Should this be abstract in abstract conf option?



giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java
<https://reviews.apache.org/r/11709/#comment44786>

    Style-wise, we typically have a line between the comments and the parameters.  I don't know how to enforce this in checkstyle, but can we preserve it?  Btw, you do this everywhere...



giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java
<https://reviews.apache.org/r/11709/#comment44787>

    ComputationFactory



giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java
<https://reviews.apache.org/r/11709/#comment44800>

    Is this acceptable, should we expect a null argument?



giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
<https://reviews.apache.org/r/11709/#comment44788>

    Great.



giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
<https://reviews.apache.org/r/11709/#comment44801>

    You mean M1 and M2 right?



giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java
<https://reviews.apache.org/r/11709/#comment44802>

    Why do we expect this to be set sometimes and not others?



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment44798>

    Wrapped LOG.info please.



giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py
<https://reviews.apache.org/r/11709/#comment44799>

    Sweet!


- Avery Ching


On June 10, 2013, 6:55 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
>   giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>

Re: Review Request: Jython for Giraph

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 10, 2013, 6:55 a.m.)


Review request for giraph.


Description (updated)
-------

See JIRA


This addresses bug GIRAPH-683.
    https://issues.apache.org/jira/browse/GIRAPH-683


Diffs
-----

  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: Jython for Giraph

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 10, 2013, 6:54 a.m.)


Review request for giraph.


Description
-------

Jython for Computation


This addresses bug GIRAPH-683.
    https://issues.apache.org/jira/browse/GIRAPH-683


Diffs
-----

  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: Jython for Giraph

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 10, 2013, 6:53 a.m.)


Review request for giraph.


Summary (updated)
-----------------

Jython for Giraph


Description
-------

Jython for Computation


Diffs
-----

  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: bugfixes

Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 10, 2013, 6:41 a.m.)


Review request for giraph.


Changes
-------

Added page rank implementation.


Summary (updated)
-----------------

bugfixes


Description
-------

Jython for Computation


Diffs (updated)
-----

  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9 
  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620 
  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135 
  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230 
  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf 
  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f 
  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6 
  giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 
  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a 
  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131 
  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION 
  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4 
  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe