You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mark Hobson (JIRA)" <ji...@codehaus.org> on 2007/05/18 12:10:59 UTC

[jira] Created: (MRELEASE-233) ScmCheckModificationsPhase ignores pom.xml

ScmCheckModificationsPhase ignores pom.xml
------------------------------------------

                 Key: MRELEASE-233
                 URL: http://jira.codehaus.org/browse/MRELEASE-233
             Project: Maven 2.x Release Plugin
          Issue Type: Bug
    Affects Versions: 2.0-beta-6
         Environment: Windows XP, Cygwin
            Reporter: Mark Hobson
         Attachments: patch.txt

Any local changes to pom.xmls are committed when using release:prepare.  Such changes should be committed manually by the user before releasing to keep commits atomic.  Thus pom.xml needs to be removed from the ScmCheckModificationsPhase exclusion list to fail the build under these circumstances.

The attached patch removes pom.xml from the excluded files and realigns the tests accordingly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRELEASE-233) ScmCheckModificationsPhase ignores pom.xml

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse updated MRELEASE-233:
--------------------------------------

         Assignee: Emmanuel Venisse
    Fix Version/s: 2.0-beta-6

> ScmCheckModificationsPhase ignores pom.xml
> ------------------------------------------
>
>                 Key: MRELEASE-233
>                 URL: http://jira.codehaus.org/browse/MRELEASE-233
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>         Environment: Windows XP, Cygwin
>            Reporter: Mark Hobson
>            Assignee: Emmanuel Venisse
>             Fix For: 2.0-beta-6
>
>         Attachments: patch.txt
>
>
> Any local changes to pom.xmls are committed when using release:prepare.  Such changes should be committed manually by the user before releasing to keep commits atomic.  Thus pom.xml needs to be removed from the ScmCheckModificationsPhase exclusion list to fail the build under these circumstances.
> The attached patch removes pom.xml from the excluded files and realigns the tests accordingly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRELEASE-233) ScmCheckModificationsPhase ignores pom.xml

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse closed MRELEASE-233.
-------------------------------------

    Resolution: Fixed

Applied. Thanks.

> ScmCheckModificationsPhase ignores pom.xml
> ------------------------------------------
>
>                 Key: MRELEASE-233
>                 URL: http://jira.codehaus.org/browse/MRELEASE-233
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>         Environment: Windows XP, Cygwin
>            Reporter: Mark Hobson
>            Assignee: Emmanuel Venisse
>             Fix For: 2.0-beta-6
>
>         Attachments: patch.txt
>
>
> Any local changes to pom.xmls are committed when using release:prepare.  Such changes should be committed manually by the user before releasing to keep commits atomic.  Thus pom.xml needs to be removed from the ScmCheckModificationsPhase exclusion list to fail the build under these circumstances.
> The attached patch removes pom.xml from the excluded files and realigns the tests accordingly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira