You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "netudima (via GitHub)" <gi...@apache.org> on 2025/12/19 17:05:09 UTC
[PR] [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed [cassandra]
netudima opened a new pull request, #4539:
URL: https://github.com/apache/cassandra/pull/4539
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed [cassandra]
Posted by "netudima (via GitHub)" <gi...@apache.org>.
netudima commented on code in PR #4539:
URL: https://github.com/apache/cassandra/pull/4539#discussion_r2635904232
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -519,7 +519,7 @@ public enum CassandraRelevantProperties
*/
SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"),
SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"),
- SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"),
+ SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"),
Review Comment:
I think, yes, it would cost 1 volatile read but I suppose it is an acceptable cost for this place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed [cassandra]
Posted by "netudima (via GitHub)" <gi...@apache.org>.
netudima commented on code in PR #4539:
URL: https://github.com/apache/cassandra/pull/4539#discussion_r3085295544
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -519,7 +519,7 @@ public enum CassandraRelevantProperties
*/
SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"),
SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"),
- SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"),
+ SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"),
Review Comment:
originally I thought that it would be easy to do, but then I have realised that there is no suitable existing JMX bean for it and I'll have to introduce a new one, so it becomes more expensive (add bean, publication for it, API to retrieve the value), so this is why actually the change is still non-merged :-).
If we do not have a real case I would suggest to keep the current change simple, with ability to change the parameter via restart, and add the runtime change feature later in case of a real demand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed [cassandra]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #4539:
URL: https://github.com/apache/cassandra/pull/4539#discussion_r3081322790
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -519,7 +519,7 @@ public enum CassandraRelevantProperties
*/
SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"),
SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"),
- SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"),
+ SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"),
Review Comment:
I don't see a lot of value allowing this to be changed via JMX. @aratno what is the idea here? Do you see use cases where we might need to toggle this during runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed [cassandra]
Posted by "aratno (via GitHub)" <gi...@apache.org>.
aratno commented on code in PR #4539:
URL: https://github.com/apache/cassandra/pull/4539#discussion_r2635875678
##########
src/java/org/apache/cassandra/concurrent/SEPWorker.java:
##########
@@ -128,8 +130,11 @@ public void run()
assigned = get().assigned;
if (assigned == null)
continue;
- if (SET_THREAD_NAME)
+ if (SET_THREAD_NAME && assigned.name != lastUsedExecutorName) // equals is not used intentionally
Review Comment:
Bit of a nit, but:
```suggestion
if (SET_THREAD_NAME && assigned.name != lastUsedExecutorName) // .equals is not used intentionally
```
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -519,7 +519,7 @@ public enum CassandraRelevantProperties
*/
SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"),
SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"),
- SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"),
+ SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"),
Review Comment:
Can we make this a hot-prop so it can be toggled via JMX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed [cassandra]
Posted by "netudima (via GitHub)" <gi...@apache.org>.
netudima closed pull request #4539: [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed
URL: https://github.com/apache/cassandra/pull/4539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed [cassandra]
Posted by "netudima (via GitHub)" <gi...@apache.org>.
netudima commented on PR #4539:
URL: https://github.com/apache/cassandra/pull/4539#issuecomment-4267880795
Closed via https://github.com/apache/cassandra/commit/32162cf544ddb14e31fcfade931ace483f54917d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed [cassandra]
Posted by "netudima (via GitHub)" <gi...@apache.org>.
netudima commented on code in PR #4539:
URL: https://github.com/apache/cassandra/pull/4539#discussion_r3085295544
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -519,7 +519,7 @@ public enum CassandraRelevantProperties
*/
SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"),
SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"),
- SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"),
+ SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"),
Review Comment:
originally I thought that it would be easy to do, but then I have realised that there is no suitable existing JMX bean for it and I'll have to introduce a new one, so it becomes more expensive (add bean, publication for it, unregistering, API to retrieve the value), so this is why actually the change is still non-merged :-).
If we do not have a real case I would suggest to keep the current change simple, with ability to change the parameter via restart, and add the runtime change feature later in case of a real demand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org