You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Joe Freeman (JIRA)" <ji...@codehaus.org> on 2008/04/27 05:42:46 UTC

[jira] Created: (MECLIPSE-445) myeclipse target doesn't generate spring bean files for hierarchical projects.

myeclipse target doesn't generate spring bean files for hierarchical projects.
------------------------------------------------------------------------------

                 Key: MECLIPSE-445
                 URL: http://jira.codehaus.org/browse/MECLIPSE-445
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
    Affects Versions: 2.5.1
            Reporter: Joe Freeman


The spring bean file creation code doesn't works only when the current working directory is the same as the project directory.  This means it works fine for single level projects.  We have an n-deep hierarchy of projects where we run the eclipse:eclipse and eclipse:myeclipse targets from the top.  In this situation, the cwd doesn't change as it traverses the hierarchy so absolute paths must be used for navigation and then trimmed when the actual fiile references are put in the spring beans file.  I have a patch for this but don't yet have a standalone test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-445) myeclipse target doesn't generate spring bean files for hierarchical projects.

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier updated MECLIPSE-445:
-------------------------------------

    Component/s: MyEclipse support

> myeclipse target doesn't generate spring bean files for hierarchical projects.
> ------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-445
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-445
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: MyEclipse support
>    Affects Versions: 2.5.1
>            Reporter: Joe Freeman
>
> The spring bean file creation code doesn't works only when the current working directory is the same as the project directory.  This means it works fine for single level projects.  We have an n-deep hierarchy of projects where we run the eclipse:eclipse and eclipse:myeclipse targets from the top.  In this situation, the cwd doesn't change as it traverses the hierarchy so absolute paths must be used for navigation and then trimmed when the actual fiile references are put in the spring beans file.  I have a patch for this but don't yet have a standalone test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-445) myeclipse target doesn't generate spring bean files for hierarchical projects.

Posted by "Joe Freeman (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Freeman updated MECLIPSE-445:
---------------------------------

    Attachment: MECLIPSE-445.zip

The modified SpringBeanWriter can now find spring config files using the project root as the starting point for the search rather than the current working directory. The MyEclipse test case has been changed log each test to it's own file in the same way the rad and Eclipse tests do.  There is also a test case that shows that this works.  The eclipse-plugin testing framework does not recurse down to sub projects/modules when comparing results so the test results must be compared manually.

> myeclipse target doesn't generate spring bean files for hierarchical projects.
> ------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-445
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-445
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: MyEclipse support
>    Affects Versions: 2.5.1
>            Reporter: Joe Freeman
>            Assignee: Arnaud Heritier
>             Fix For: 2.5.2
>
>         Attachments: MECLIPSE-445.zip
>
>
> The spring bean file creation code doesn't works only when the current working directory is the same as the project directory.  This means it works fine for single level projects.  We have an n-deep hierarchy of projects where we run the eclipse:eclipse and eclipse:myeclipse targets from the top.  In this situation, the cwd doesn't change as it traverses the hierarchy so absolute paths must be used for navigation and then trimmed when the actual fiile references are put in the spring beans file.  I have a patch for this but don't yet have a standalone test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-445) myeclipse target doesn't generate spring bean files for hierarchical projects.

Posted by "Joe Freeman (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=132767#action_132767 ] 

Joe Freeman commented on MECLIPSE-445:
--------------------------------------

The component should have been set to "myeclipse"

> myeclipse target doesn't generate spring bean files for hierarchical projects.
> ------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-445
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-445
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5.1
>            Reporter: Joe Freeman
>
> The spring bean file creation code doesn't works only when the current working directory is the same as the project directory.  This means it works fine for single level projects.  We have an n-deep hierarchy of projects where we run the eclipse:eclipse and eclipse:myeclipse targets from the top.  In this situation, the cwd doesn't change as it traverses the hierarchy so absolute paths must be used for navigation and then trimmed when the actual fiile references are put in the spring beans file.  I have a patch for this but don't yet have a standalone test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MECLIPSE-445) myeclipse target doesn't generate spring bean files for hierarchical projects.

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier closed MECLIPSE-445.
------------------------------------

    Resolution: Fixed

Fixed in maven-eclipse-plugin 2.6-20080903.065856-3

> myeclipse target doesn't generate spring bean files for hierarchical projects.
> ------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-445
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-445
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: MyEclipse support
>    Affects Versions: 2.5.1
>            Reporter: Joe Freeman
>            Assignee: Arnaud Heritier
>             Fix For: 2.6
>
>         Attachments: MECLIPSE-445.zip
>
>
> The spring bean file creation code doesn't works only when the current working directory is the same as the project directory.  This means it works fine for single level projects.  We have an n-deep hierarchy of projects where we run the eclipse:eclipse and eclipse:myeclipse targets from the top.  In this situation, the cwd doesn't change as it traverses the hierarchy so absolute paths must be used for navigation and then trimmed when the actual fiile references are put in the spring beans file.  I have a patch for this but don't yet have a standalone test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-445) myeclipse target doesn't generate spring bean files for hierarchical projects.

Posted by "Joe Freeman (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=133045#action_133045 ] 

Joe Freeman commented on MECLIPSE-445:
--------------------------------------

It looks like the multi-level test cases are only validating the files at the top level.  project-34 in the test case suite should be failing because the expected results in multymodule-1 do not match the generated files.  A .classpath is generated that is not in the expected directory and the generated .project file does not match the one in the expected directory. 

The test case should call compareDirectoryContent() on each sub-module.



> myeclipse target doesn't generate spring bean files for hierarchical projects.
> ------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-445
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-445
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: MyEclipse support
>    Affects Versions: 2.5.1
>            Reporter: Joe Freeman
>            Assignee: Arnaud Heritier
>             Fix For: 2.5.2
>
>
> The spring bean file creation code doesn't works only when the current working directory is the same as the project directory.  This means it works fine for single level projects.  We have an n-deep hierarchy of projects where we run the eclipse:eclipse and eclipse:myeclipse targets from the top.  In this situation, the cwd doesn't change as it traverses the hierarchy so absolute paths must be used for navigation and then trimmed when the actual fiile references are put in the spring beans file.  I have a patch for this but don't yet have a standalone test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-445) myeclipse target doesn't generate spring bean files for hierarchical projects.

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier updated MECLIPSE-445:
-------------------------------------

         Assignee: Arnaud Heritier
    Fix Version/s: 2.5.2

Feel free to share your patch with us. We'll work on the testcase together if needed

> myeclipse target doesn't generate spring bean files for hierarchical projects.
> ------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-445
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-445
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: MyEclipse support
>    Affects Versions: 2.5.1
>            Reporter: Joe Freeman
>            Assignee: Arnaud Heritier
>             Fix For: 2.5.2
>
>
> The spring bean file creation code doesn't works only when the current working directory is the same as the project directory.  This means it works fine for single level projects.  We have an n-deep hierarchy of projects where we run the eclipse:eclipse and eclipse:myeclipse targets from the top.  In this situation, the cwd doesn't change as it traverses the hierarchy so absolute paths must be used for navigation and then trimmed when the actual fiile references are put in the spring beans file.  I have a patch for this but don't yet have a standalone test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira