You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/28 08:34:02 UTC
[GitHub] [fineract] xurror opened a new pull request #787: FINERACT-845
xurror opened a new pull request #787:
URL: https://github.com/apache/fineract/pull/787
Integrate community-app in fineract docker build
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #787: Integrate community app in docker build (FINERACT-845)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #787:
URL: https://github.com/apache/fineract/pull/787#issuecomment-622931553
@xurror I've just tested this, this is great!! Thanks a lot for contrib.
I've raised a follow-up PR #791 with a small suggested enhancement, for your review.
This deserves a shout out on the list (better only after my follow-up PR is merged, to avoid confusion).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #787: Integrate community app in docker build(FINERACT-845)
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #787:
URL: https://github.com/apache/fineract/pull/787#issuecomment-620495526
All tests are passing. @vorburger, @Anh3h please can you review this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org