[jira] [Commented] (HADOOP-12694) Minor enhancements to test-patch.sh

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087145#comment-15087145 ] 

Hadoop QA commented on HADOOP-12694:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 0s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 0s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 12s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color} | {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 49s {color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12780947/HADOOP-12694-001.patch |
| JIRA Issue | HADOOP-12694 |
| Optional Tests |  asflicense  mvnsite  unit  shellcheck  |
| uname | Linux 9d56a653a79b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 6702e7d |
| shellcheck | v0.4.1 |
| JDK v1.7.0_91  Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/8353/testReport/ |
| modules | C:  U:  |
| Max memory used | 29MB |
| Powered by | Apache Yetus 0.2.0-SNAPSHOT   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/8353/console |


This message was automatically generated.



> Minor enhancements to test-patch.sh
> -----------------------------------
>
>                 Key: HADOOP-12694
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12694
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HADOOP-12694-001.patch
>
>
> Got 2 minor issues when running "dev-support/test-patch.sh ~/tmp/HDFS-9522-003.patch" on Mac.
> 1) "rm" usage message
> {noformat}
> ============================================================================
>                         Confirming git environment
> ...
> Checking patch hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java...
> usage: rm [-f | -i] [-dPRrvW] file ...
>        unlink file
> {noformat}
> 2) Misleading error message when FindBugs home directory is not specified. In this case, neither env FINDBUGS_HOME nor command option "findbugs-home" is set.
> {noformat}
> findbugs baseline for /Users/jzhuge/hadoop
> /bin/findbugs is not executable.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)