You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "messense (via GitHub)" <gi...@apache.org> on 2023/12/10 07:59:47 UTC
[PR] GH-38663: [C++] Add support for service-specific endpoint for S3 using `AWS_ENDPOINT_URL_S3` [arrow]
messense opened a new pull request, #39160:
URL: https://github.com/apache/arrow/pull/39160
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
See #38663
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url.
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
unittest
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
* Closes #38663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38663: [C++] Add support for service-specific endpoint for S3 using `AWS_ENDPOINT_URL_S3` [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39160:
URL: https://github.com/apache/arrow/pull/39160#issuecomment-1883511862
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 13621223d2dec362449721242ba1e3c6dfb27c34.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/20312764104) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38663: [C++] Add support for service-specific endpoint for S3 using `AWS_ENDPOINT_URL_S3` [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #39160:
URL: https://github.com/apache/arrow/pull/39160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38663: [C++] Add support for service-specific endpoint for S3 using `AWS_ENDPOINT_URL_S3` [arrow]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on PR #39160:
URL: https://github.com/apache/arrow/pull/39160#issuecomment-1870086022
Ping @pitrou can you take a look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38663: [C++] Add support for service-specific endpoint for S3 using `AWS_ENDPOINT_URL_S3` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39160:
URL: https://github.com/apache/arrow/pull/39160#issuecomment-1848887721
:warning: GitHub issue #38663 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org