You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/10/10 05:52:07 UTC

[PR] CAMEL-25513: camel-jbang-mcp - a write reports the reload and the first output of the integration running from its directory [camel]

davsclaus opened a new pull request, #27647:
URL: https://github.com/apache/camel/pull/27647

   [CAMEL-25513](https://issues.apache.org/jira/browse/CAMEL-25513)
   
   `camel_write_file` and `camel_edit_file` report what a dev-mode integration did with the written file (CAMEL-24859) only when the tool knows the integration, a selected process. Through camel-jbang-mcp an agent passes the project directory and no name, so no write reported a reload: in a run of the local-model benchmark ladder none of the 68 step traces got one, and the answer only said "An integration running the file in dev mode reloads it now". The agent wrote blind: in the transform-xslt example its stylesheet produced `<packingSlip orderId="" country=""/>`, it read the log before the reload had run, and declared the step done.
   
   **Changes**
   - With no integration selected, the write tools find the one running in dev mode from the directory (`IntegrationLauncher.devModeFrom`: the working directory, as `camel_run` finds an app already running, and started with `--dev`) and await its reload.
   - After a reload, the answer carries what the routes logged within 3 s (`reload.output`, at most 5 lines: the log steps, by their source-location or route-id logger, and any WARN or ERROR), and the message quotes the first: *"The running integration reloaded the file. After the reload it logged: …"*.
   
   Checked end to end with the built MCP server: `camel_run` on a directory, then `camel_edit_file` with only `directory` answered in 2.1 s with `"reload":{"status":"reloaded",…,"output":["Tock  at 07:46:23"]}` - the empty counter visible at once.
   
   Tests: `ReloadOutcomeTest` (the output after the newest reload; Camel's own loggers left out); camel-jbang-core (1628) and camel-jbang-mcp (435) suites green.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25513: camel-jbang-mcp - a write reports the reload and the first output of the integration running from its directory [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27647:
URL: https://github.com/apache/camel/pull/27647#issuecomment-6094634308

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `docs`
   - `dsl/camel-jbang/camel-jbang-core`
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison — Scalpel: 6 of 704 tested, 8 compile-only — current: 6 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **6 affected modules** (current approach: 6).
   
   **Skip-tests mode would test 6 modules** (2 direct + 6 downstream), **skip tests for 8** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (6)</summary>
   
   - `camel-jbang-mcp` ← downstream of org.apache.camel:camel-jbang-core
   - `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
   - `camel-jbang-plugin-route-parser` ← downstream of org.apache.camel:camel-jbang-core
   - `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-jbang-core
   - `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-jbang-core
   - `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
   
   </details>
   
   <details><summary>Modules with tests skipped (8)</summary>
   
   - `camel-jbang-it`
   - `camel-jbang-main`
   - `camel-jbang-plugin-edit`
   - `camel-jbang-plugin-generate`
   - `camel-jbang-plugin-kubernetes`
   - `camel-jbang-plugin-test`
   - `camel-launcher`
   - `coverage`
   
   </details>
   
   > :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
   
   - `dsl/camel-jbang/camel-jbang-core`: 2 test(s) disabled on GitHub Actions
   
   :bulb: **Manual integration tests recommended:**
   
   > You modified `dsl/camel-jbang/camel-jbang-core`. The related integration tests in `dsl/camel-jbang/camel-jbang-it` are excluded from CI. Consider running them manually:
   > ```
   > mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test
   > ```
   
   <details><summary>All tested modules (16 modules, 3m 25s total)</summary>
   
   **Total reactor time:** 3m 25s
   
   | Module | Duration | Status |
   | --- | --- | --- |
   | Camel :: JBang :: Plugin :: TUI | 53.2s | SUCCESS |
   | Camel :: Launcher | 43.3s | SUCCESS |
   | Camel :: JBang :: MCP | 36.1s | SUCCESS |
   | Camel :: JBang :: Plugin :: Kubernetes | 18.8s | SUCCESS |
   | Camel :: Docs | 17.6s | SUCCESS |
   | Camel :: JBang :: Plugin :: Validate | 16.4s | SUCCESS |
   | Camel :: JBang :: Plugin :: Testing | 10.2s | SUCCESS |
   | Camel :: JBang :: Plugin :: MCP | 1.8s | SUCCESS |
   | Camel :: JBang :: Plugin :: Edit | 1.5s | SUCCESS |
   | Camel :: Coverage | 1.4s | SUCCESS |
   | Camel :: JBang :: Plugin :: Generate | 1.1s | SUCCESS |
   | Camel :: JBang :: Plugin :: Route Parser | 1.0s | SUCCESS |
   | Camel :: JBang :: Integration tests | 0.9s | SUCCESS |
   | Camel :: JBang :: Main | 0.7s | SUCCESS |
   | Camel :: Launcher :: Container | 0.6s | SUCCESS |
   | Camel :: JBang :: Core | n/a |  |
   
   **Top 20 slowest modules:**
   - `Camel :: JBang :: Plugin :: TUI` (53.2s)
   - `Camel :: Launcher` (43.3s)
   - `Camel :: JBang :: MCP` (36.1s)
   - `Camel :: JBang :: Plugin :: Kubernetes` (18.8s)
   - `Camel :: Docs` (17.6s)
   - `Camel :: JBang :: Plugin :: Validate` (16.4s)
   - `Camel :: JBang :: Plugin :: Testing` (10.2s)
   - `Camel :: JBang :: Plugin :: MCP` (1.8s)
   - `Camel :: JBang :: Plugin :: Edit` (1.5s)
   - `Camel :: Coverage` (1.4s)
   - `Camel :: JBang :: Plugin :: Generate` (1.1s)
   - `Camel :: JBang :: Plugin :: Route Parser` (1.0s)
   - `Camel :: JBang :: Integration tests` (0.9s)
   - `Camel :: JBang :: Main` (0.7s)
   - `Camel :: Launcher :: Container` (0.6s)
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/38029579306)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25513: camel-jbang-mcp - a write reports the reload and the first output of the integration running from its directory [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #27647:
URL: https://github.com/apache/camel/pull/27647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25513: camel-jbang-mcp - a write reports the reload and the first output of the integration running from its directory [camel]

Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on code in PR #27647:
URL: https://github.com/apache/camel/pull/27647#discussion_r4236639448


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/IntegrationLauncher.java:
##########
@@ -353,6 +353,20 @@ private static String runningMessage(String name, long pid) {
     }
 
     /** The integration that runs with this directory as its working directory, or null. */
+    /**

Review Comment:
   💡 **Nit:** The single-line Javadoc on line 355 (`/** The integration that runs with this directory as its working directory, or null. */`) is now orphaned — it was the Javadoc for `runningFrom()` (below), but inserting `devModeFrom()` between them left it dangling before this new method. Java Javadoc tooling assigns it to `devModeFrom()`, shadowing the correct multi-line Javadoc that follows. Remove the orphaned comment (or move it to `runningFrom()` which currently has none).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25513: camel-jbang-mcp - a write reports the reload and the first output of the integration running from its directory [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #27647:
URL: https://github.com/apache/camel/pull/27647#discussion_r4236644804


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/IntegrationLauncher.java:
##########
@@ -353,6 +353,20 @@ private static String runningMessage(String name, long pid) {
     }
 
     /** The integration that runs with this directory as its working directory, or null. */
+    /**

Review Comment:
   Fixed in e369a15db19f: the one-line javadoc is back on runningFrom.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25513: camel-jbang-mcp - a write reports the reload and the first output of the integration running from its directory [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27647:
URL: https://github.com/apache/camel/pull/27647#issuecomment-6094385528

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org