You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Thilo Frotscher (JIRA)" <ji...@apache.org> on 2006/05/02 04:19:46 UTC
[jira] Created: (AXIS2-653) Handler method "cleanup" is never
called
Handler method "cleanup" is never called
----------------------------------------
Key: AXIS2-653
URL: http://issues.apache.org/jira/browse/AXIS2-653
Project: Apache Axis 2.0 (Axis2)
Type: Bug
Components: core
Versions: 1.0
Reporter: Thilo Frotscher
1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
3) User guide, page 4
- mentions a method called "revoke". There is no such method in interface Handler.
- refers to green lines in sample configuration...there are no green lines
- sample configuration contains mistakes
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Bill Nagy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12431888 ]
Bill Nagy commented on AXIS2-653:
---------------------------------
Hi Deepal. I actually proposed this modification to the lifecycle sometime in April ( http://marc.theaimsgroup.com/?l=axis-dev&m=114505970102143&w=2 ), but haven't gotten the code out yet. You still need a cleanup() method to match the init() to allow, for instance, a handler that is maintaining a DB connection throughout its lifetime (the lifetime of the system as you said) to close the connection when it is being shut down (i.e. when the system is stopped.) As for the "anti"invoke methods, you need to make sure that they get called in the opposite order that the invokes happened (and in the same place in the call stack,) that they are called only for those handlers who have had their invokes called, and that they are called both for normal completion as well as in the case of a fault.
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Bill Nagy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=all ]
Bill Nagy updated AXIS2-653:
----------------------------
Attachment: (was: qoslifecyclepatch.txt)
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12437469 ]
Davanum Srinivas commented on AXIS2-653:
----------------------------------------
Bill,
Quick browse did not show me where .cleanup for handlers is invoked. can u please add that as well?
thanks,
dims
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
> Attachments: qoslifecyclepatch.txt
>
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepal Jayasinghe resolved AXIS2-653.
-------------------------------------
Resolution: Fixed
we will not fix that , since there is an alternative to this;
same thing can be done using flowComplete
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: https://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Critical
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Thilo Frotscher (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12377961 ]
Thilo Frotscher commented on AXIS2-653:
---------------------------------------
IMHO it would be very important for handlers to be notified if something went wrong, so that they have a chance to redo actions that were caused by the message causing the error. Imagine a handler responsible for billing, which tracks incoming messages to charge clients afterwards. A client would not want to pay for request that didn't go through due to exceptions that occured - let's say - in a logging handler that was invoked after the billing handler.
Axis 1.x had a very good mechanims, in which all prior handlers were informed when an error occured in a subsequent handler. Axis2 should have this, too.
Regarding to cleanup: handlers should be able to cleanup the ressources they used (e.g. database connections etc)
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: core
> Versions: 1.0
> Reporter: Thilo Frotscher
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Eran Chinthaka (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=all ]
Eran Chinthaka updated AXIS2-653:
---------------------------------
Priority: Major (was: Blocker)
Reducing the priority as
1. the discussion on this is yet to be finished
2. not a blocker for the next release.
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Sanjiva Weerawarana (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12377317 ]
Sanjiva Weerawarana commented on AXIS2-653:
-------------------------------------------
Can we please fix the javadoc ... to make sure we give the right info!
Sanjiva.
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: core
> Versions: 1.0
> Reporter: Thilo Frotscher
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=all ]
Deepal Jayasinghe reassigned AXIS2-653:
---------------------------------------
Assignee: Deepal Jayasinghe
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12437556 ]
Davanum Srinivas commented on AXIS2-653:
----------------------------------------
Bill,
Whichever suits u best is ok with me. I just got confused because of the subject of this JIRA...I will try to review the code later today.
-- dims
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
> Attachments: qoslifecyclepatch.txt
>
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12443490 ]
Deepal Jayasinghe commented on AXIS2-653:
-----------------------------------------
Didnt Bil has fix the issue in trunk ?
If he has then we can close the issue.
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Critical
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Bill Nagy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12437571 ]
Bill Nagy commented on AXIS2-653:
---------------------------------
I've created a new task, AXIS2-1233, to track the handler invocation/lifecycle issues (i.e. not the cleanup(...)) and moved my patch there. Had I been smarter, I would have created a sub-task instead of a new issue...
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Bill Nagy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=all ]
Bill Nagy updated AXIS2-653:
----------------------------
Attachment: qoslifecyclepatch.txt
Here's a patch that implements the QoS/handler lifecycle. (This still doesn't fix the module lifecycle issue [i.e. the cleanup() method not being invoked.]). The flowComplete(...) method for a handler will be invoked as the stack is unwound from either a successful completion or an error. (If you want to know the order in which things occur, you can look at the comparisons at the end of the test cases.) The only extra info that is kept is two linked lists in the MessageContext which maintain the set of phases that have been processed. (If a phase could certainly keep extra state if it desired, but I didn't need to do so in any of the standard Axis2 phases.) The only cost to execute (besides list insertions) is the added invocation of the flowComplete(...) on each handler that was executed during processing of the message. (The handler can do whatever it wants in the flowComplete(...), so we have no control over how long that takes.)
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
> Attachments: qoslifecyclepatch.txt
>
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12377311 ]
Deepal Jayasinghe commented on AXIS2-653:
-----------------------------------------
If handler throw exception when calling invoke method , then AxisEngine will catch and create SOAPFault out of that.
Regarding cleanup , yes we are not using that , but we had a discussion in the mailing list to improve the handler functionality
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: core
> Versions: 1.0
> Reporter: Thilo Frotscher
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Thilo Frotscher (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12422878 ]
Thilo Frotscher commented on AXIS2-653:
---------------------------------------
Can you please make sure that the cleanup-Method is called when a Handler is destroyed? Many thanks!
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Bill Nagy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12437555 ]
Bill Nagy commented on AXIS2-653:
---------------------------------
Hi dims,
You won't find it -- as I mentioned, there are two completely separate issues here: one with cleanup(...) not being called when a handler/module instance is getting removed and one with not having handlers being able to be notified when processing of a message that they have worked on/seen has been completed (in both fault and normal circumstances.) I've addressed the later as of right now. Would you like me to open up two new JIRA issues and close this one to reflect the fact that there are two completely separate issues here?
-Bill
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
> Attachments: qoslifecyclepatch.txt
>
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=all ]
Davanum Srinivas updated AXIS2-653:
-----------------------------------
Priority: Blocker (was: Major)
Chinthaka,
Let's at least update the javadocs to reflect the reality and *THEN* downgrade the bug.
thanks,
dims
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=all ]
Davanum Srinivas updated AXIS2-653:
-----------------------------------
Priority: Blocker (was: Major)
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Priority: Blocker
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12431800 ]
Deepal Jayasinghe commented on AXIS2-653:
-----------------------------------------
I think we need to call cleanup method after each invocation , since lifetime of a handler is same as lifetime of the system. So calling that method only one time make no sense to me.
So how about calling
first call handler. Invoke(msgCtx);
then handler.cleanup(msgCtx);
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Priority: Blocker
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=all ]
Davanum Srinivas updated AXIS2-653:
-----------------------------------
Priority: Critical (was: Blocker)
downgrading after javadoc'ing the issues.
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Critical
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-653) Handler method "cleanup" is never
called
Posted by "Eran Chinthaka (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-653?page=comments#action_12439068 ]
Eran Chinthaka commented on AXIS2-653:
--------------------------------------
Dims,
I added a comment for Handler and AbstractHandler. Please take a look at them and downgrade the priority if you agree.
Thanks,
Chinthaka
> Handler method "cleanup" is never called
> ----------------------------------------
>
> Key: AXIS2-653
> URL: http://issues.apache.org/jira/browse/AXIS2-653
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Assigned To: Deepal Jayasinghe
> Priority: Blocker
>
> 1) My IDE couldn't find any references to method "cleanup" in the Axis2 source code. It's never called...
> 2) What happens if the handler's invoke method thows a fault? Javadoc for "invoke" says that "onFault" would be called. But there is no such method...
> 3) User guide, page 4
> - mentions a method called "revoke". There is no such method in interface Handler.
> - refers to green lines in sample configuration...there are no green lines
> - sample configuration contains mistakes
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org