[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

[ravipesala <gi...@git.apache.org>]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/971#discussion_r119781493
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java ---
    @@ -65,20 +68,20 @@
         this.pageSize = pageSize;
         keyColumnPage = new KeyColumnPage(pageSize,
             model.getSegmentProperties().getDimensionPartitions().length);
    -    noDictDimensionPage = new VarLengthColumnPage[model.getNoDictionaryCount()];
    +    noDictDimensionPage = new PrimitiveColumnPage[model.getNoDictionaryCount()];
         for (int i = 0; i < noDictDimensionPage.length; i++) {
    -      noDictDimensionPage[i] = new VarLengthColumnPage(pageSize);
    +      noDictDimensionPage[i] = new PrimitiveColumnPage(DataType.STRING, pageSize);
    --- End diff --
    
    Primitive column page should only contains primitive data types, it should not contain string or decimal. So better create another page for string and decimal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---