You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dg4prez <gi...@git.apache.org> on 2017/02/20 03:32:16 UTC
[GitHub] incubator-trafficcontrol pull request #293: Add Json in response body by def...
GitHub user dg4prez opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/293
Add Json in response body by default option to Steering
This adds the UI and API components necessary to insert a "jsonSteering" field in the steering json file provided to traffic router by traffic ops at /internal/api/1.2/steering. The default value is 0, which is normal behavior. A value of 1 will signal traffic router to provide the steering list in json format in the body of the response by default, rather than the usual headers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dg4prez/incubator-trafficcontrol steering
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit 8495b6b4cf2cead57ff0e16811d080ff75c91c54
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-02-20T00:36:45Z
create json_steering db flag
commit dfcc40a0637d20c097445a00b33fff61f6d29090
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-02-20T01:17:21Z
let's use a default of 0
commit 6d391661f89809be850cbcb7738495e4b15171df
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-02-20T01:22:14Z
add jsonSteering to api json
commit 6620b8bbbd65a89a76670346583d2217c4413653
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-02-20T01:58:40Z
add delivery service API components
commit 02bdec4c400d21fe45a0b2d27502f3b56e31b4e5
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-02-20T02:17:01Z
add UI bits and pieces
commit b79e8422f94835f72e7d5e523796ff0426ea8f58
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-02-20T03:22:17Z
hide json onoff for non steering types
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #293: Add Json in response body by default op...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/293
example output of the steering json file provided to traffic router:
`{
response: [
{
targets: [
{
weight: "0",
deliveryService: "ccp-top-omg-01"
},
{
weight: "0",
deliveryService: "ccp-top-omg-02"
}
],
filters: [ ],
deliveryService: "more_steering",
jsonSteering: "1"
},
{
targets: [
{
weight: "0",
deliveryService: "ccp-top-omg-03"
},
{
weight: "0",
deliveryService: "ccp-top-omg-04"
}
],
filters: [ ],
deliveryService: "some_steering",
jsonSteering: "1"
},
{
targets: [
{
weight: "0",
deliveryService: "ccp-omg-01"
},
{
weight: "0",
deliveryService: "ccp-omg-02"
}
],
filters: [ ],
deliveryService: "steering_test",
jsonSteering: "0"
}
]
}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #293: WIP Do Not Merge - Add Json in r...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #293: Add Json in response body by def...
Posted by dg4prez <gi...@git.apache.org>.
GitHub user dg4prez reopened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/293
Add Json in response body by default option to Steering
This adds the UI and API components necessary to insert a "jsonSteering" field in the steering json file provided to traffic router by traffic ops at /internal/api/1.2/steering. The default value is 0, which is normal behavior. A value of 1 will signal traffic router to provide the steering list in json format in the body of the response by default, rather than the usual headers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dg4prez/incubator-trafficcontrol steering
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit 836ec0d3cb07b336df9cc7e24d79ac4a041ac85f
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-02-20T14:46:56Z
add json_steering column to db.
commit da20d52e5309560aabadd5c09709f3107d657f1f
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-02-20T15:08:26Z
add jsonDefault to steering api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #293: WIP Do Not Merge - Add Json in response...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/293
This seems to break genfiles. Will fix if we go in this direction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #293: WIP Do Not Merge - Add Json in response...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/293
Closing in favor of https://github.com/apache/incubator-trafficcontrol/pull/308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #293: Add Json in response body by def...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #293: Add Json in response body by default op...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/293
Need to make a few changes to this. Do not merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---