You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2019/04/21 01:16:00 UTC
[jira] [Commented] (CALCITE-3009) DiffRepository should fail if XML
resource file contains duplicate test names
[ https://issues.apache.org/jira/browse/CALCITE-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822601#comment-16822601 ]
Julian Hyde commented on CALCITE-3009:
--------------------------------------
Reviewing now. Looks good, and I should be able to commit soon.
> DiffRepository should fail if XML resource file contains duplicate test names
> -----------------------------------------------------------------------------
>
> Key: CALCITE-3009
> URL: https://issues.apache.org/jira/browse/CALCITE-3009
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.19.0
> Reporter: Chunwei Lei
> Assignee: Chunwei Lei
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There are duplicate keys for {{testProjectCorrelateTranspose}} in RelOptRulesTest.xml[1][2]. We should add a test to make it fail when having duplicate keys in a {{.xml}} file.
>
> [1] [https://github.com/apache/calcite/blob/master/core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml#L9226]
> [2] [https://github.com/apache/calcite/blob/master/core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml#L9253]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)