[GitHub] [lucene-solr] rmuir commented on a change in pull request #1095: SOLR-14095: Let the overseer use javabin to store responses in ZooKeeper

[GitBox <gi...@apache.org>]

rmuir commented on a change in pull request #1095: SOLR-14095: Let the overseer use javabin to store responses in ZooKeeper
URL: https://github.com/apache/lucene-solr/pull/1095#discussion_r359082802
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponse.java
 ##########
 @@ -48,5 +54,40 @@ public void setElapsedTime(long elapsedTime) {
   public NamedList<Object> getResponse() {
     return responseList;
   }
+
+  /**
+   * This method serializes the content of an {@code OverseerSolrResponse}. Note that:
+   * <ul>
+   * <li>The elapsed time is not serialized</li>
+   * <li>"Unknown" elements for the Jababin format will be serialized as Strings. See {@link org.apache.solr.common.util.JavaBinCodec#writeVal}</li>
 
 Review comment:
   typo: Jababin

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org