You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Tong Li <li...@us.ibm.com> on 2015/04/01 21:26:37 UTC
Review Request 32740: Patch for KAFKA-1926
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32740/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1926
https://issues.apache.org/jira/browse/KAFKA-1926
Repository: kafka
Description
-------
Diffs
-----
clients/src/main/java/org/apache/kafka/common/utils/Utils.java 920b51a6c3c99639fbc9dc065637eeee3c19fabd
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java c899813d55b9c4786adde3d840f040d6645d27c8
core/src/main/scala/kafka/Kafka.scala 37de7df059829f40300aa5f920219b869f9c7f78
core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb
core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 79b5e0aeb4af77d356f80107685cd9a7d508ef16
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
core/src/main/scala/kafka/admin/TopicCommand.scala f400b71f8444fffd3fc1d8398a283682390eba4e
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6
core/src/main/scala/kafka/cluster/Partition.scala c4bf48a801007ebe7497077d2018d6dffe1677d4
core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068
core/src/main/scala/kafka/consumer/ConsumerIterator.scala b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5
core/src/main/scala/kafka/consumer/PartitionAssignor.scala bc2e5b40e29659b8902b65a3234d6b53d8b1aa75
core/src/main/scala/kafka/consumer/TopicCount.scala 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala b1cf0db8741e384e4e4119751058ea87b2589e57
core/src/main/scala/kafka/controller/ControllerChannelManager.scala c582191636f6188c25d62a67ff0315b56f163133
core/src/main/scala/kafka/controller/KafkaController.scala 09fc46d759b74bcdad2d2a610d9c5a93ff02423f
core/src/main/scala/kafka/controller/PartitionStateMachine.scala 2f0694bc5cdfc763f4872d58bec925d0cf919da1
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 3e87e1d36f87b7dd539a474609b1c95487a4c337
core/src/main/scala/kafka/controller/TopicDeletionManager.scala e56f22d7399061a72aa67a9ee73ea4d91345c01f
core/src/main/scala/kafka/log/FileMessageSet.scala b2652ddbe2f857028d5980e29a008b2c614694a3
core/src/main/scala/kafka/log/Log.scala 06b8ecc5d11a1acfbaf3c693c42bf3ce5b2cd86d
core/src/main/scala/kafka/log/LogCleanerManager.scala 351824b3c9fabe0942528147bdde8cee13b63e20
core/src/main/scala/kafka/log/LogConfig.scala 8b67aee3a37765178b30d79e9e7bb882bdc89c29
core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d
core/src/main/scala/kafka/log/LogSegment.scala 02567649dd82309011ba2ac6dceda97683e4f5ed
core/src/main/scala/kafka/log/OffsetIndex.scala ca82c043bb8413b1e010c40de9db1b6dae85e3ac
core/src/main/scala/kafka/log/OffsetMap.scala 42cdfbb6100b5c89d86144f92f661ebd844b2132
core/src/main/scala/kafka/message/Message.scala d3024807a84e104e6a28a29c957f4b964d8dd416
core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d
core/src/main/scala/kafka/message/MessageWriter.scala 7eb72cbdc37de55875d8263aae5bb166d977a491
core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala ea9559f822c1120e1997916190fcd597328e4965
core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala 84f6208610e09943e984b54c07b8d287945574f8
core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala 14e46244ee27c8c99f33852cf03bb907cebafa51
core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75
core/src/main/scala/kafka/network/SocketServer.scala 76ce41aed6e04ac5ba88395c4d5008aca17f9a73
core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 6a3b02e414eb7d62cfaece3344245feac54cecda
core/src/main/scala/kafka/producer/DefaultPartitioner.scala 3afb22eeb4e3b8ecf49e92bd167f2f67b8f6a961
core/src/main/scala/kafka/producer/Producer.scala e38d2fa7ec873677cc23b94092ddcd55baf1a3a2
core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255
core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 821901e4f434dfd9eec6eceabfc2e1e65507a57c
core/src/main/scala/kafka/server/AbstractFetcherManager.scala 20c00cb8cc2351950edbc8cb1752905a0c26e79f
core/src/main/scala/kafka/server/AbstractFetcherThread.scala 5d5cf5897cc37b3595f14bfe9d7cde43456bcc4b
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala 0e542ff0cc3eda1cbcef621e73e404c56f092862
core/src/main/scala/kafka/server/KafkaConfig.scala 422451aec5ea0442eb2e4c1ae772885b813904a9
core/src/main/scala/kafka/server/KafkaRequestHandler.scala 4d86bdf5d146d193858005e7ecadd6e322ca2e20
core/src/main/scala/kafka/server/KafkaServer.scala 4db3384545be8c237d6fc9646716ab67d5193ec5
core/src/main/scala/kafka/server/MetadataCache.scala 6aef6e4508ecadbbcc1e12bed2054547b7aa333e
core/src/main/scala/kafka/server/OffsetManager.scala 395b1dbe43a5db47151e72a1b588d72f03cef963
core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala a75818a724ff3492f640eec7a57f596324ce6c03
core/src/main/scala/kafka/tools/ConsoleConsumer.scala 910691e88ccc66a1542d0ea85bb2f732861d805e
core/src/main/scala/kafka/tools/DumpLogSegments.scala b7a3630834c8e2c4740e56ac16cc9dfa42554f93
core/src/main/scala/kafka/tools/KafkaMigrationTool.java 026d8198678d3e3e41feddcdaa53b67dad5c0e64
core/src/main/scala/kafka/tools/MirrorMaker.scala ec077434cac25a10e4f59b9aa569581a2776b2a3
core/src/main/scala/kafka/tools/SimpleConsumerShell.scala b4f903b6c7c3bb725cac7c05eb1f885906413c4d
core/src/main/scala/kafka/tools/StateChangeLogMerger.scala b34b8c7d7d4caaab230719a67048310e0fbb3280
core/src/main/scala/kafka/tools/TestEndToEndLatency.scala 48cff20e760a9797ad64ef2a5a28e07e2951f096
core/src/main/scala/kafka/tools/TestLogCleaning.scala af496f7c547a5ac7a4096a6af325dad0d8feec6f
core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala 111c9a8b94ce45d95551482e9fd3f8c1cccbf548
core/src/main/scala/kafka/utils/CoreUtils.scala PRE-CREATION
core/src/main/scala/kafka/utils/Crc32.java 0e0e7bcb33886f47b9770a122d00d6eafdbb89a9
core/src/main/scala/kafka/utils/KafkaScheduler.scala 7ceadccefe8206440ab1218a0e7cc36f1307e85a
core/src/main/scala/kafka/utils/Log4jController.scala a015c8109f050cabdea988f2215bd01ec0d8573a
core/src/main/scala/kafka/utils/Logging.scala 2890e7f51ddcb056672b30047b7b1df84a5b8df9
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/main/scala/kafka/utils/VerifiableProperties.scala 2ffc7f452dc7a1b6a06ca7a509ed49e1ab3d1e68
core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala cae72f4f87f10b843c29dc731c6e0028b1d50734
core/src/test/scala/kafka/tools/TestEndToEndLatency.scala PRE-CREATION
core/src/test/scala/kafka/tools/TestLogCleaning.scala PRE-CREATION
core/src/test/scala/other/kafka/DeleteZKPath.scala 25545037517b127911cedc39419194535a75be8a
core/src/test/scala/other/kafka/StressTestLog.scala e19b8b28383554512a0c1f651d6764650d8db9c4
core/src/test/scala/other/kafka/TestCrcPerformance.scala 42e3c62055c1562d3a1cee4c8374ae2559a55be7
core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala 7211c2529c1db76100432737da7a1d1d221dfba0
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 8bc178505e00932a316c46ed1d904bd57b5b3f75
core/src/test/scala/unit/kafka/admin/AdminTest.scala ee0b21e6a94ad79c11dd08f6e5adf98c333e2ec9
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala 995397ba2e2dfc6fadd9d5c5efd90f2c4ac0d59c
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 062790f15d4ab6e0ee7a98bef12aaa2b22da3bfa
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 30deaf47b64592f2e1cc84a4156671fac11b67ef
core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala 4d27e41c727e73544b2b214a0a0b60f6acdbfd17
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala 8342cae564ebc39fe74a512343a4523072ca205a
core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala fa4a8ad0acc9e8eca8f2e035ec7fe9bb24d8589a
core/src/test/scala/unit/kafka/log/CleanerTest.scala a4da95f765e5778c896551ecef0e0eaef5167ae1
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 07acd460b1259e0a3f4069b8b8dcd8123ef5810e
core/src/test/scala/unit/kafka/log/LogManagerTest.scala 90cd53033fafaf952ba0b3f1e28b0e1f1ad3ea76
core/src/test/scala/unit/kafka/log/LogTest.scala 3c0599cc2ea12566fbec8233e3a73b31854b3b38
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 36db9172ea2d4d7e242e023ba914596c1f64f5f4
core/src/test/scala/unit/kafka/message/MessageTest.scala 7b74a0d31547074ef4ed0f95e5b347b2007c6eaf
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala be90c5bc7f1f5ba8a237d1c7176f27029727c918
core/src/test/scala/unit/kafka/producer/ProducerTest.scala d2f3851cb68ff595bbb859d27b3552e751d060bb
core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala 296e2b563041318d360db4037411879613a63968
core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala 0bdbc2f31fcac2abdeff4e41e448a7b9ab13b95b
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala f2528059dd86bb051d1ce9d72039cde3b78b8817
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 8c9f9e748e888da6035755c9f4241ac3aa0500c9
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 7654275c5437e1db319f01a8d587d66b42ea8dc7
core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala 96a8a5a8cb1f40f743490f85bf18d441ce86a765
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 71317eb46b8d76060b115e6c1d31a4653459724f
core/src/test/scala/unit/kafka/server/ServerStartupTest.scala 60021ef8d8d7fa172d6b160db48ee5eb9574e1a9
core/src/test/scala/unit/kafka/utils/TestUtils.scala 1682a77362123449de6bb1d54a55887409990a24
core/src/test/scala/unit/kafka/utils/UtilsTest.scala 8c3797a964a2760a00ed60530d1a48e3da473769
core/src/test/scala/unit/kafka/zk/EmbeddedZookeeper.scala 31515615089385c722325bfe019a47ae3a9a4052
core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala 67d9c4bab270c852dc05d47aaa4dd96b0f6039d4
Diff: https://reviews.apache.org/r/32740/diff/
Testing
-------
Thanks,
Tong Li
Re: Review Request 32740: Patch for KAFKA-1926
Posted by Tong Li <li...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32740/
-----------------------------------------------------------
(Updated April 6, 2015, 3:45 a.m.)
Review request for kafka.
Bugs: KAFKA-1926
https://issues.apache.org/jira/browse/KAFKA-1926
Repository: kafka
Description
-------
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/common/utils/Utils.java 39e8d7c95eddfe96253eca880789e904e017a96a
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java 4b706d7881769ade621032883da998a94332a568
core/src/main/scala/kafka/Kafka.scala 37de7df059829f40300aa5f920219b869f9c7f78
core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb
core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 79b5e0aeb4af77d356f80107685cd9a7d508ef16
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
core/src/main/scala/kafka/admin/TopicCommand.scala e36a9d17c9ca281deb7a40bb364c2d203a87473b
core/src/main/scala/kafka/client/ClientUtils.scala ad4c9d20002135e1114a26f0696ffb0f349c8878
core/src/main/scala/kafka/cluster/Broker.scala 3933bb3d1e6b38f5ecda4548c7649f18f24772c4
core/src/main/scala/kafka/cluster/Partition.scala 6d142d645013d0f914e2c63aee7a4741986ada2f
core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 484a57f996e4d0a84bdaf1db3e87eb85fd6b503f
core/src/main/scala/kafka/consumer/ConsumerIterator.scala b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5
core/src/main/scala/kafka/consumer/PartitionAssignor.scala bc2e5b40e29659b8902b65a3234d6b53d8b1aa75
core/src/main/scala/kafka/consumer/TopicCount.scala 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 3e8a75b6357b3432abc460adcf32db7172225ca8
core/src/main/scala/kafka/controller/ControllerChannelManager.scala fb596ba228d87c4d363d977738635b8f91c2df16
core/src/main/scala/kafka/controller/KafkaController.scala f2e62f5038c10178a09ed2c9f5a54f4d8212acdc
core/src/main/scala/kafka/controller/PartitionStateMachine.scala 2f0694bc5cdfc763f4872d58bec925d0cf919da1
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 3e87e1d36f87b7dd539a474609b1c95487a4c337
core/src/main/scala/kafka/controller/TopicDeletionManager.scala e56f22d7399061a72aa67a9ee73ea4d91345c01f
core/src/main/scala/kafka/log/FileMessageSet.scala b2652ddbe2f857028d5980e29a008b2c614694a3
core/src/main/scala/kafka/log/Log.scala a0745be9500e8f570184cd6909b09cec4cd9efbb
core/src/main/scala/kafka/log/LogCleanerManager.scala 351824b3c9fabe0942528147bdde8cee13b63e20
core/src/main/scala/kafka/log/LogConfig.scala 8b67aee3a37765178b30d79e9e7bb882bdc89c29
core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d
core/src/main/scala/kafka/log/LogSegment.scala 02567649dd82309011ba2ac6dceda97683e4f5ed
core/src/main/scala/kafka/log/OffsetIndex.scala ca82c043bb8413b1e010c40de9db1b6dae85e3ac
core/src/main/scala/kafka/log/OffsetMap.scala 42cdfbb6100b5c89d86144f92f661ebd844b2132
core/src/main/scala/kafka/message/Message.scala 7ba280f955ed19685b298e1729fdf3a531d87007
core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d
core/src/main/scala/kafka/message/MessageWriter.scala 7eb72cbdc37de55875d8263aae5bb166d977a491
core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala ea9559f822c1120e1997916190fcd597328e4965
core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala 84f6208610e09943e984b54c07b8d287945574f8
core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala 14e46244ee27c8c99f33852cf03bb907cebafa51
core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75
core/src/main/scala/kafka/network/SocketServer.scala 0ad9057765815bcd07bb914ccc4462e65c441671
core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 6a3b02e414eb7d62cfaece3344245feac54cecda
core/src/main/scala/kafka/producer/DefaultPartitioner.scala 3afb22eeb4e3b8ecf49e92bd167f2f67b8f6a961
core/src/main/scala/kafka/producer/Producer.scala e38d2fa7ec873677cc23b94092ddcd55baf1a3a2
core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255
core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 821901e4f434dfd9eec6eceabfc2e1e65507a57c
core/src/main/scala/kafka/server/AbstractFetcherManager.scala 94aa952f6a7d3a815612e83aa804bb22c4560527
core/src/main/scala/kafka/server/AbstractFetcherThread.scala 93f67d5c4dc895274efdc891cf9d98f651cd7c0b
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala 0e542ff0cc3eda1cbcef621e73e404c56f092862
core/src/main/scala/kafka/server/KafkaConfig.scala cf1a5a65cb176d38d4a8cf3c831473aeea6b0d25
core/src/main/scala/kafka/server/KafkaRequestHandler.scala 4d86bdf5d146d193858005e7ecadd6e322ca2e20
core/src/main/scala/kafka/server/KafkaServer.scala 9df2cf4c4367151a3c277e2560956f31712b72d1
core/src/main/scala/kafka/server/MetadataCache.scala 008f02b64434ef3c80fd27aee3db034beabb7539
core/src/main/scala/kafka/server/OffsetManager.scala 395b1dbe43a5db47151e72a1b588d72f03cef963
core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala a75818a724ff3492f640eec7a57f596324ce6c03
core/src/main/scala/kafka/tools/ConsoleConsumer.scala 910691e88ccc66a1542d0ea85bb2f732861d805e
core/src/main/scala/kafka/tools/DumpLogSegments.scala b7a3630834c8e2c4740e56ac16cc9dfa42554f93
core/src/main/scala/kafka/tools/KafkaMigrationTool.java 026d8198678d3e3e41feddcdaa53b67dad5c0e64
core/src/main/scala/kafka/tools/MirrorMaker.scala ec077434cac25a10e4f59b9aa569581a2776b2a3
core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 7379fe30e3ec465e94794bebac4f6bd16ecdb688
core/src/main/scala/kafka/tools/StateChangeLogMerger.scala b34b8c7d7d4caaab230719a67048310e0fbb3280
core/src/main/scala/kafka/tools/TestEndToEndLatency.scala 48cff20e760a9797ad64ef2a5a28e07e2951f096
core/src/main/scala/kafka/tools/TestLogCleaning.scala af496f7c547a5ac7a4096a6af325dad0d8feec6f
core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala e82cb818ff0eaa39560b8bc9c1c34a1985834740
core/src/main/scala/kafka/utils/CoreUtils.scala PRE-CREATION
core/src/main/scala/kafka/utils/Crc32.java 0e0e7bcb33886f47b9770a122d00d6eafdbb89a9
core/src/main/scala/kafka/utils/KafkaScheduler.scala 7ceadccefe8206440ab1218a0e7cc36f1307e85a
core/src/main/scala/kafka/utils/Log4jController.scala a015c8109f050cabdea988f2215bd01ec0d8573a
core/src/main/scala/kafka/utils/Logging.scala 2890e7f51ddcb056672b30047b7b1df84a5b8df9
core/src/main/scala/kafka/utils/Utils.scala afc3b4e97968afdc5242517aa87d15b81ce80dd6
core/src/main/scala/kafka/utils/VerifiableProperties.scala 2ffc7f452dc7a1b6a06ca7a509ed49e1ab3d1e68
core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala 3a7ae8be5eaa1a04a34c4d5d1f20c29a6b026437
core/src/test/scala/kafka/tools/TestEndToEndLatency.scala PRE-CREATION
core/src/test/scala/kafka/tools/TestLogCleaning.scala PRE-CREATION
core/src/test/scala/other/kafka/DeleteZKPath.scala 25545037517b127911cedc39419194535a75be8a
core/src/test/scala/other/kafka/StressTestLog.scala e19b8b28383554512a0c1f651d6764650d8db9c4
core/src/test/scala/other/kafka/TestCrcPerformance.scala 42e3c62055c1562d3a1cee4c8374ae2559a55be7
core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala 7211c2529c1db76100432737da7a1d1d221dfba0
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 76b8b248d3f198286ce21cf73959ff91eaace301
core/src/test/scala/unit/kafka/admin/AdminTest.scala 0305f704b66a257d1ae732550793dbb2536e7ac1
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala bb25467f51bb1fd3da1b4e61fd7f2bb817618d02
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala f95fb62f7756e0ca30bccacb28256a2f2b0a3120
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala f601d31bc406c1c66772fefc4fe22938e6ab8754
core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala 130b20533d35499e0d4e0403d521b246610bd325
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala 7c87b81b12366eb04144ec4005a5fda0d0260eea
core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala fa4a8ad0acc9e8eca8f2e035ec7fe9bb24d8589a
core/src/test/scala/unit/kafka/log/CleanerTest.scala c20e423016fd8b897f3c135f8c72c7dafd426723
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 07acd460b1259e0a3f4069b8b8dcd8123ef5810e
core/src/test/scala/unit/kafka/log/LogManagerTest.scala 90cd53033fafaf952ba0b3f1e28b0e1f1ad3ea76
core/src/test/scala/unit/kafka/log/LogTest.scala bd9a409eacfd2353ce41c83815914edd4e399b93
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 18361c13fd0b8cd60f45249507b76d53e6001c12
core/src/test/scala/unit/kafka/message/MessageTest.scala 7b74a0d31547074ef4ed0f95e5b347b2007c6eaf
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 3b82fb3753b217945329a2138ed9e6df69f7ba0c
core/src/test/scala/unit/kafka/producer/ProducerTest.scala a7ca14227edd8ca1a65122350fe4740d455f0c5c
core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala 48d3143b669430949b08bf81656e533172be530f
core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala 142e28ee20d5953a9827a5bd97db1e3eb35bf81d
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala ca46ba9b2fa8176f6c7a414b7a611e0afe0ff2ba
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala d9bdcefb209afc3084b23b6a2cb123e9d3c7d462
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 496bf0ddfc2e7872dc187ad85de5e845c6258604
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 92e49df6964230753762aa359191a6ede337d3ac
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala a6bb69059b548bea3ebefa2a3146600163bcfa4b
core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala 2bfaeb307094b0fba67a1976b7f87591ca36a45c
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala a20321f89defdb3426e159f6c376d4d2194092c2
core/src/test/scala/unit/kafka/server/ServerStartupTest.scala 661ddd504fc4cdccbd5eb129212911296f4102b0
core/src/test/scala/unit/kafka/utils/TestUtils.scala a8ed1422ef11737f61fe0b62629e7244c0c11677
core/src/test/scala/unit/kafka/utils/UtilsTest.scala 8c3797a964a2760a00ed60530d1a48e3da473769
core/src/test/scala/unit/kafka/zk/EmbeddedZookeeper.scala 1d87506649f0d1f73a2ea5465339dc586900b626
core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala fedefb5287eaf8e0d1ee585a8dd31687bdcf9d88
Diff: https://reviews.apache.org/r/32740/diff/
Testing
-------
Thanks,
Tong Li
Re: Review Request 32740: Patch for KAFKA-1926
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32740/#review78858
-----------------------------------------------------------
Thanks for the new patch. Just a couple of more minor comments.
Also, we plan to commit KAFKA-1809 first. Could you rebase after that?
clients/src/main/java/org/apache/kafka/common/utils/Utils.java
<https://reviews.apache.org/r/32740/#comment127932>
It would be useful to add a wrapper method readFileAsString(String path) that uses the default Charset. Then, many callers don't have to pass in null for charset.
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
<https://reviews.apache.org/r/32740/#comment127933>
Do we still need to do the casting to byte[]?
- Jun Rao
On April 2, 2015, 2:16 a.m., Tong Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32740/
> -----------------------------------------------------------
>
> (Updated April 2, 2015, 2:16 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1926
> https://issues.apache.org/jira/browse/KAFKA-1926
>
>
> Repository: kafka
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/common/utils/Utils.java 920b51a6c3c99639fbc9dc065637eeee3c19fabd
> clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java c899813d55b9c4786adde3d840f040d6645d27c8
> core/src/main/scala/kafka/Kafka.scala 37de7df059829f40300aa5f920219b869f9c7f78
> core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb
> core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 79b5e0aeb4af77d356f80107685cd9a7d508ef16
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
> core/src/main/scala/kafka/admin/TopicCommand.scala f400b71f8444fffd3fc1d8398a283682390eba4e
> core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
> core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6
> core/src/main/scala/kafka/cluster/Partition.scala c4bf48a801007ebe7497077d2018d6dffe1677d4
> core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068
> core/src/main/scala/kafka/consumer/ConsumerIterator.scala b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5
> core/src/main/scala/kafka/consumer/PartitionAssignor.scala bc2e5b40e29659b8902b65a3234d6b53d8b1aa75
> core/src/main/scala/kafka/consumer/TopicCount.scala 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala b1cf0db8741e384e4e4119751058ea87b2589e57
> core/src/main/scala/kafka/controller/ControllerChannelManager.scala c582191636f6188c25d62a67ff0315b56f163133
> core/src/main/scala/kafka/controller/KafkaController.scala 09fc46d759b74bcdad2d2a610d9c5a93ff02423f
> core/src/main/scala/kafka/controller/PartitionStateMachine.scala 2f0694bc5cdfc763f4872d58bec925d0cf919da1
> core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 3e87e1d36f87b7dd539a474609b1c95487a4c337
> core/src/main/scala/kafka/controller/TopicDeletionManager.scala e56f22d7399061a72aa67a9ee73ea4d91345c01f
> core/src/main/scala/kafka/log/FileMessageSet.scala b2652ddbe2f857028d5980e29a008b2c614694a3
> core/src/main/scala/kafka/log/Log.scala 06b8ecc5d11a1acfbaf3c693c42bf3ce5b2cd86d
> core/src/main/scala/kafka/log/LogCleanerManager.scala 351824b3c9fabe0942528147bdde8cee13b63e20
> core/src/main/scala/kafka/log/LogConfig.scala 8b67aee3a37765178b30d79e9e7bb882bdc89c29
> core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d
> core/src/main/scala/kafka/log/LogSegment.scala 02567649dd82309011ba2ac6dceda97683e4f5ed
> core/src/main/scala/kafka/log/OffsetIndex.scala ca82c043bb8413b1e010c40de9db1b6dae85e3ac
> core/src/main/scala/kafka/log/OffsetMap.scala 42cdfbb6100b5c89d86144f92f661ebd844b2132
> core/src/main/scala/kafka/message/Message.scala d3024807a84e104e6a28a29c957f4b964d8dd416
> core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d
> core/src/main/scala/kafka/message/MessageWriter.scala 7eb72cbdc37de55875d8263aae5bb166d977a491
> core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala ea9559f822c1120e1997916190fcd597328e4965
> core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala 84f6208610e09943e984b54c07b8d287945574f8
> core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala 14e46244ee27c8c99f33852cf03bb907cebafa51
> core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75
> core/src/main/scala/kafka/network/SocketServer.scala 76ce41aed6e04ac5ba88395c4d5008aca17f9a73
> core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 6a3b02e414eb7d62cfaece3344245feac54cecda
> core/src/main/scala/kafka/producer/DefaultPartitioner.scala 3afb22eeb4e3b8ecf49e92bd167f2f67b8f6a961
> core/src/main/scala/kafka/producer/Producer.scala e38d2fa7ec873677cc23b94092ddcd55baf1a3a2
> core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255
> core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 821901e4f434dfd9eec6eceabfc2e1e65507a57c
> core/src/main/scala/kafka/server/AbstractFetcherManager.scala 20c00cb8cc2351950edbc8cb1752905a0c26e79f
> core/src/main/scala/kafka/server/AbstractFetcherThread.scala 5d5cf5897cc37b3595f14bfe9d7cde43456bcc4b
> core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala 0e542ff0cc3eda1cbcef621e73e404c56f092862
> core/src/main/scala/kafka/server/KafkaConfig.scala 422451aec5ea0442eb2e4c1ae772885b813904a9
> core/src/main/scala/kafka/server/KafkaRequestHandler.scala 4d86bdf5d146d193858005e7ecadd6e322ca2e20
> core/src/main/scala/kafka/server/KafkaServer.scala 4db3384545be8c237d6fc9646716ab67d5193ec5
> core/src/main/scala/kafka/server/MetadataCache.scala 6aef6e4508ecadbbcc1e12bed2054547b7aa333e
> core/src/main/scala/kafka/server/OffsetManager.scala 395b1dbe43a5db47151e72a1b588d72f03cef963
> core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala a75818a724ff3492f640eec7a57f596324ce6c03
> core/src/main/scala/kafka/tools/ConsoleConsumer.scala 910691e88ccc66a1542d0ea85bb2f732861d805e
> core/src/main/scala/kafka/tools/DumpLogSegments.scala b7a3630834c8e2c4740e56ac16cc9dfa42554f93
> core/src/main/scala/kafka/tools/KafkaMigrationTool.java 026d8198678d3e3e41feddcdaa53b67dad5c0e64
> core/src/main/scala/kafka/tools/MirrorMaker.scala ec077434cac25a10e4f59b9aa569581a2776b2a3
> core/src/main/scala/kafka/tools/SimpleConsumerShell.scala b4f903b6c7c3bb725cac7c05eb1f885906413c4d
> core/src/main/scala/kafka/tools/StateChangeLogMerger.scala b34b8c7d7d4caaab230719a67048310e0fbb3280
> core/src/main/scala/kafka/tools/TestEndToEndLatency.scala 48cff20e760a9797ad64ef2a5a28e07e2951f096
> core/src/main/scala/kafka/tools/TestLogCleaning.scala af496f7c547a5ac7a4096a6af325dad0d8feec6f
> core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala 111c9a8b94ce45d95551482e9fd3f8c1cccbf548
> core/src/main/scala/kafka/utils/CoreUtils.scala PRE-CREATION
> core/src/main/scala/kafka/utils/Crc32.java 0e0e7bcb33886f47b9770a122d00d6eafdbb89a9
> core/src/main/scala/kafka/utils/KafkaScheduler.scala 7ceadccefe8206440ab1218a0e7cc36f1307e85a
> core/src/main/scala/kafka/utils/Log4jController.scala a015c8109f050cabdea988f2215bd01ec0d8573a
> core/src/main/scala/kafka/utils/Logging.scala 2890e7f51ddcb056672b30047b7b1df84a5b8df9
> core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
> core/src/main/scala/kafka/utils/VerifiableProperties.scala 2ffc7f452dc7a1b6a06ca7a509ed49e1ab3d1e68
> core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala cae72f4f87f10b843c29dc731c6e0028b1d50734
> core/src/test/scala/kafka/tools/TestEndToEndLatency.scala PRE-CREATION
> core/src/test/scala/kafka/tools/TestLogCleaning.scala PRE-CREATION
> core/src/test/scala/other/kafka/DeleteZKPath.scala 25545037517b127911cedc39419194535a75be8a
> core/src/test/scala/other/kafka/StressTestLog.scala e19b8b28383554512a0c1f651d6764650d8db9c4
> core/src/test/scala/other/kafka/TestCrcPerformance.scala 42e3c62055c1562d3a1cee4c8374ae2559a55be7
> core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala 7211c2529c1db76100432737da7a1d1d221dfba0
> core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 8bc178505e00932a316c46ed1d904bd57b5b3f75
> core/src/test/scala/unit/kafka/admin/AdminTest.scala ee0b21e6a94ad79c11dd08f6e5adf98c333e2ec9
> core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala 995397ba2e2dfc6fadd9d5c5efd90f2c4ac0d59c
> core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 062790f15d4ab6e0ee7a98bef12aaa2b22da3bfa
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 30deaf47b64592f2e1cc84a4156671fac11b67ef
> core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala 4d27e41c727e73544b2b214a0a0b60f6acdbfd17
> core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala 8342cae564ebc39fe74a512343a4523072ca205a
> core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala fa4a8ad0acc9e8eca8f2e035ec7fe9bb24d8589a
> core/src/test/scala/unit/kafka/log/CleanerTest.scala a4da95f765e5778c896551ecef0e0eaef5167ae1
> core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 07acd460b1259e0a3f4069b8b8dcd8123ef5810e
> core/src/test/scala/unit/kafka/log/LogManagerTest.scala 90cd53033fafaf952ba0b3f1e28b0e1f1ad3ea76
> core/src/test/scala/unit/kafka/log/LogTest.scala 3c0599cc2ea12566fbec8233e3a73b31854b3b38
> core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 36db9172ea2d4d7e242e023ba914596c1f64f5f4
> core/src/test/scala/unit/kafka/message/MessageTest.scala 7b74a0d31547074ef4ed0f95e5b347b2007c6eaf
> core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala be90c5bc7f1f5ba8a237d1c7176f27029727c918
> core/src/test/scala/unit/kafka/producer/ProducerTest.scala d2f3851cb68ff595bbb859d27b3552e751d060bb
> core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala 296e2b563041318d360db4037411879613a63968
> core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala 0bdbc2f31fcac2abdeff4e41e448a7b9ab13b95b
> core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala f2528059dd86bb051d1ce9d72039cde3b78b8817
> core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 8c9f9e748e888da6035755c9f4241ac3aa0500c9
> core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
> core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 7654275c5437e1db319f01a8d587d66b42ea8dc7
> core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala 96a8a5a8cb1f40f743490f85bf18d441ce86a765
> core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 71317eb46b8d76060b115e6c1d31a4653459724f
> core/src/test/scala/unit/kafka/server/ServerStartupTest.scala 60021ef8d8d7fa172d6b160db48ee5eb9574e1a9
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 1682a77362123449de6bb1d54a55887409990a24
> core/src/test/scala/unit/kafka/utils/UtilsTest.scala 8c3797a964a2760a00ed60530d1a48e3da473769
> core/src/test/scala/unit/kafka/zk/EmbeddedZookeeper.scala 31515615089385c722325bfe019a47ae3a9a4052
> core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala 67d9c4bab270c852dc05d47aaa4dd96b0f6039d4
>
> Diff: https://reviews.apache.org/r/32740/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tong Li
>
>
Re: Review Request 32740: Patch for KAFKA-1926
Posted by Tong Li <li...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32740/
-----------------------------------------------------------
(Updated April 2, 2015, 2:16 a.m.)
Review request for kafka.
Bugs: KAFKA-1926
https://issues.apache.org/jira/browse/KAFKA-1926
Repository: kafka
Description
-------
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/common/utils/Utils.java 920b51a6c3c99639fbc9dc065637eeee3c19fabd
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java c899813d55b9c4786adde3d840f040d6645d27c8
core/src/main/scala/kafka/Kafka.scala 37de7df059829f40300aa5f920219b869f9c7f78
core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb
core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 79b5e0aeb4af77d356f80107685cd9a7d508ef16
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
core/src/main/scala/kafka/admin/TopicCommand.scala f400b71f8444fffd3fc1d8398a283682390eba4e
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6
core/src/main/scala/kafka/cluster/Partition.scala c4bf48a801007ebe7497077d2018d6dffe1677d4
core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068
core/src/main/scala/kafka/consumer/ConsumerIterator.scala b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5
core/src/main/scala/kafka/consumer/PartitionAssignor.scala bc2e5b40e29659b8902b65a3234d6b53d8b1aa75
core/src/main/scala/kafka/consumer/TopicCount.scala 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala b1cf0db8741e384e4e4119751058ea87b2589e57
core/src/main/scala/kafka/controller/ControllerChannelManager.scala c582191636f6188c25d62a67ff0315b56f163133
core/src/main/scala/kafka/controller/KafkaController.scala 09fc46d759b74bcdad2d2a610d9c5a93ff02423f
core/src/main/scala/kafka/controller/PartitionStateMachine.scala 2f0694bc5cdfc763f4872d58bec925d0cf919da1
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 3e87e1d36f87b7dd539a474609b1c95487a4c337
core/src/main/scala/kafka/controller/TopicDeletionManager.scala e56f22d7399061a72aa67a9ee73ea4d91345c01f
core/src/main/scala/kafka/log/FileMessageSet.scala b2652ddbe2f857028d5980e29a008b2c614694a3
core/src/main/scala/kafka/log/Log.scala 06b8ecc5d11a1acfbaf3c693c42bf3ce5b2cd86d
core/src/main/scala/kafka/log/LogCleanerManager.scala 351824b3c9fabe0942528147bdde8cee13b63e20
core/src/main/scala/kafka/log/LogConfig.scala 8b67aee3a37765178b30d79e9e7bb882bdc89c29
core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d
core/src/main/scala/kafka/log/LogSegment.scala 02567649dd82309011ba2ac6dceda97683e4f5ed
core/src/main/scala/kafka/log/OffsetIndex.scala ca82c043bb8413b1e010c40de9db1b6dae85e3ac
core/src/main/scala/kafka/log/OffsetMap.scala 42cdfbb6100b5c89d86144f92f661ebd844b2132
core/src/main/scala/kafka/message/Message.scala d3024807a84e104e6a28a29c957f4b964d8dd416
core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d
core/src/main/scala/kafka/message/MessageWriter.scala 7eb72cbdc37de55875d8263aae5bb166d977a491
core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala ea9559f822c1120e1997916190fcd597328e4965
core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala 84f6208610e09943e984b54c07b8d287945574f8
core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala 14e46244ee27c8c99f33852cf03bb907cebafa51
core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75
core/src/main/scala/kafka/network/SocketServer.scala 76ce41aed6e04ac5ba88395c4d5008aca17f9a73
core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 6a3b02e414eb7d62cfaece3344245feac54cecda
core/src/main/scala/kafka/producer/DefaultPartitioner.scala 3afb22eeb4e3b8ecf49e92bd167f2f67b8f6a961
core/src/main/scala/kafka/producer/Producer.scala e38d2fa7ec873677cc23b94092ddcd55baf1a3a2
core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255
core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 821901e4f434dfd9eec6eceabfc2e1e65507a57c
core/src/main/scala/kafka/server/AbstractFetcherManager.scala 20c00cb8cc2351950edbc8cb1752905a0c26e79f
core/src/main/scala/kafka/server/AbstractFetcherThread.scala 5d5cf5897cc37b3595f14bfe9d7cde43456bcc4b
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala 0e542ff0cc3eda1cbcef621e73e404c56f092862
core/src/main/scala/kafka/server/KafkaConfig.scala 422451aec5ea0442eb2e4c1ae772885b813904a9
core/src/main/scala/kafka/server/KafkaRequestHandler.scala 4d86bdf5d146d193858005e7ecadd6e322ca2e20
core/src/main/scala/kafka/server/KafkaServer.scala 4db3384545be8c237d6fc9646716ab67d5193ec5
core/src/main/scala/kafka/server/MetadataCache.scala 6aef6e4508ecadbbcc1e12bed2054547b7aa333e
core/src/main/scala/kafka/server/OffsetManager.scala 395b1dbe43a5db47151e72a1b588d72f03cef963
core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala a75818a724ff3492f640eec7a57f596324ce6c03
core/src/main/scala/kafka/tools/ConsoleConsumer.scala 910691e88ccc66a1542d0ea85bb2f732861d805e
core/src/main/scala/kafka/tools/DumpLogSegments.scala b7a3630834c8e2c4740e56ac16cc9dfa42554f93
core/src/main/scala/kafka/tools/KafkaMigrationTool.java 026d8198678d3e3e41feddcdaa53b67dad5c0e64
core/src/main/scala/kafka/tools/MirrorMaker.scala ec077434cac25a10e4f59b9aa569581a2776b2a3
core/src/main/scala/kafka/tools/SimpleConsumerShell.scala b4f903b6c7c3bb725cac7c05eb1f885906413c4d
core/src/main/scala/kafka/tools/StateChangeLogMerger.scala b34b8c7d7d4caaab230719a67048310e0fbb3280
core/src/main/scala/kafka/tools/TestEndToEndLatency.scala 48cff20e760a9797ad64ef2a5a28e07e2951f096
core/src/main/scala/kafka/tools/TestLogCleaning.scala af496f7c547a5ac7a4096a6af325dad0d8feec6f
core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala 111c9a8b94ce45d95551482e9fd3f8c1cccbf548
core/src/main/scala/kafka/utils/CoreUtils.scala PRE-CREATION
core/src/main/scala/kafka/utils/Crc32.java 0e0e7bcb33886f47b9770a122d00d6eafdbb89a9
core/src/main/scala/kafka/utils/KafkaScheduler.scala 7ceadccefe8206440ab1218a0e7cc36f1307e85a
core/src/main/scala/kafka/utils/Log4jController.scala a015c8109f050cabdea988f2215bd01ec0d8573a
core/src/main/scala/kafka/utils/Logging.scala 2890e7f51ddcb056672b30047b7b1df84a5b8df9
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/main/scala/kafka/utils/VerifiableProperties.scala 2ffc7f452dc7a1b6a06ca7a509ed49e1ab3d1e68
core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala cae72f4f87f10b843c29dc731c6e0028b1d50734
core/src/test/scala/kafka/tools/TestEndToEndLatency.scala PRE-CREATION
core/src/test/scala/kafka/tools/TestLogCleaning.scala PRE-CREATION
core/src/test/scala/other/kafka/DeleteZKPath.scala 25545037517b127911cedc39419194535a75be8a
core/src/test/scala/other/kafka/StressTestLog.scala e19b8b28383554512a0c1f651d6764650d8db9c4
core/src/test/scala/other/kafka/TestCrcPerformance.scala 42e3c62055c1562d3a1cee4c8374ae2559a55be7
core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala 7211c2529c1db76100432737da7a1d1d221dfba0
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 8bc178505e00932a316c46ed1d904bd57b5b3f75
core/src/test/scala/unit/kafka/admin/AdminTest.scala ee0b21e6a94ad79c11dd08f6e5adf98c333e2ec9
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala 995397ba2e2dfc6fadd9d5c5efd90f2c4ac0d59c
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 062790f15d4ab6e0ee7a98bef12aaa2b22da3bfa
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 30deaf47b64592f2e1cc84a4156671fac11b67ef
core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala 4d27e41c727e73544b2b214a0a0b60f6acdbfd17
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala 8342cae564ebc39fe74a512343a4523072ca205a
core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala fa4a8ad0acc9e8eca8f2e035ec7fe9bb24d8589a
core/src/test/scala/unit/kafka/log/CleanerTest.scala a4da95f765e5778c896551ecef0e0eaef5167ae1
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 07acd460b1259e0a3f4069b8b8dcd8123ef5810e
core/src/test/scala/unit/kafka/log/LogManagerTest.scala 90cd53033fafaf952ba0b3f1e28b0e1f1ad3ea76
core/src/test/scala/unit/kafka/log/LogTest.scala 3c0599cc2ea12566fbec8233e3a73b31854b3b38
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 36db9172ea2d4d7e242e023ba914596c1f64f5f4
core/src/test/scala/unit/kafka/message/MessageTest.scala 7b74a0d31547074ef4ed0f95e5b347b2007c6eaf
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala be90c5bc7f1f5ba8a237d1c7176f27029727c918
core/src/test/scala/unit/kafka/producer/ProducerTest.scala d2f3851cb68ff595bbb859d27b3552e751d060bb
core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala 296e2b563041318d360db4037411879613a63968
core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala 0bdbc2f31fcac2abdeff4e41e448a7b9ab13b95b
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala f2528059dd86bb051d1ce9d72039cde3b78b8817
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 8c9f9e748e888da6035755c9f4241ac3aa0500c9
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 7654275c5437e1db319f01a8d587d66b42ea8dc7
core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala 96a8a5a8cb1f40f743490f85bf18d441ce86a765
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 71317eb46b8d76060b115e6c1d31a4653459724f
core/src/test/scala/unit/kafka/server/ServerStartupTest.scala 60021ef8d8d7fa172d6b160db48ee5eb9574e1a9
core/src/test/scala/unit/kafka/utils/TestUtils.scala 1682a77362123449de6bb1d54a55887409990a24
core/src/test/scala/unit/kafka/utils/UtilsTest.scala 8c3797a964a2760a00ed60530d1a48e3da473769
core/src/test/scala/unit/kafka/zk/EmbeddedZookeeper.scala 31515615089385c722325bfe019a47ae3a9a4052
core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala 67d9c4bab270c852dc05d47aaa4dd96b0f6039d4
Diff: https://reviews.apache.org/r/32740/diff/
Testing
-------
Thanks,
Tong Li
Re: Review Request 32740: Patch for KAFKA-1926
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32740/#review78580
-----------------------------------------------------------
Thanks for the new patch. A few more comments.
clients/src/main/java/org/apache/kafka/common/utils/Utils.java
<https://reviews.apache.org/r/32740/#comment127460>
We don't need to convert byte[] to Array[Byte]. They are the same and scala understands byte[].
scala> def foo(a: Array[Byte]) { println(a.length);}
foo: (a: Array[Byte])Unit
scala> foo("abc".getBytes())
3
core/src/main/scala/kafka/cluster/Broker.scala
<https://reviews.apache.org/r/32740/#comment127474>
We don't need to override equals and hashcode since Broker is defined as a case class, which will do the right thing for equals and hashcode.
core/src/main/scala/kafka/utils/CoreUtils.scala
<https://reviews.apache.org/r/32740/#comment127476>
Should we remove these?
core/src/main/scala/kafka/utils/CoreUtils.scala
<https://reviews.apache.org/r/32740/#comment127475>
Should we remove this?
core/src/main/scala/kafka/utils/CoreUtils.scala
<https://reviews.apache.org/r/32740/#comment127477>
These are no longer needed, right?
core/src/main/scala/kafka/utils/CoreUtils.scala
<https://reviews.apache.org/r/32740/#comment127483>
It seems that this can be moved the java util as well.
core/src/test/scala/kafka/tools/TestEndToEndLatency.scala
<https://reviews.apache.org/r/32740/#comment127479>
The package is incorrect. Could you build the test jar?
- Jun Rao
On April 1, 2015, 7:26 p.m., Tong Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32740/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 7:26 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1926
> https://issues.apache.org/jira/browse/KAFKA-1926
>
>
> Repository: kafka
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/common/utils/Utils.java 920b51a6c3c99639fbc9dc065637eeee3c19fabd
> clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java c899813d55b9c4786adde3d840f040d6645d27c8
> core/src/main/scala/kafka/Kafka.scala 37de7df059829f40300aa5f920219b869f9c7f78
> core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb
> core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 79b5e0aeb4af77d356f80107685cd9a7d508ef16
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
> core/src/main/scala/kafka/admin/TopicCommand.scala f400b71f8444fffd3fc1d8398a283682390eba4e
> core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
> core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6
> core/src/main/scala/kafka/cluster/Partition.scala c4bf48a801007ebe7497077d2018d6dffe1677d4
> core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068
> core/src/main/scala/kafka/consumer/ConsumerIterator.scala b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5
> core/src/main/scala/kafka/consumer/PartitionAssignor.scala bc2e5b40e29659b8902b65a3234d6b53d8b1aa75
> core/src/main/scala/kafka/consumer/TopicCount.scala 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala b1cf0db8741e384e4e4119751058ea87b2589e57
> core/src/main/scala/kafka/controller/ControllerChannelManager.scala c582191636f6188c25d62a67ff0315b56f163133
> core/src/main/scala/kafka/controller/KafkaController.scala 09fc46d759b74bcdad2d2a610d9c5a93ff02423f
> core/src/main/scala/kafka/controller/PartitionStateMachine.scala 2f0694bc5cdfc763f4872d58bec925d0cf919da1
> core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 3e87e1d36f87b7dd539a474609b1c95487a4c337
> core/src/main/scala/kafka/controller/TopicDeletionManager.scala e56f22d7399061a72aa67a9ee73ea4d91345c01f
> core/src/main/scala/kafka/log/FileMessageSet.scala b2652ddbe2f857028d5980e29a008b2c614694a3
> core/src/main/scala/kafka/log/Log.scala 06b8ecc5d11a1acfbaf3c693c42bf3ce5b2cd86d
> core/src/main/scala/kafka/log/LogCleanerManager.scala 351824b3c9fabe0942528147bdde8cee13b63e20
> core/src/main/scala/kafka/log/LogConfig.scala 8b67aee3a37765178b30d79e9e7bb882bdc89c29
> core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d
> core/src/main/scala/kafka/log/LogSegment.scala 02567649dd82309011ba2ac6dceda97683e4f5ed
> core/src/main/scala/kafka/log/OffsetIndex.scala ca82c043bb8413b1e010c40de9db1b6dae85e3ac
> core/src/main/scala/kafka/log/OffsetMap.scala 42cdfbb6100b5c89d86144f92f661ebd844b2132
> core/src/main/scala/kafka/message/Message.scala d3024807a84e104e6a28a29c957f4b964d8dd416
> core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d
> core/src/main/scala/kafka/message/MessageWriter.scala 7eb72cbdc37de55875d8263aae5bb166d977a491
> core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala ea9559f822c1120e1997916190fcd597328e4965
> core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala 84f6208610e09943e984b54c07b8d287945574f8
> core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala 14e46244ee27c8c99f33852cf03bb907cebafa51
> core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75
> core/src/main/scala/kafka/network/SocketServer.scala 76ce41aed6e04ac5ba88395c4d5008aca17f9a73
> core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 6a3b02e414eb7d62cfaece3344245feac54cecda
> core/src/main/scala/kafka/producer/DefaultPartitioner.scala 3afb22eeb4e3b8ecf49e92bd167f2f67b8f6a961
> core/src/main/scala/kafka/producer/Producer.scala e38d2fa7ec873677cc23b94092ddcd55baf1a3a2
> core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255
> core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 821901e4f434dfd9eec6eceabfc2e1e65507a57c
> core/src/main/scala/kafka/server/AbstractFetcherManager.scala 20c00cb8cc2351950edbc8cb1752905a0c26e79f
> core/src/main/scala/kafka/server/AbstractFetcherThread.scala 5d5cf5897cc37b3595f14bfe9d7cde43456bcc4b
> core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala 0e542ff0cc3eda1cbcef621e73e404c56f092862
> core/src/main/scala/kafka/server/KafkaConfig.scala 422451aec5ea0442eb2e4c1ae772885b813904a9
> core/src/main/scala/kafka/server/KafkaRequestHandler.scala 4d86bdf5d146d193858005e7ecadd6e322ca2e20
> core/src/main/scala/kafka/server/KafkaServer.scala 4db3384545be8c237d6fc9646716ab67d5193ec5
> core/src/main/scala/kafka/server/MetadataCache.scala 6aef6e4508ecadbbcc1e12bed2054547b7aa333e
> core/src/main/scala/kafka/server/OffsetManager.scala 395b1dbe43a5db47151e72a1b588d72f03cef963
> core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala a75818a724ff3492f640eec7a57f596324ce6c03
> core/src/main/scala/kafka/tools/ConsoleConsumer.scala 910691e88ccc66a1542d0ea85bb2f732861d805e
> core/src/main/scala/kafka/tools/DumpLogSegments.scala b7a3630834c8e2c4740e56ac16cc9dfa42554f93
> core/src/main/scala/kafka/tools/KafkaMigrationTool.java 026d8198678d3e3e41feddcdaa53b67dad5c0e64
> core/src/main/scala/kafka/tools/MirrorMaker.scala ec077434cac25a10e4f59b9aa569581a2776b2a3
> core/src/main/scala/kafka/tools/SimpleConsumerShell.scala b4f903b6c7c3bb725cac7c05eb1f885906413c4d
> core/src/main/scala/kafka/tools/StateChangeLogMerger.scala b34b8c7d7d4caaab230719a67048310e0fbb3280
> core/src/main/scala/kafka/tools/TestEndToEndLatency.scala 48cff20e760a9797ad64ef2a5a28e07e2951f096
> core/src/main/scala/kafka/tools/TestLogCleaning.scala af496f7c547a5ac7a4096a6af325dad0d8feec6f
> core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala 111c9a8b94ce45d95551482e9fd3f8c1cccbf548
> core/src/main/scala/kafka/utils/CoreUtils.scala PRE-CREATION
> core/src/main/scala/kafka/utils/Crc32.java 0e0e7bcb33886f47b9770a122d00d6eafdbb89a9
> core/src/main/scala/kafka/utils/KafkaScheduler.scala 7ceadccefe8206440ab1218a0e7cc36f1307e85a
> core/src/main/scala/kafka/utils/Log4jController.scala a015c8109f050cabdea988f2215bd01ec0d8573a
> core/src/main/scala/kafka/utils/Logging.scala 2890e7f51ddcb056672b30047b7b1df84a5b8df9
> core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
> core/src/main/scala/kafka/utils/VerifiableProperties.scala 2ffc7f452dc7a1b6a06ca7a509ed49e1ab3d1e68
> core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala cae72f4f87f10b843c29dc731c6e0028b1d50734
> core/src/test/scala/kafka/tools/TestEndToEndLatency.scala PRE-CREATION
> core/src/test/scala/kafka/tools/TestLogCleaning.scala PRE-CREATION
> core/src/test/scala/other/kafka/DeleteZKPath.scala 25545037517b127911cedc39419194535a75be8a
> core/src/test/scala/other/kafka/StressTestLog.scala e19b8b28383554512a0c1f651d6764650d8db9c4
> core/src/test/scala/other/kafka/TestCrcPerformance.scala 42e3c62055c1562d3a1cee4c8374ae2559a55be7
> core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala 7211c2529c1db76100432737da7a1d1d221dfba0
> core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 8bc178505e00932a316c46ed1d904bd57b5b3f75
> core/src/test/scala/unit/kafka/admin/AdminTest.scala ee0b21e6a94ad79c11dd08f6e5adf98c333e2ec9
> core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala 995397ba2e2dfc6fadd9d5c5efd90f2c4ac0d59c
> core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 062790f15d4ab6e0ee7a98bef12aaa2b22da3bfa
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 30deaf47b64592f2e1cc84a4156671fac11b67ef
> core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala 4d27e41c727e73544b2b214a0a0b60f6acdbfd17
> core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala 8342cae564ebc39fe74a512343a4523072ca205a
> core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala fa4a8ad0acc9e8eca8f2e035ec7fe9bb24d8589a
> core/src/test/scala/unit/kafka/log/CleanerTest.scala a4da95f765e5778c896551ecef0e0eaef5167ae1
> core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 07acd460b1259e0a3f4069b8b8dcd8123ef5810e
> core/src/test/scala/unit/kafka/log/LogManagerTest.scala 90cd53033fafaf952ba0b3f1e28b0e1f1ad3ea76
> core/src/test/scala/unit/kafka/log/LogTest.scala 3c0599cc2ea12566fbec8233e3a73b31854b3b38
> core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 36db9172ea2d4d7e242e023ba914596c1f64f5f4
> core/src/test/scala/unit/kafka/message/MessageTest.scala 7b74a0d31547074ef4ed0f95e5b347b2007c6eaf
> core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala be90c5bc7f1f5ba8a237d1c7176f27029727c918
> core/src/test/scala/unit/kafka/producer/ProducerTest.scala d2f3851cb68ff595bbb859d27b3552e751d060bb
> core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala 296e2b563041318d360db4037411879613a63968
> core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala 0bdbc2f31fcac2abdeff4e41e448a7b9ab13b95b
> core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala f2528059dd86bb051d1ce9d72039cde3b78b8817
> core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 8c9f9e748e888da6035755c9f4241ac3aa0500c9
> core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
> core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 7654275c5437e1db319f01a8d587d66b42ea8dc7
> core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala 96a8a5a8cb1f40f743490f85bf18d441ce86a765
> core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 71317eb46b8d76060b115e6c1d31a4653459724f
> core/src/test/scala/unit/kafka/server/ServerStartupTest.scala 60021ef8d8d7fa172d6b160db48ee5eb9574e1a9
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 1682a77362123449de6bb1d54a55887409990a24
> core/src/test/scala/unit/kafka/utils/UtilsTest.scala 8c3797a964a2760a00ed60530d1a48e3da473769
> core/src/test/scala/unit/kafka/zk/EmbeddedZookeeper.scala 31515615089385c722325bfe019a47ae3a9a4052
> core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala 67d9c4bab270c852dc05d47aaa4dd96b0f6039d4
>
> Diff: https://reviews.apache.org/r/32740/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tong Li
>
>