[GitHub] [pinot] walterddr commented on a diff in pull request #9927: [DRAFT] check aggregate functions for type safety before running query

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9927:
URL: https://github.com/apache/pinot/pull/9927#discussion_r1042576582


##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##########
@@ -104,6 +104,19 @@ public void getColumns(Set<String> columns) {
     }
   }
 
+  public <T> T visit(ExpressionContextVisitor<T> visitor) {

Review Comment:
   i felt the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org