You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/01 07:16:58 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #7120: Close producer without state check while the topic does not exists.

codelipenghui opened a new pull request #7120:
URL: https://github.com/apache/pulsar/pull/7120


   Fixes #6838 related to #6879
   
   ### Motivation
   
   Close producer without state check while the topic does not exists. The problem is the `State` of the producer failed to pass the check condition so that the producer can't be closed. If TopicDoesNotExsitsException happens on a producer, we can directly close this producer without state checking for the producer.
   
   ### Verifying this change
   
   Improve the test
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #7120: Close producer without state check while the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7120:
URL: https://github.com/apache/pulsar/pull/7120


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #7120: Close producer without state check while the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7120:
URL: https://github.com/apache/pulsar/pull/7120#issuecomment-637361289


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devprashantksinha commented on pull request #7120: Close producer without state check while the topic does not exists.

Posted by GitBox <gi...@apache.org>.
devprashantksinha commented on pull request #7120:
URL: https://github.com/apache/pulsar/pull/7120#issuecomment-638796599


   @codelipenghui @sijie  : When is 2.5.3. release is planned ? Can you please share with us.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devprashantksinha edited a comment on pull request #7120: Close producer without state check while the topic does not exists.

Posted by GitBox <gi...@apache.org>.
devprashantksinha edited a comment on pull request #7120:
URL: https://github.com/apache/pulsar/pull/7120#issuecomment-638796599


   @codelipenghui @sijie  : When is 2.5.3. release planned ? Can you please share with us.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #7120: Close producer without state check while the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7120:
URL: https://github.com/apache/pulsar/pull/7120#issuecomment-637432716


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org