You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "crossoverJie (via GitHub)" <gi...@apache.org> on 2023/06/25 14:33:24 UTC

[GitHub] [pulsar-client-go] crossoverJie opened a new pull request, #1037: Fix openjdk-17

crossoverJie opened a new pull request, #1037:
URL: https://github.com/apache/pulsar-client-go/pull/1037

   
   ### Motivation
   
   The master branch is broken:
   ```
   head: cannot open '/etc/ssl/certs/java/cacerts' for reading: No such file or directory
   Exception in thread "main" java.lang.InternalError: Error loading java.security file
   ```
   
   See https://github.com/apache/pulsar-client-go/actions/runs/5274623023/jobs/9543594971?pr=1029
   
   ### Modifications
   
   Use `openjdk-17-jre` to replace `openjdk-17-jre-headless`.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   https://github.com/crossoverJie/pulsar-client-go/pull/4
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] RobertIndie commented on a diff in pull request #1037: Fix openjdk-17

Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on code in PR #1037:
URL: https://github.com/apache/pulsar-client-go/pull/1037#discussion_r1241389468


##########
Dockerfile:
##########
@@ -25,7 +25,7 @@ ARG GOLANG_IMAGE=golang:latest
 FROM $PULSAR_IMAGE as pulsar
 FROM $GOLANG_IMAGE
 
-RUN apt-get update && apt-get install -y openjdk-17-jre-headless ca-certificates
+RUN apt-get update && apt-get install -y openjdk-17-jre ca-certificates

Review Comment:
   ```suggestion
   RUN apt-get update && apt-get install -y ca-certificates openjdk-17-jre-headless 
   ```
   
   According to https://bugs.launchpad.net/ubuntu/+source/ca-certificates-java/+bug/1998065, how about trying to install ca-certificates-java before java.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] crossoverJie commented on a diff in pull request #1037: Fix openjdk-17

Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie commented on code in PR #1037:
URL: https://github.com/apache/pulsar-client-go/pull/1037#discussion_r1241444583


##########
Dockerfile:
##########
@@ -25,7 +25,7 @@ ARG GOLANG_IMAGE=golang:latest
 FROM $PULSAR_IMAGE as pulsar
 FROM $GOLANG_IMAGE
 
-RUN apt-get update && apt-get install -y openjdk-17-jre-headless ca-certificates
+RUN apt-get update && apt-get install -y openjdk-17-jre ca-certificates

Review Comment:
   > According to [bugs.launchpad.net/ubuntu/+source/ca-certificates-java/+bug/1998065](https://bugs.launchpad.net/ubuntu/+source/ca-certificates-java/+bug/1998065), how about trying to install ca-certificates-java before java.
   
   https://github.com/crossoverJie/pulsar-client-go/actions/runs/5373160775/jobs/9747260724?pr=5
   
   ```
   RUN apt-get update && apt-get install -y ca-certificates-java openjdk-17-jre-headless
   RUN apt-get update && apt-get install -y ca-certificates openjdk-17-jre-headless
   ```
   
   Neither of those methods worked.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] nodece commented on a diff in pull request #1037: Fix openjdk-17

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on code in PR #1037:
URL: https://github.com/apache/pulsar-client-go/pull/1037#discussion_r1241212157


##########
Dockerfile:
##########
@@ -25,7 +25,7 @@ ARG GOLANG_IMAGE=golang:latest
 FROM $PULSAR_IMAGE as pulsar
 FROM $GOLANG_IMAGE
 
-RUN apt-get update && apt-get install -y openjdk-17-jre-headless ca-certificates
+RUN apt-get update && apt-get install -y openjdk-17-jre ca-certificates

Review Comment:
   The `apachepulsar/pulsar:latest` includes the JDK, so I think we can remove this line, could you try remove this line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] crossoverJie commented on a diff in pull request #1037: Fix openjdk-17

Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie commented on code in PR #1037:
URL: https://github.com/apache/pulsar-client-go/pull/1037#discussion_r1241217172


##########
Dockerfile:
##########
@@ -25,7 +25,7 @@ ARG GOLANG_IMAGE=golang:latest
 FROM $PULSAR_IMAGE as pulsar
 FROM $GOLANG_IMAGE
 
-RUN apt-get update && apt-get install -y openjdk-17-jre-headless ca-certificates
+RUN apt-get update && apt-get install -y openjdk-17-jre ca-certificates

Review Comment:
   https://github.com/crossoverJie/pulsar-client-go/actions/runs/5370408829/jobs/9742470767?pr=5
   It seems like it cannot work properly,  need Java runtime environment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] tisonkun merged pull request #1037: Fix openjdk-17

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #1037:
URL: https://github.com/apache/pulsar-client-go/pull/1037


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] tisonkun commented on a diff in pull request #1037: Fix openjdk-17

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1037:
URL: https://github.com/apache/pulsar-client-go/pull/1037#discussion_r1241488235


##########
Dockerfile:
##########
@@ -25,7 +25,7 @@ ARG GOLANG_IMAGE=golang:latest
 FROM $PULSAR_IMAGE as pulsar
 FROM $GOLANG_IMAGE
 
-RUN apt-get update && apt-get install -y openjdk-17-jre-headless ca-certificates
+RUN apt-get update && apt-get install -y openjdk-17-jre ca-certificates

Review Comment:
   Agree. That can be a follow-up. Let's fix the current situation first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] nodece commented on a diff in pull request #1037: Fix openjdk-17

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on code in PR #1037:
URL: https://github.com/apache/pulsar-client-go/pull/1037#discussion_r1241450673


##########
Dockerfile:
##########
@@ -25,7 +25,7 @@ ARG GOLANG_IMAGE=golang:latest
 FROM $PULSAR_IMAGE as pulsar
 FROM $GOLANG_IMAGE
 
-RUN apt-get update && apt-get install -y openjdk-17-jre-headless ca-certificates
+RUN apt-get update && apt-get install -y openjdk-17-jre ca-certificates

Review Comment:
   Sorry, I didn't notice that we use the golang as the base image.
   
   I suggest we use the pulsar as the base image, and then we just need to install the golang to the base image.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org