[PR] feat(bitbucket): add post-review contract support [magpie]

["KatalKavya96 (via GitHub)" <gi...@apache.org>]

KatalKavya96 opened a new pull request, #1591:
URL: https://github.com/apache/magpie/pull/1591

   <!-- SPDX-License-Identifier: Apache-2.0
        https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ## Summary
   
   - Adds Bitbucket Cloud support for the backend-neutral `post_review(id, verdict, body) -> ok` change-request contract through `pr review <id> --verdict {comment,approve,request-changes} --body-file <path>`.
   - Reuses the existing Cloud comment / approve / request-changes primitives while preserving caller-side explicit confirmation and keeping Bitbucket Data Center fail-closed.
   - Handles Cloud's two-step approve/request-changes flow safely: the review body is posted first, and if the verdict mutation then fails, the command reports the partial outcome and tells callers to inspect the PR before retrying to avoid duplicate comments.
   
   ## Type of change
   
   - [ ] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
   - [x] Tool / bridge contract (`tools/<system>/*.md`)
   - [x] Python package (`tools/*/` with `pyproject.toml`)
   - [ ] Groovy reference impl
   - [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
   - [x] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
   - [ ] Project template (`projects/_template/`)
   - [ ] CI / dev loop (`prek`, workflows, validators)
   - [ ] Other:
   
   ## Test plan
   
   - [ ] `prek run --all-files` passes
   - [x] For Python packages touched: `uv run pytest` / `ruff check` / `mypy` passes
   - [ ] For Groovy bridges touched: command-line invocation tested end-to-end
   - [ ] For skill changes: eval suite passes for the affected skill
         (`PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/`)
   - [ ] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
         (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
   - [x] Other:
     - focused `post_review` backend / normalization / CLI tests pass
     - full Bitbucket test suite passes
     - `git diff --check` passes
     - workspace Ruff, formatting, mypy, pytest, validators, and spec checks pass
     - `prek run --all-files` currently fails only in the unrelated `skill-script-tests` hook because `plugins/magpie-pr-management/skills/stack-review/tests` reports `NO TESTS RAN`; no files under that area are changed by this PR
   
   ## RFC-AI-0004 compliance
   
   - [x] **HITL** — the new review mutation remains gated on explicit caller-side user confirmation
   - [x] **Sandbox** — no new unrestricted host access; the implementation reuses the existing guarded Bitbucket Cloud write path
   - [x] **Vendor neutrality** — the Bitbucket-specific operations are exposed through the generic `post_review` change-request contract with `comment`, `approve`, and `request-changes` verdicts
   - [ ] **Conversational + correctable** — agentic-override path documented if behaviour is adopter-tunable
   - [x] **Write-access discipline** — the bridge executes only an already-confirmed review; it does not decide or post reviews autonomously
   - [ ] **Privacy LLM** — private content does not reach a non-approved LLM; redactor invoked where needed
   
   ## Linked issues
   
   Refs #606
   
   ## Notes for reviewers (optional)
   
   Bitbucket Cloud does not expose the review body and approval/change-request verdict as one atomic mutation. For `approve` and `request-changes`, this adapter therefore posts the confirmed review body first and applies the verdict second.
   
   If that second request fails, the command fails with an explicit partial-outcome warning directing the caller to inspect `pr discussion` and `pr reviews` before retrying. This avoids silently retrying the whole operation and duplicating the already-posted review comment.
   
   Bitbucket Data Center has a different review API and remains explicitly unsupported here to keep this follow-up narrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(bitbucket): add post-review contract support [magpie]

["KatalKavya96 (via GitHub)" <gi...@apache.org>]

KatalKavya96 commented on PR #1591:
URL: https://github.com/apache/magpie/pull/1591#issuecomment-6100029071

   Hi @potiuk — next narrow #606 follow-up after #1577.
   
   This adds Bitbucket Cloud `post_review(id, verdict, body)` support via `pr review`, covering `comment`, `approve`, and `request-changes`.
   
   For approve/request-changes, the review body is posted first and the verdict second; if the second step fails, the command reports the partial outcome and tells the caller to inspect before retrying to avoid duplicate comments. Data Center remains fail-closed.
   
   Focused/full Bitbucket tests, Ruff, mypy, workspace pytest, validators, and spec checks are green. The only `prek --all-files` failure is the unrelated `stack-review/tests` “NO TESTS RAN” sibling-script hook.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(bitbucket): add post-review contract support [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #1591:
URL: https://github.com/apache/magpie/pull/1591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org