[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #2968: fix `RowWriter` index out of bounds error

[GitBox <gi...@apache.org>]

yjshen commented on code in PR #2968:
URL: https://github.com/apache/arrow-datafusion/pull/2968#discussion_r931737325


##########
datafusion/row/src/writer.rs:
##########
@@ -349,7 +349,7 @@ pub(crate) fn write_field_utf8(
     let from = from.as_any().downcast_ref::<StringArray>().unwrap();
     let s = from.value(row_idx);
     let new_width = to.current_width() + s.as_bytes().len();

Review Comment:
   @liukun4515 can elaborate on why there are two '+ 8' suggested?
   
   ```
       self.varlena_offset += (size + 8);
       self.varlena_width += (size +8);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org