You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2009/01/26 14:41:59 UTC
[jira] Created: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
back-compat tests ("ant test-tag") should test JAR drop-in-ability
------------------------------------------------------------------
Key: LUCENE-1529
URL: https://issues.apache.org/jira/browse/LUCENE-1529
Project: Lucene - Java
Issue Type: New Feature
Components: Build
Affects Versions: 2.9
Reporter: Michael McCandless
Priority: Minor
Fix For: 2.9
We now test back-compat with "ant test-tag", which is very useful for
catching breaks in back compat before committing.
However, that currently checks out "src/test" sources and then
compiles them against the trunk JAR, and runs the tests. Whereas our
back compat policy:
http://wiki.apache.org/lucene-java/BackwardsCompatibility
states that no recompilation is required on upgrading to a new JAR.
Ie you should be able to drop in the new JAR in place of your old one
and things should work fine.
So... we should fix "ant test-tag" to:
* Do full checkout of core sources & tests from the back-compat-tag
* Compile the JAR from the back-compat sources
* Compile the tests against that back-compat JAR
* Swap in the trunk JAR
* Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Reopened: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reopened LUCENE-1529:
----------------------------------------
I think something is wrong with this fix. Over in LUCENE-1593 we hit a case where (I think) the test should have failed, because we changed a method from returning void to returning something else.
EG if you change IndexWriter.addDocument to (say) return int instead of void, then I think ant test-tag should fail, but it doesn't.
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1529.
----------------------------------------
Resolution: Fixed
OK I think it's all fixed now. Thanks Shai!
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699177#action_12699177 ]
Michael McCandless commented on LUCENE-1529:
--------------------------------------------
Yes, indeed -- should be fixed now (I retagged it). We can't change it to checkout the branch since people with older checkouts will suddenly see the the back-compat tests failing. That's why we switched to a tag a while back.
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699012#action_12699012 ]
Michael Busch commented on LUCENE-1529:
---------------------------------------
Good catch! Thanks for fixing this, Shai and Mike!
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-1529:
----------------------------------
Attachment: lucene-1529.patch
Changes 'test-tag' in build.xml to executes the compatibility tests like Mike described here.
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699030#action_12699030 ]
Shai Erera commented on LUCENE-1529:
------------------------------------
Mike - you 'almost' fixed it :)
I "ant clean test-tag" and still sees failures. So I checked and common-build.xml still references lucene_2_4_back_compat_tests_20090320. I do see your changes on the lucene_2_4_back_compat_tests branch, but you didn't tag those changes?
We can either move to checkout this code from the branch (thus preventing such issues in the future), in build.xml target=download-tag, or tag the changes and update common-build.xml.
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698907#action_12698907 ]
Shai Erera commented on LUCENE-1529:
------------------------------------
Perhaps that's related: target test-tag has this step:
{code}
<!-- compile tag tests against tag jar -->
<compile-test-macro srcdir="${tags.dir}/${tag}/src/test" destdir="${build.dir}/${tag}/classes/test"
test.classpath="tag.test.classpath"/>
{code}
Notice that test.classpath is set to tag.test.classpath, which is defined as:
{code}
<path id="tag.test.classpath">
<path refid="demo.classpath"/>
<path refid="junit-path"/>
<pathelement location="${build.dir}/${tag}/classes/test"/>
<pathelement location="${build.dir}/${tag}/${tag}.jar"/>
</path>
{code}
"demo.classpath" includes build/classes/demo as well as build/classes/java, which includes the current trunk's build classes.
If I change the definition to rely only on tag.jar, demo classes and junit jar:
{code}
<path id="tag.test.classpath">
<path refid="junit-path"/>
<pathelement location="${build.dir}/classes/demo"/>
<pathelement location="${build.dir}/${tag}/${tag}.jar"/>
</path>
{code}
I get errors like this:
{code}
[javac] Compiling 128 source files to D:\dev\lucene\lucene-trunk\build\lucene_2_4_back_compat_tests_20090320\classes\test
[javac] D:\dev\lucene\lucene-trunk\tags\lucene_2_4_back_compat_tests_20090320\src\test\org\apache\lucene\index\TestIndexReaderReopen.java:323: cannot find symbol
[javac] symbol : method getSequentialSubReaders()
[javac] location: class org.apache.lucene.index.MultiSegmentReader
[javac] IndexReader[] subReaders0 = ((MultiSegmentReader) reader0).getSequentialSubReaders();
[javac] ^
[javac] D:\dev\lucene\lucene-trunk\tags\lucene_2_4_back_compat_tests_20090320\src\test\org\apache\lucene\index\TestIndexReaderReopen.java:335: cannot find symbol
[javac] symbol : method getSequentialSubReaders()
[javac] location: class org.apache.lucene.index.MultiSegmentReader
[javac] IndexReader[] subReaders1 = ((MultiSegmentReader) reader1).getSequentialSubReaders();
[javac] ^
{code}
That's because tag.jar's MultiSegmentReader does not have a getSequentialSubReaders method, however TestIndexReaderReopen calls it. Is that ok?
Anyway, can it be that the classes/java in the classpath cause this change to not fail?
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch reassigned LUCENE-1529:
-------------------------------------
Assignee: Michael Busch
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch resolved LUCENE-1529.
-----------------------------------
Resolution: Fixed
Committed revision 756374.
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1529) back-compat tests ("ant test-tag")
should test JAR drop-in-ability
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698932#action_12698932 ]
Michael McCandless commented on LUCENE-1529:
--------------------------------------------
bq. If I change the definition to rely only on tag.jar, demo classes and junit jar:
Ooh that's good progress!
Hmm, yes we will now see compilation errors because over time we've made "legal" fixes to the test source code, corresponding to changes in 2.9. Eg, since FieldInfo is package private, we're allowed to rename omitTf to OmitTermFreqAndPositions, and if a test (TestOmitTf) is using package-private access to access omitTf, it's OK to fix that test to match the new name.
So I think the only way to make "legal" changes to the back-compat tests is to backport [a subset of, or perhaps compile-time emulation of] the 2.9 changes onto the 2.4 branch src/java/*. Or, to fix tests not to rely on package private APIs. I think that's OK (we make such changes rarely)? I'll go and fix the back-compat branch accordingly...
> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
> Key: LUCENE-1529
> URL: https://issues.apache.org/jira/browse/LUCENE-1529
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Build
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests. Whereas our
> back compat policy:
> http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
> * Do full checkout of core sources & tests from the back-compat-tag
> * Compile the JAR from the back-compat sources
> * Compile the tests against that back-compat JAR
> * Swap in the trunk JAR
> * Run the tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org