You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/22 13:14:46 UTC
[GitHub] [logging-log4j2] sman-81 opened a new pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port
sman-81 opened a new pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528
My fix for LOG4J2-3107 changes two files and adds one. The change is now targeted at the release-2.x branch not master.
Hope you find it useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on a change in pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port
Posted by GitBox <gi...@apache.org>.
vy commented on a change in pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528#discussion_r658042296
##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##########
@@ -166,9 +172,7 @@ private static String createManagerName(
sb.append(isDebug ? ":debug:" : "::");
sb.append(filterName);
- final String hash = NameUtil.md5(sb.toString());
- return "SMTP:" + hash;
-
+ return "SMTP:" + sb.toString();
Review comment:
Given `password` is in `sb`, this is not a good idea. Would you mind reverting this line, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528#issuecomment-869065479
@vy your cherry pick broke master. Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528#issuecomment-868304938
Thanks so much for the fix @sman-81!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy merged pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port
Posted by GitBox <gi...@apache.org>.
vy merged pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port
Posted by GitBox <gi...@apache.org>.
sman-81 commented on a change in pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528#discussion_r658542585
##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##########
@@ -166,9 +172,7 @@ private static String createManagerName(
sb.append(isDebug ? ":debug:" : "::");
sb.append(filterName);
- final String hash = NameUtil.md5(sb.toString());
- return "SMTP:" + hash;
-
+ return "SMTP:" + sb.toString();
Review comment:
Hello @vy,
thanks for your feedback.
I've removed password from creation of smtp manager name, as it is irrelevant for creating a unique per-configuration name/key (cannot have same user name with different password on same host).
Greetings,
Markus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528#issuecomment-869214491
[The associated GitHub Actions run](/apache/logging-log4j2/actions/runs/970729092) has succeeded. What is exactly broken?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528#issuecomment-869215875
Ralph figured it out earlier today. It was in the wrong package in master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org