Re: [PR] feat: Add progress bar with ETA estimation to datafusion-cli [datafusion]

["pepijnve (via GitHub)" <gi...@apache.org>]

pepijnve commented on code in PR #17867:
URL: https://github.com/apache/datafusion/pull/17867#discussion_r2606099315


##########
datafusion-cli/src/progress/estimator.rs:
##########


Review Comment:
   I would be inclined to just remove the Kalman and linear code and the CLI switch. It feels a bit pointless to me to give an end-user of the CLI control over something that's an implementation detail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org