You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by br...@apache.org on 2004/02/27 21:12:06 UTC
cvs commit: db-ojb/src/java/org/apache/ojb/broker/accesslayer/sql SqlSelectByPkStatement.java
brj 2004/02/27 12:12:06
Modified: src/java/org/apache/ojb/broker/accesslayer/sql
SqlSelectByPkStatement.java
Log:
fixed minor problems detected by findbugs
Revision Changes Path
1.6 +5 -4 db-ojb/src/java/org/apache/ojb/broker/accesslayer/sql/SqlSelectByPkStatement.java
Index: SqlSelectByPkStatement.java
===================================================================
RCS file: /home/cvs/db-ojb/src/java/org/apache/ojb/broker/accesslayer/sql/SqlSelectByPkStatement.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- SqlSelectByPkStatement.java 8 Nov 2002 13:29:30 -0000 1.5
+++ SqlSelectByPkStatement.java 27 Feb 2004 20:12:06 -0000 1.6
@@ -95,16 +95,17 @@
* @return list of column names for the set of all unique columns for multiple classes mapped to the
* same table.
*/
- protected List appendListOfColumnsForSelect(ClassDescriptor cld, StringBuffer buf)
+ protected List appendListOfColumnsForSelect(ClassDescriptor cld, StringBuffer buf)
{
FieldDescriptor[] fieldDescriptors = cld.getRepository().getFieldDescriptorsForMultiMappedTable(cld);
- int fieldDescriptorLength = fieldDescriptors.length;
ArrayList columnList = new ArrayList();
- int i = 0;
if (fieldDescriptors != null)
{
+ int i = 0;
+ int fieldDescriptorLength = fieldDescriptors.length;
FieldDescriptor field = null;
+
for (int j = 0; j < fieldDescriptorLength; j++)
{
field = fieldDescriptors[j];
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org