You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by srouthiau <gi...@git.apache.org> on 2015/03/19 16:15:58 UTC
[GitHub] httpcore pull request: Reuse of SessionInputBuffer and SessionOutp...
GitHub user srouthiau opened a pull request:
https://github.com/apache/httpcore/pull/9
Reuse of SessionInputBuffer and SessionOutputBuffer internal buffers
Commit https://github.com/apache/httpcore/commit/47654da6f027af3cbbd27600ba6df0911e529387
Reusing of internal buffer to limit memory usage. Performance improvements on our load tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srouthiau/httpcore trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcore/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit b998fe991e97e1ccef208350dbbca6c2a751359c
Author: srouthiau <st...@gmail.com>
Date: 2014-09-10T15:24:19Z
Update AbstractNIOConnPool.java
commit 81c740937be7fb95cc42b195c15c6a185d5937ec
Author: srouthiau <st...@gmail.com>
Date: 2014-09-10T15:25:00Z
Update RouteSpecificPool.java
commit dc8ebf14b0b21311ac2005a2e53de155439784a1
Author: srouthiau <st...@gmail.com>
Date: 2014-09-10T15:26:11Z
Update SessionRequestCallback.java
commit 3895133eb24e585b80a8145c15aeb04e1ba74e07
Author: srouthiau <st...@gmail.com>
Date: 2014-09-10T15:27:04Z
Update DefaultConnectingIOReactor.java
commit 47654da6f027af3cbbd27600ba6df0911e529387
Author: srouthiau <st...@routhiau-conseil.fr>
Date: 2015-03-19T14:48:25Z
reuse of SessionInputBuffer and SessionOutputBuffer internal buffers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request: Reuse of SessionInputBuffer and SessionOutp...
Posted by srouthiau <gi...@git.apache.org>.
Github user srouthiau commented on the pull request:
https://github.com/apache/httpcore/pull/9#issuecomment-83643143
This opt was done in the scope of one of my customer mission. I don't know
if he want to invest more time for this.
I'll ask him next time and let you know.
For the use of ThreadLocal, il agree it can lead to reuse large (too large)
buffers, that's why i have included a test to check if the buffer is not
too large to we can reuse it.
Stephane
2015-03-19 16:47 GMT+01:00 Oleg Kalnichevski <no...@github.com>:
> Thread locals are really a double-edged sword and should be used sparingly
> in low level libraries. Can we provide a strategy interface similar to
> SSLBufferManagementStrategy in order to support multiple allocation
> strategies?
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/httpcore/pull/9#issuecomment-83640151>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request: Reuse of SessionInputBuffer and SessionOutp...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the pull request:
https://github.com/apache/httpcore/pull/9#issuecomment-83630948
What number in percent are we looking at?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request: Reuse of SessionInputBuffer and SessionOutp...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the pull request:
https://github.com/apache/httpcore/pull/9#issuecomment-83640151
Thread locals are really a double-edged sword and should be used sparingly in low level libraries. Can we provide a strategy interface similar to SSLBufferManagementStrategy in order to support multiple allocation strategies?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request: Reuse of SessionInputBuffer and SessionOutp...
Posted by srouthiau <gi...@git.apache.org>.
Github user srouthiau commented on the pull request:
https://github.com/apache/httpcore/pull/9#issuecomment-83637940
It was about 9 % of our total memory consumption. I don't have a test with
only httpcore and httpclient
httpcore usage on SessionInputBuffer was the 2nd on profiler hot spot
analysis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org