[GitHub] [tvm] vinx13 commented on a diff in pull request #12505: [TIR][Schedule] Support for specific consumer block targeting in cache_read

[GitBox <gi...@apache.org>]

vinx13 commented on code in PR #12505:
URL: https://github.com/apache/tvm/pull/12505#discussion_r950520445


##########
python/tvm/tir/schedule/schedule.py:
##########
@@ -1031,6 +1035,10 @@ def cache_read(
         storage_scope: str
             The target storage scope.
 
+        consumer_blocks: Optional[List[Union[BlockRV, str]]]

Review Comment:
   typing is inconsistent with impl below that allows passing a single `BlockRV`



##########
include/tvm/tir/schedule/schedule.h:
##########
@@ -389,7 +389,8 @@ class ScheduleNode : public runtime::Object {
    * \return The cache stage block.
    */
   virtual BlockRV CacheRead(const BlockRV& block_rv, int read_buffer_index,
-                            const String& storage_scope) = 0;
+                            const String& storage_scope,
+                            const Array<BlockRV> consumer_blocks = {}) = 0;

Review Comment:
   need to document param `consumer_blocks`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org