You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 21:55:09 UTC
[GitHub] [arrow] nealrichardson commented on a change in pull request #10372: ARROW-11926: [R] Add ucrt64 binaries and fix CI
nealrichardson commented on a change in pull request #10372:
URL: https://github.com/apache/arrow/pull/10372#discussion_r639231494
##########
File path: ci/scripts/r_windows_build.sh
##########
@@ -27,10 +27,10 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# Use rtools-backports if building with rtools35
curl https://raw.githubusercontent.com/r-windows/rtools-backports/master/pacman.conf > /etc/pacman.conf
# Update keys: https://www.msys2.org/news/#2020-06-29-new-packagers
- msys2_repo_base_url=https://repo.msys2.org/msys
- curl -OSsL "${msys2_repo_base_url}/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz"
- pacman -U --noconfirm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz && rm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
- pacman --noconfirm -Scc
+ #msys2_repo_base_url=https://repo.msys2.org/msys
+ #curl -OSsL "${msys2_repo_base_url}/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz"
+ #pacman -U --noconfirm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz && rm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
+ #pacman --noconfirm -Scc
Review comment:
```suggestion
```
##########
File path: ci/scripts/r_windows_build.sh
##########
@@ -27,10 +27,10 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# Use rtools-backports if building with rtools35
curl https://raw.githubusercontent.com/r-windows/rtools-backports/master/pacman.conf > /etc/pacman.conf
# Update keys: https://www.msys2.org/news/#2020-06-29-new-packagers
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org