You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Marcel Kinard <cm...@gmail.com> on 2012/10/29 18:36:50 UTC
license issue in incubator-cordova-wp7
I was looking at
incubator-cordova-wp7/templates/standalone/cordovalib/Commands/AudioPlayer.cs
and noticed on line 529 a URL to someone's blog. I looked at the blog,
and it is a code sample for writing a WAV audio header. I looked back at
the cordova source file and realized that two methods in the cordova
source are a straight copy-and-paste from the blog.
The blog indicates that samples provided fall under the Microsoft Public
License (Ms-PL). So I think some action here is necessary, such as:
a) the terms of the Ms-PL need to be followed, such as including a full
copy of the Ms-PL in the cordova distribution, or
b) rewrite these 2 methods with unique code.
Given that these 2 methods are following a spec to write out a WAV
header, doing a rewrite would seem to be easy. What does the group here
think, and who could correct this issue? It would seem this needs to get
taken care of before the final release of 2.2.0.
Also looks like the exact same issue exists in another source file,
incubator-cordova-wp7/templates/standalone/cordovalib/UI/AudioRecorder.xaml.cs
-- Marcel Kinard
RE: license issue in incubator-cordova-wp7
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
* The code was added by me so I CAN handle this and re-write copy-paste.
Would like to fix this licensing issue.
-----Original Message-----
From: Sergey Grebnov (Akvelon) [mailto:v-segreb@microsoft.com]
Sent: Monday, October 29, 2012 11:06 PM
To: dev@cordova.apache.org
Subject: RE: license issue in incubator-cordova-wp7
The code was added by me so I can't handle this and re-write copy-paste.
-----Original Message-----
From: Shazron [mailto:shazron@gmail.com]
Sent: Monday, October 29, 2012 10:29 PM
To: dev@cordova.apache.org
Subject: Re: license issue in incubator-cordova-wp7
a) Have you posted an issue with Legal-Discuss list for clarification to know for sure?
On Mon, Oct 29, 2012 at 11:25 AM, Jesse <pu...@gmail.com> wrote:
> a) is not an option, as I believe the licenses are not compatible
>
> private void WriteWavHeader(Stream stream, int sampleRate)
> - would be hard to write any other way as it is just a step by step
> implementation of the header spec.
>
> private void UpdateWavHeader(Stream stream)
> - will need to be rewritten
>
>
>
>
>
>
> On Mon, Oct 29, 2012 at 10:36 AM, Marcel Kinard <cm...@gmail.com> wrote:
>> I was looking at
>> incubator-cordova-wp7/templates/standalone/cordovalib/Commands/AudioP
>> layer.cs and noticed on line 529 a URL to someone's blog. I looked at
>> the blog, and it is a code sample for writing a WAV audio header. I
>> looked back at the cordova source file and realized that two methods
>> in the cordova source are a straight copy-and-paste from the blog.
>>
>> The blog indicates that samples provided fall under the Microsoft
>> Public License (Ms-PL). So I think some action here is necessary, such as:
>>
>> a) the terms of the Ms-PL need to be followed, such as including a
>> full copy of the Ms-PL in the cordova distribution, or
>> b) rewrite these 2 methods with unique code.
>>
>> Given that these 2 methods are following a spec to write out a WAV
>> header, doing a rewrite would seem to be easy. What does the group
>> here think, and who could correct this issue? It would seem this
>> needs to get taken care of before the final release of 2.2.0.
>>
>> Also looks like the exact same issue exists in another source file,
>> incubator-cordova-wp7/templates/standalone/cordovalib/UI/AudioRecorde
>> r.xaml.cs
>>
>> -- Marcel Kinard
>
>
>
> --
> @purplecabbage
> risingj.com
RE: license issue in incubator-cordova-wp7
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
The code was added by me so I can't handle this and re-write copy-paste.
-----Original Message-----
From: Shazron [mailto:shazron@gmail.com]
Sent: Monday, October 29, 2012 10:29 PM
To: dev@cordova.apache.org
Subject: Re: license issue in incubator-cordova-wp7
a) Have you posted an issue with Legal-Discuss list for clarification to know for sure?
On Mon, Oct 29, 2012 at 11:25 AM, Jesse <pu...@gmail.com> wrote:
> a) is not an option, as I believe the licenses are not compatible
>
> private void WriteWavHeader(Stream stream, int sampleRate)
> - would be hard to write any other way as it is just a step by step
> implementation of the header spec.
>
> private void UpdateWavHeader(Stream stream)
> - will need to be rewritten
>
>
>
>
>
>
> On Mon, Oct 29, 2012 at 10:36 AM, Marcel Kinard <cm...@gmail.com> wrote:
>> I was looking at
>> incubator-cordova-wp7/templates/standalone/cordovalib/Commands/AudioP
>> layer.cs and noticed on line 529 a URL to someone's blog. I looked at
>> the blog, and it is a code sample for writing a WAV audio header. I
>> looked back at the cordova source file and realized that two methods
>> in the cordova source are a straight copy-and-paste from the blog.
>>
>> The blog indicates that samples provided fall under the Microsoft
>> Public License (Ms-PL). So I think some action here is necessary, such as:
>>
>> a) the terms of the Ms-PL need to be followed, such as including a
>> full copy of the Ms-PL in the cordova distribution, or
>> b) rewrite these 2 methods with unique code.
>>
>> Given that these 2 methods are following a spec to write out a WAV
>> header, doing a rewrite would seem to be easy. What does the group
>> here think, and who could correct this issue? It would seem this
>> needs to get taken care of before the final release of 2.2.0.
>>
>> Also looks like the exact same issue exists in another source file,
>> incubator-cordova-wp7/templates/standalone/cordovalib/UI/AudioRecorde
>> r.xaml.cs
>>
>> -- Marcel Kinard
>
>
>
> --
> @purplecabbage
> risingj.com
Re: license issue in incubator-cordova-wp7
Posted by Shazron <sh...@gmail.com>.
a) Have you posted an issue with Legal-Discuss list for clarification
to know for sure?
On Mon, Oct 29, 2012 at 11:25 AM, Jesse <pu...@gmail.com> wrote:
> a) is not an option, as I believe the licenses are not compatible
>
> private void WriteWavHeader(Stream stream, int sampleRate)
> - would be hard to write any other way as it is just a step by step
> implementation of the header spec.
>
> private void UpdateWavHeader(Stream stream)
> - will need to be rewritten
>
>
>
>
>
>
> On Mon, Oct 29, 2012 at 10:36 AM, Marcel Kinard <cm...@gmail.com> wrote:
>> I was looking at
>> incubator-cordova-wp7/templates/standalone/cordovalib/Commands/AudioPlayer.cs
>> and noticed on line 529 a URL to someone's blog. I looked at the blog, and
>> it is a code sample for writing a WAV audio header. I looked back at the
>> cordova source file and realized that two methods in the cordova source are
>> a straight copy-and-paste from the blog.
>>
>> The blog indicates that samples provided fall under the Microsoft Public
>> License (Ms-PL). So I think some action here is necessary, such as:
>>
>> a) the terms of the Ms-PL need to be followed, such as including a full copy
>> of the Ms-PL in the cordova distribution, or
>> b) rewrite these 2 methods with unique code.
>>
>> Given that these 2 methods are following a spec to write out a WAV header,
>> doing a rewrite would seem to be easy. What does the group here think, and
>> who could correct this issue? It would seem this needs to get taken care of
>> before the final release of 2.2.0.
>>
>> Also looks like the exact same issue exists in another source file,
>> incubator-cordova-wp7/templates/standalone/cordovalib/UI/AudioRecorder.xaml.cs
>>
>> -- Marcel Kinard
>
>
>
> --
> @purplecabbage
> risingj.com
Re: license issue in incubator-cordova-wp7
Posted by Jesse <pu...@gmail.com>.
a) is not an option, as I believe the licenses are not compatible
private void WriteWavHeader(Stream stream, int sampleRate)
- would be hard to write any other way as it is just a step by step
implementation of the header spec.
private void UpdateWavHeader(Stream stream)
- will need to be rewritten
On Mon, Oct 29, 2012 at 10:36 AM, Marcel Kinard <cm...@gmail.com> wrote:
> I was looking at
> incubator-cordova-wp7/templates/standalone/cordovalib/Commands/AudioPlayer.cs
> and noticed on line 529 a URL to someone's blog. I looked at the blog, and
> it is a code sample for writing a WAV audio header. I looked back at the
> cordova source file and realized that two methods in the cordova source are
> a straight copy-and-paste from the blog.
>
> The blog indicates that samples provided fall under the Microsoft Public
> License (Ms-PL). So I think some action here is necessary, such as:
>
> a) the terms of the Ms-PL need to be followed, such as including a full copy
> of the Ms-PL in the cordova distribution, or
> b) rewrite these 2 methods with unique code.
>
> Given that these 2 methods are following a spec to write out a WAV header,
> doing a rewrite would seem to be easy. What does the group here think, and
> who could correct this issue? It would seem this needs to get taken care of
> before the final release of 2.2.0.
>
> Also looks like the exact same issue exists in another source file,
> incubator-cordova-wp7/templates/standalone/cordovalib/UI/AudioRecorder.xaml.cs
>
> -- Marcel Kinard
--
@purplecabbage
risingj.com