You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/17 02:35:57 UTC

[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #10480: [Feature-10422][Task] Added Apache SeaTunnel 2.x task node

Amy0104 commented on code in PR #10480:
URL: https://github.com/apache/dolphinscheduler/pull/10480#discussion_r899713683


##########
dolphinscheduler-ui/src/views/projects/task/components/node/types.ts:
##########
@@ -396,6 +398,8 @@ interface INodeData
   udfs?: string[]
   customConfig?: boolean
   mapping_columns?: object[]
+  useCustom?: boolean
+  runMode?: string

Review Comment:
   No need to define 'useCustom' and 'runMode' here if you have already defined them in ITaskParams as the same types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org