You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/30 06:02:06 UTC

[GitHub] [orc] autumnust commented on pull request #922: ORC-1013: Renaming the object of WriterContext in all TreeWriter's derived class

autumnust commented on pull request #922:
URL: https://github.com/apache/orc/pull/922#issuecomment-930810172


   > If we want to change this, I prefer to use `context` instead of writerContext`because it's more consistent with the base class,`TreeWriterBase`.
   > 
   > ```
   >   TreeWriterBase(TypeDescription schema,
   >                  WriterEncryptionVariant encryption,
   >                  WriterContext context) throws IOException {
   > ```
   
   agree. Will address. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org