You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/29 14:32:09 UTC
Review Request 63398: Added a missing hash function for v1 resource
provider ID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63398/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Greg Mann.
Repository: mesos
Description
-------
Added a missing hash function for v1 resource provider ID.
Diffs
-----
include/mesos/v1/mesos.hpp 0ed78fc86ca0035a59b994c5399d722ce742f7d2
Diff: https://reviews.apache.org/r/63398/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 63398: Added a missing hash function for v1
resource provider ID.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63398/#review189561
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Oct. 29, 2017, 4:51 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63398/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2017, 4:51 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a missing hash function for v1 resource provider ID.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.hpp 0ed78fc86ca0035a59b994c5399d722ce742f7d2
>
>
> Diff: https://reviews.apache.org/r/63398/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63398: Added a missing hash function for v1
resource provider ID.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63398/
-----------------------------------------------------------
(Updated Oct. 29, 2017, 3:51 p.m.)
Review request for mesos, Benjamin Bannier and Greg Mann.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Added a missing hash function for v1 resource provider ID.
Diffs (updated)
-----
include/mesos/v1/mesos.hpp 0ed78fc86ca0035a59b994c5399d722ce742f7d2
Diff: https://reviews.apache.org/r/63398/diff/2/
Changes: https://reviews.apache.org/r/63398/diff/1-2/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 63398: Added a missing hash function for v1
resource provider ID.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63398/#review189519
-----------------------------------------------------------
Bad patch!
Reviews applied: [63398, 63397, 63396, 63356, 63312, 63105, 61946, 61810, 63104, 63094, 62903, 63001]
Failed command: python support/apply-reviews.py -n -r 63312
Error:
2017-10-29 15:32:19 URL:https://reviews.apache.org/r/63312/diff/raw/ [15399/15399] -> "63312.patch" [1]
error: patch failed: src/v1/resources.cpp:1814
error: src/v1/resources.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19929/console
- Mesos Reviewbot
On Oct. 29, 2017, 2:32 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63398/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a missing hash function for v1 resource provider ID.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.hpp 0ed78fc86ca0035a59b994c5399d722ce742f7d2
>
>
> Diff: https://reviews.apache.org/r/63398/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>