You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "garydgregory (via GitHub)" <gi...@apache.org> on 2023/04/10 12:45:26 UTC

[GitHub] [commons-compress] garydgregory commented on pull request #378: Optimize the nameMap of ZipFile

garydgregory commented on PR #378:
URL: https://github.com/apache/commons-compress/pull/378#issuecomment-1501773958

   No tests. Code coverage is down. No proof of performance change one way or another. Non-trivial additional complexity. So -1 as it stands. 
   
   "For extremely rare situations, this PR may have slight negative effects,"
   
   Which are?
   
   "But I think this should not be a problem."
   
   Because? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org