You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2025/09/29 08:03:37 UTC
[PR] GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input [arrow]
wgtmac opened a new pull request, #47667:
URL: https://github.com/apache/arrow/pull/47667
### Rationale for this change
See https://oss-fuzz.com/testcase-detail/4656328221196288
### What changes are included in this PR?
Return error on invalid data pointer inside the DeltaByteArrayDecoderImpl.
### Are these changes tested?
Pass all CIs.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47667:
URL: https://github.com/apache/arrow/pull/47667#issuecomment-3345563917
:warning: GitHub issue #47666 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #47667:
URL: https://github.com/apache/arrow/pull/47667#discussion_r2388358400
##########
cpp/src/parquet/decoder.cc:
##########
@@ -178,6 +178,9 @@ struct ArrowBinaryHelper<ByteArrayType, ArrowBinaryType> {
Status AppendValue(const uint8_t* data, int32_t length,
std::optional<int64_t> estimated_remaining_data_length = {}) {
+ if (ARROW_PREDICT_FALSE(data == nullptr)) {
Review Comment:
Perhaps we need find out in which case this is nullptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47667:
URL: https://github.com/apache/arrow/pull/47667#discussion_r2413913265
##########
cpp/src/parquet/decoder.cc:
##########
@@ -178,6 +178,9 @@ struct ArrowBinaryHelper<ByteArrayType, ArrowBinaryType> {
Status AppendValue(const uint8_t* data, int32_t length,
std::optional<int64_t> estimated_remaining_data_length = {}) {
+ if (ARROW_PREDICT_FALSE(data == nullptr)) {
Review Comment:
Have you investigated this @mapleFU ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #47667:
URL: https://github.com/apache/arrow/pull/47667#issuecomment-3347127373
Does this fix make sense? @mapleFU @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input [arrow]
Posted by "stackedsax (via GitHub)" <gi...@apache.org>.
stackedsax commented on PR #47667:
URL: https://github.com/apache/arrow/pull/47667#issuecomment-5981282821
Superseded by #47741, which fixed the root cause in the decoder so the null pointer no longer reaches AppendValue. See #47666 for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed pull request #47667: GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input
URL: https://github.com/apache/arrow/pull/47667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org