You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by su...@apache.org on 2021/09/01 08:02:30 UTC

[superset] 02/04: configurable default categorical scheme

This is an automated email from the ASF dual-hosted git repository.

suddjian pushed a commit to branch default-color-scheme
in repository https://gitbox.apache.org/repos/asf/superset.git

commit de5a38c9e11c7291d40bf5179654daace05430b2
Author: David Aaron Suddjian <aa...@gmail.com>
AuthorDate: Tue Aug 31 19:07:27 2021 -0700

    configurable default categorical scheme
---
 superset-frontend/src/setup/setupColors.ts | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/setup/setupColors.ts b/superset-frontend/src/setup/setupColors.ts
index 4068dd0..b7d1ee3 100644
--- a/superset-frontend/src/setup/setupColors.ts
+++ b/superset-frontend/src/setup/setupColors.ts
@@ -33,14 +33,14 @@ import {
 import superset from '@superset-ui/core/lib/color/colorSchemes/categorical/superset';
 
 export default function setupColors(
-  extraCategoricalColorSchemas: CategoricalScheme[] = [],
+  extraCategoricalColorSchemes: CategoricalScheme[] = [],
   extraSequentialColorSchemes: SequentialScheme[] = [],
 ) {
   // Register color schemes
   const categoricalSchemeRegistry = getCategoricalSchemeRegistry();
 
-  if (extraCategoricalColorSchemas?.length > 0) {
-    extraCategoricalColorSchemas.forEach(scheme => {
+  if (extraCategoricalColorSchemes?.length > 0) {
+    extraCategoricalColorSchemes.forEach(scheme => {
       categoricalSchemeRegistry.registerValue(scheme.id, scheme);
     });
   }
@@ -52,7 +52,10 @@ export default function setupColors(
       });
     },
   );
-  categoricalSchemeRegistry.setDefaultKey('supersetColors');
+  const defaultKey =
+    extraCategoricalColorSchemes.find(scheme => scheme.isDefault)?.id ||
+    'supersetColors';
+  categoricalSchemeRegistry.setDefaultKey(defaultKey);
 
   const sequentialSchemeRegistry = getSequentialSchemeRegistry();